Skip to content

Commit 8f90f4e

Browse files
committed
cleanup
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
1 parent 8f35ad5 commit 8f90f4e

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

ENVOY_VERSION

Lines changed: 0 additions & 1 deletion
This file was deleted.

Makefile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ check: precommit ## Run all necessary steps to prepare for a commit and check fo
7272
test: test-rust test-rust ## Run all tests for the codebase.
7373
.PHONY: test-go
7474
test-go:## Run the unit tests for the Go codebase. This doesn't run the integration tests like test-* targets.
75-
@$(call print_task,Building and Running Go)
75+
@$(call print_task,Running Go tests)
7676
@cd go && go test -v ./...
7777
@$(call print_success,Go unit tests completed)
7878
.PHONY: test-rust
7979
test-rust: ## Run the unit tests for the Rust codebase.
80-
@$(call print_task,Building and Running Rust)
80+
@$(call print_task,Running Rust tests)
8181
@cd rust && cargo test
8282
@$(call print_success,Rust unit tests completed)
8383

@@ -98,7 +98,8 @@ build-rust: ## Build the Rust dynamic module.
9898
@cd rust && cargo build
9999
@$(call print_success,Rust dynamic module built at rust/target/debug/librust_module.so)
100100
@$(call print_task,Copying Rust dynamic module for easier use with Envoy)
101-
@cp rust/target/debug/librust_module.dylib integration/librust_module.so
101+
@cp rust/target/debug/librust_module.dylib integration/librust_module.so || true
102+
@cp rust/target/debug/librust_module.so integration/librust_module.so || true
102103

103104
.PHONY: integration-test
104105
integration-test: build-go build-rust ## Run the integration tests.

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dynamic Modules Examples
22

3-
> Envoy Version: [6d9bb7d9a85d616b220d1f8fe67b61f82bbdb8d3] v1.37.0
3+
> Envoy Version: v1.37.0
44
>
55
> Since dynamic modules are tied with a specific Envoy version, this repository is based on the specific commit of Envoy.
66
> For examples for a specific Envoy version, please check out `release/v<version>` branches:
@@ -35,6 +35,5 @@ make build # Build all dynamic modules
3535
make integration-test # Run integration tests with Envoy
3636
```
3737

38-
[6d9bb7d9a85d616b220d1f8fe67b61f82bbdb8d3]: https://github.com/envoyproxy/envoy/tree/6d9bb7d9a85d616b220d1f8fe67b61f82bbdb8d3
3938
[Envoy]: https://github.com/envoyproxy/envoy
4039
[High Level Doc]: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/advanced/dynamic_modules

0 commit comments

Comments
 (0)