clean-up: use Mutex reference p1 (#42670)

Replace absl::MutexLock::MutexLock(Mutex*) constructor with
absl::MutexLock::MutexLock(Mutex&)
Similar to #41948

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>

Author: botengyao

source/common/quic/quic_server_transport_socket_factory.cc

@@ -154,7 +154,7 @@ QuicServerTransportSocketFactory::getTlsCertificateAndKey(absl::string_view sni,
   // ssl_ctx. Capture ssl_ctx_ into a local variable so that we check and use the same ssl_ctx.
   Envoy::Ssl::ServerContextSharedPtr ssl_ctx;
   {
-    absl::ReaderMutexLock l(&ssl_ctx_mu_);
+    absl::ReaderMutexLock l(ssl_ctx_mu_);
     ssl_ctx = ssl_ctx_;
   }
   if (!ssl_ctx) {
@@ -181,7 +181,7 @@ absl::Status QuicServerTransportSocketFactory::onSecretUpdated() {
   auto ctx_or_error = createSslServerContext();
   RETURN_IF_NOT_OK(ctx_or_error.status());
   {
-    absl::WriterMutexLock l(&ssl_ctx_mu_);
+    absl::WriterMutexLock l(ssl_ctx_mu_);
     std::swap(*ctx_or_error, ssl_ctx_);
   }
   manager_.removeContext(*ctx_or_error);

source/common/tls/client_context_impl.cc

@@ -162,7 +162,7 @@ ClientContextImpl::newSsl(const Network::TransportSocketOptionsConstSharedPtr& o
   if (max_session_keys_ > 0) {
     if (session_keys_single_use_) {
       // Stored single-use session keys, use write/write locks.
-      absl::WriterMutexLock l(&session_keys_mu_);
+      absl::WriterMutexLock l(session_keys_mu_);
       if (!session_keys_.empty()) {
         // Use the most recently stored session key, since it has the highest
         // probability of still being recognized/accepted by the server.
@@ -175,7 +175,7 @@ ClientContextImpl::newSsl(const Network::TransportSocketOptionsConstSharedPtr& o
       }
     } else {
       // Never stored single-use session keys, use read/write locks.
-      absl::ReaderMutexLock l(&session_keys_mu_);
+      absl::ReaderMutexLock l(session_keys_mu_);
       if (!session_keys_.empty()) {
         // Use the most recently stored session key, since it has the highest
         // probability of still being recognized/accepted by the server.
@@ -194,7 +194,7 @@ int ClientContextImpl::newSessionKey(SSL_SESSION* session) {
   if (SSL_SESSION_should_be_single_use(session)) {
     session_keys_single_use_ = true;
   }
-  absl::WriterMutexLock l(&session_keys_mu_);
+  absl::WriterMutexLock l(session_keys_mu_);
   // Evict oldest entries.
   while (session_keys_.size() >= max_session_keys_) {
     session_keys_.pop_back();

source/common/tls/client_ssl_socket.cc

@@ -43,7 +43,7 @@ ClientSslSocketFactory::ClientSslSocketFactory(Envoy::Ssl::ClientContextConfigPt
     : manager_(manager), stats_scope_(stats_scope), stats_(generateStats(stats_scope)),
       config_(std::move(config)) {
   {
-    absl::WriterMutexLock l(&ssl_ctx_mu_);
+    absl::WriterMutexLock l(ssl_ctx_mu_);
     auto ctx_or_error = manager_.createSslClientContext(stats_scope_, *config_);
     SET_AND_RETURN_IF_NOT_OK(ctx_or_error.status(), creation_status);
     ssl_ctx_ = *ctx_or_error;
@@ -61,7 +61,7 @@ Network::TransportSocketPtr ClientSslSocketFactory::createTransportSocket(
   // use the same ssl_ctx to create SslSocket.
   Envoy::Ssl::ClientContextSharedPtr ssl_ctx;
   {
-    absl::ReaderMutexLock l(&ssl_ctx_mu_);
+    absl::ReaderMutexLock l(ssl_ctx_mu_);
     ssl_ctx = ssl_ctx_;
   }
   if (ssl_ctx) {
@@ -86,7 +86,7 @@ absl::Status ClientSslSocketFactory::onAddOrUpdateSecret() {
   auto ctx_or_error = manager_.createSslClientContext(stats_scope_, *config_);
   RETURN_IF_NOT_OK(ctx_or_error.status());
   {
-    absl::WriterMutexLock l(&ssl_ctx_mu_);
+    absl::WriterMutexLock l(ssl_ctx_mu_);
     std::swap(*ctx_or_error, ssl_ctx_);
   }
   manager_.removeContext(*ctx_or_error);
@@ -95,7 +95,7 @@ absl::Status ClientSslSocketFactory::onAddOrUpdateSecret() {
 }
 
 Envoy::Ssl::ClientContextSharedPtr ClientSslSocketFactory::sslCtx() {
-  absl::ReaderMutexLock l(&ssl_ctx_mu_);
+  absl::ReaderMutexLock l(ssl_ctx_mu_);
   return ssl_ctx_;
 }
 

source/common/tls/server_ssl_socket.cc

@@ -57,7 +57,7 @@ Network::TransportSocketPtr ServerSslSocketFactory::createDownstreamTransportSoc
   // use the same ssl_ctx to create SslSocket.
   Envoy::Ssl::ServerContextSharedPtr ssl_ctx;
   {
-    absl::ReaderMutexLock l(&ssl_ctx_mu_);
+    absl::ReaderMutexLock l(ssl_ctx_mu_);
     ssl_ctx = ssl_ctx_;
   }
   if (ssl_ctx) {
@@ -81,7 +81,7 @@ absl::Status ServerSslSocketFactory::onAddOrUpdateSecret() {
   auto ctx_or_error = manager_.createSslServerContext(stats_scope_, *config_, nullptr);
   RETURN_IF_NOT_OK(ctx_or_error.status());
   {
-    absl::WriterMutexLock l(&ssl_ctx_mu_);
+    absl::WriterMutexLock l(ssl_ctx_mu_);
     std::swap(*ctx_or_error, ssl_ctx_);
   }
   manager_.removeContext(*ctx_or_error);