Skip to content

Commit e04dab6

Browse files
committed
Separate windows patches
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
1 parent c6f5fc6 commit e04dab6

7 files changed

Lines changed: 84 additions & 88 deletions

File tree

bazel/com_google_protoconverter.patch

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,3 @@
1-
diff --git a/build_defs/BUILD.bazel b/build_defs/BUILD.bazel
2-
index 732514d..a6be18b 100644
3-
--- a/build_defs/BUILD.bazel
4-
+++ b/build_defs/BUILD.bazel
5-
@@ -13,10 +13,23 @@ package(
6-
)
7-
8-
create_compiler_config_setting(
9-
- name = "config_msvc",
10-
+ name = "config_msvc_cl",
11-
value = "msvc-cl",
12-
)
13-
14-
+create_compiler_config_setting(
15-
+ name = "config_clang_cl",
16-
+ value = "clang-cl",
17-
+)
18-
+
19-
+selects.config_setting_group(
20-
+ name = "config_msvc",
21-
+ match_any = [
22-
+ ":config_clang_cl",
23-
+ ":config_msvc_cl",
24-
+ ],
25-
+)
26-
+
27-
config_setting(
28-
name = "aarch64",
29-
values = {"cpu": "linux-aarch_64"},
301
diff --git a/src/google/protobuf/stubs/BUILD.bazel b/src/google/protobuf/stubs/BUILD.bazel
312
index a7b8c82..4f66827 100644
323
--- a/src/google/protobuf/stubs/BUILD.bazel
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
diff --git a/build_defs/BUILD.bazel b/build_defs/BUILD.bazel
2+
index 732514d..a6be18b 100644
3+
--- a/build_defs/BUILD.bazel
4+
+++ b/build_defs/BUILD.bazel
5+
@@ -13,10 +13,23 @@ package(
6+
)
7+
8+
create_compiler_config_setting(
9+
- name = "config_msvc",
10+
+ name = "config_msvc_cl",
11+
value = "msvc-cl",
12+
)
13+
14+
+create_compiler_config_setting(
15+
+ name = "config_clang_cl",
16+
+ value = "clang-cl",
17+
+)
18+
+
19+
+selects.config_setting_group(
20+
+ name = "config_msvc",
21+
+ match_any = [
22+
+ ":config_clang_cl",
23+
+ ":config_msvc_cl",
24+
+ ],
25+
+)
26+
+
27+
config_setting(
28+
name = "aarch64",
29+
values = {"cpu": "linux-aarch_64"},

bazel/foreign_cc/BUILD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ configure_make(
4141
"skip_on_windows",
4242
],
4343
targets = ["install"],
44+
target_compatible_with = ["@platforms//os:linux"],
4445
)
4546

4647
envoy_cc_library(
@@ -461,6 +462,7 @@ configure_make(
461462
"//bazel:windows_x86_64": ["libdl.a"],
462463
"//conditions:default": [],
463464
}),
465+
target_compatible_with = ["@platforms//os:windows"],
464466
)
465467

466468
cc_library(

bazel/foreign_cc/cel-cpp.patch

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,3 @@
1-
diff --git a/bazel/cel_proto_transitive_descriptor_set.bzl b/bazel/cel_proto_transitive_descriptor_set.bzl
2-
index e65e0b4a..18837236 100644
3-
--- a/bazel/cel_proto_transitive_descriptor_set.bzl
4-
+++ b/bazel/cel_proto_transitive_descriptor_set.bzl
5-
@@ -30,6 +30,7 @@ def _cel_proto_transitive_descriptor_set(ctx):
6-
progress_message = "Joining descriptors.",
7-
command = ("< \"$1\" xargs cat >{output}".format(output = output.path)),
8-
arguments = [args],
9-
+ use_default_shell_env = True,
10-
)
11-
return DefaultInfo(
12-
files = depset([output]),
131
diff --git a/common/internal/byte_string.cc b/common/internal/byte_string.cc
142
index b9f47922..9d096424 100644
153
--- a/common/internal/byte_string.cc

bazel/foreign_cc/luajit.patch

Lines changed: 1 addition & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ index c83abfa0..0276f9e3 100644
5353
##############################################################################
5454
diff --git a/luajit_build.sh b/luajit_build.sh
5555
new file mode 100755
56-
index 00000000..8dca96e6
56+
index 00000000..3b4f8eca
5757
--- /dev/null
5858
+++ b/luajit_build.sh
5959
@@ -0,0 +1,68 @@
@@ -125,47 +125,3 @@ index 00000000..8dca96e6
125125
+"${MAKE:-make}" -j$(nproc) V=1 PREFIX="$PREFIX" \
126126
+ "${EXTRA_MAKE_ARGS[@]}" \
127127
+ install
128-
diff --git a/luajit_build_win.sh b/luajit_build_win.sh
129-
new file mode 100755
130-
index 00000000..a493e7e0
131-
--- /dev/null
132-
+++ b/luajit_build_win.sh
133-
@@ -0,0 +1,38 @@
134-
+#!/bin/bash
135-
+
136-
+set -e
137-
+
138-
+PREFIX=""
139-
+while [[ $# -gt 0 ]]; do
140-
+ case $1 in
141-
+ --prefix=*)
142-
+ PREFIX="${1#*=}"
143-
+ shift
144-
+ ;;
145-
+ --prefix)
146-
+ PREFIX="$2"
147-
+ shift 2
148-
+ ;;
149-
+ *)
150-
+ shift
151-
+ ;;
152-
+ esac
153-
+done
154-
+
155-
+# Copy source tree to a build directory
156-
+SRC_DIR="$(dirname "$(realpath "$0")")"
157-
+BUILD_DIR="$(basename "$SRC_DIR")"
158-
+cp -r "$SRC_DIR" "$BUILD_DIR"
159-
+cd "$BUILD_DIR"
160-
+
161-
+cd src
162-
+./msvcbuild.bat static
163-
+
164-
+mkdir -p "$PREFIX/lib"
165-
+cp lua51.lib vc140.pdb "$PREFIX/lib"
166-
+mkdir -p "$PREFIX/include/luajit-2.1"
167-
+for header in lauxlib.h luaconf.h lua.h lua.hpp luajit.h lualib.h; do
168-
+ cp "$header" "$PREFIX/include/luajit-2.1"
169-
+done
170-
+mkdir -p "$PREFIX/bin"
171-
+cp luajit.exe "$PREFIX/bin"

bazel/foreign_cc/luajit_win.patch

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
diff --git a/luajit_build_win.sh b/luajit_build_win.sh
2+
new file mode 100755
3+
index 00000000..a493e7e0
4+
--- /dev/null
5+
+++ b/luajit_build_win.sh
6+
@@ -0,0 +1,38 @@
7+
+#!/bin/bash
8+
+
9+
+set -e
10+
+
11+
+PREFIX=""
12+
+while [[ $# -gt 0 ]]; do
13+
+ case $1 in
14+
+ --prefix=*)
15+
+ PREFIX="${1#*=}"
16+
+ shift
17+
+ ;;
18+
+ --prefix)
19+
+ PREFIX="$2"
20+
+ shift 2
21+
+ ;;
22+
+ *)
23+
+ shift
24+
+ ;;
25+
+ esac
26+
+done
27+
+
28+
+# Copy source tree to a build directory
29+
+SRC_DIR="$(dirname "$(realpath "$0")")"
30+
+BUILD_DIR="$(basename "$SRC_DIR")"
31+
+cp -r "$SRC_DIR" "$BUILD_DIR"
32+
+cd "$BUILD_DIR"
33+
+
34+
+cd src
35+
+./msvcbuild.bat static
36+
+
37+
+mkdir -p "$PREFIX/lib"
38+
+cp lua51.lib vc140.pdb "$PREFIX/lib"
39+
+mkdir -p "$PREFIX/include/luajit-2.1"
40+
+for header in lauxlib.h luaconf.h lua.h lua.hpp luajit.h lualib.h; do
41+
+ cp "$header" "$PREFIX/include/luajit-2.1"
42+
+done
43+
+mkdir -p "$PREFIX/bin"
44+
+cp luajit.exe "$PREFIX/bin"

bazel/repositories.bzl

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,10 @@ def _cc_deps():
8383
external_http_archive(
8484
name = "com_google_protoconverter",
8585
patch_args = ["-p1"],
86-
patches = ["@envoy//bazel:com_google_protoconverter.patch"],
86+
patches = [
87+
"@envoy//bazel:com_google_protoconverter.patch",
88+
"@envoy//bazel:com_google_protoconverter_win.patch",
89+
],
8790
patch_cmds = [
8891
"rm src/google/protobuf/stubs/common.cc",
8992
"rm src/google/protobuf/stubs/common.h",
@@ -808,7 +811,10 @@ def _com_github_luajit_luajit():
808811
external_http_archive(
809812
name = "com_github_luajit_luajit",
810813
build_file_content = BUILD_ALL_CONTENT,
811-
patches = ["@envoy//bazel/foreign_cc:luajit.patch"],
814+
patches = [
815+
"@envoy//bazel/foreign_cc:luajit.patch",
816+
"@envoy//bazel/foreign_cc:luajit_win.patch",
817+
],
812818
patch_args = ["-p1"],
813819
)
814820

0 commit comments

Comments
 (0)