refactor(ui): ♻️ update ReferenceReplacementDialog and manager for slot handling

Author: esnya

AGENTS.md

@@ -12,6 +12,7 @@ This file is **authoritative and persistent** for everything under `/ReferenceRe
    - Private, potentially sensitive research (e.g., raw assembly dumps, exploratory notes) must live under the git-ignored `local_notes/` directory, each topic in its own markdown file to keep knowledge granular.
 5. **Persistence:** Any change to policies/workflow must be reflected here immediately. Subdirectories inherit these rules unless they define their own `AGENTS.md`.
 6. **Data model constraints:** This mod must not introduce new FrooxEngine data-model types or `SyncDelegate` definitions. All functionality must be built on existing data-model constructs to avoid sync registration overhead.
+7. **Design notes ban:** Do not create standalone design notes or ADR-style docs; instead, keep commits and code self-explanatory and update this AGENTS file if process rules change.
 
 ## Scope / Status
 

src/ReferenceReplacement/Logic/ReferenceScanner.cs

@@ -3,6 +3,7 @@
 using System.Collections.Generic;
 using System.Reflection;
 using System.Runtime.CompilerServices;
+
 using FrooxEngine;
 
 namespace ReferenceReplacement.Logic;
@@ -13,7 +14,7 @@ public static ReferenceScanResult Scan(Slot root, IWorldElement source, IWorldEl
     {
         ArgumentNullException.ThrowIfNull(root);
 
-        var session = new ReferenceScanSession(source, target);
+        ReferenceScanSession session = new(source, target);
         session.VisitSlot(root, TraversalPath.FromSlot(root));
         return session.BuildResult();
     }
@@ -22,8 +23,8 @@ internal static ReferenceScanResult Scan(HierarchyBlueprint blueprintRoot, IWorl
     {
         ArgumentNullException.ThrowIfNull(blueprintRoot);
 
-        var session = new ReferenceScanSession(source, target);
-        session.VisitBlueprint(blueprintRoot, new TraversalPath(blueprintRoot.Label));
+        ReferenceScanSession session = new(source, target);
+        session.VisitBlueprint(blueprintRoot, new(blueprintRoot.Label));
         return session.BuildResult();
     }
 
@@ -369,10 +370,10 @@ internal sealed record HierarchyBlueprint(string Label, IReadOnlyList<ISyncMembe
 {
     public static HierarchyBlueprint Create(string label, IEnumerable<ISyncMember> members, IEnumerable<HierarchyBlueprint>? children = null)
     {
-        var memberList = members is IReadOnlyList<ISyncMember> readyMembers
+        IReadOnlyList<ISyncMember> memberList = members is IReadOnlyList<ISyncMember> readyMembers
             ? readyMembers
             : new List<ISyncMember>(members ?? Array.Empty<ISyncMember>());
-        var childList = children is IReadOnlyList<HierarchyBlueprint> readyChildren
+        IReadOnlyList<HierarchyBlueprint> childList = children is IReadOnlyList<HierarchyBlueprint> readyChildren
             ? readyChildren
             : new List<HierarchyBlueprint>(children ?? Array.Empty<HierarchyBlueprint>());
         return new HierarchyBlueprint(label, memberList, childList);
@@ -386,4 +387,4 @@ internal sealed class ReferenceEqualityComparer : IEqualityComparer<object>
     public new bool Equals(object? x, object? y) => ReferenceEquals(x, y);
 
     public int GetHashCode(object obj) => RuntimeHelpers.GetHashCode(obj);
-}
+}

src/ReferenceReplacement/Properties/AssemblyInfo.cs

@@ -2,4 +2,4 @@
 
 [assembly: AssemblyVersion("0.1.0.0")]
 [assembly: AssemblyFileVersion("0.1.0.0")]
-[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("ReferenceReplacement.Tests")]
+[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("ReferenceReplacement.Tests")]

src/ReferenceReplacement/ReferenceReplacementMod.cs

@@ -1,7 +1,11 @@
 using System;
+
 using FrooxEngine;
+
 using HarmonyLib;
+
 using ReferenceReplacement.UI;
+
 using ResoniteModLoader;
 #if USE_RESONITE_HOT_RELOAD_LIB
 using ResoniteHotReloadLib;
@@ -63,4 +67,4 @@ private static void RegisterCreationEntry()
 
         _creationEntryRegistered = true;
     }
-}
+}

src/ReferenceReplacement/UI/ReferenceReplacementDialog.cs

@@ -1,10 +1,13 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+
 using Elements.Core;
+
 using FrooxEngine;
 using FrooxEngine.UIX;
 using FrooxEngine.Undo;
+
 using ReferenceReplacement.Logic;
 
 namespace ReferenceReplacement.UI;
@@ -21,11 +24,10 @@ public sealed class ReferenceReplacementDialog
     private Text? _detailText;
     private bool _disposed;
 
-    private ReferenceReplacementDialog(User owner)
+    private ReferenceReplacementDialog(User owner, Slot dialogSlot)
     {
         _owner = owner ?? throw new ArgumentNullException(nameof(owner));
-        Slot? userSpace = owner.LocalUserSpace ?? throw new InvalidOperationException("User space is unavailable.");
-        _rootSlot = userSpace.AddSlot("Reference Replacement Dialog");
+        _rootSlot = dialogSlot ?? throw new ArgumentNullException(nameof(dialogSlot));
         _rootSlot.Destroyed += OnSlotDestroyed;
         ClearSlot(_rootSlot);
 
@@ -39,9 +41,9 @@ private ReferenceReplacementDialog(User owner)
         RepositionFor(owner);
     }
 
-    public static ReferenceReplacementDialog Create(User owner)
+    public static ReferenceReplacementDialog Create(User owner, Slot dialogSlot)
     {
-        return new ReferenceReplacementDialog(owner);
+        return new ReferenceReplacementDialog(owner, dialogSlot);
     }
 
     public bool HasProcessRoot => GetProcessRootSlot() != null;
@@ -217,7 +219,7 @@ private void BuildStatusSection(UIBuilder ui)
 
     private void Analyze(bool applyChanges)
     {
-        if (!TryResolveInputs(out var root, out var source, out var target, out var errorMessage))
+        if (!TryResolveInputs(out Slot root, out IWorldElement source, out IWorldElement target, out string errorMessage))
         {
             UpdateStatus(errorMessage);
             return;
@@ -386,4 +388,4 @@ private void PrepareRootSlot(User owner)
         _rootSlot.LocalPosition = float3.Zero;
         _rootSlot.LocalRotation = floatQ.Identity;
     }
-}
+}

src/ReferenceReplacement/UI/ReferenceReplacementDialogManager.cs

@@ -1,21 +1,31 @@
+using System;
+
 using FrooxEngine;
 
 namespace ReferenceReplacement.UI;
 
 internal static class ReferenceReplacementDialogManager
 {
-    public static void Show(User? localUser)
+    public static void Show(Slot creationSlot)
     {
+        if (creationSlot == null)
+        {
+            return;
+        }
+
+        User? localUser = creationSlot.World?.LocalUser;
         if (localUser == null)
         {
+            creationSlot.Destroy();
             return;
         }
 
-        ReferenceReplacementDialog.Create(localUser);
+        ReferenceReplacementDialog.Create(localUser, creationSlot);
     }
 
     public static void Unregister(ReferenceReplacementDialog dialog)
     {
+        ArgumentNullException.ThrowIfNull(dialog);
     }
 
-}
+}

src/ReferenceReplacement/UI/ReferenceReplacementEntryPoint.cs

@@ -11,21 +11,7 @@ public static void OpenFromSlot(Slot? creationSlot)
             return;
         }
 
-        User? localUser = creationSlot.World?.LocalUser;
-        if (localUser == null)
-        {
-            creationSlot.Destroy();
-            return;
-        }
-
-        try
-        {
-            ReferenceReplacementDialogManager.Show(localUser);
-        }
-        finally
-        {
-            creationSlot.Destroy();
-        }
+        ReferenceReplacementDialogManager.Show(creationSlot);
     }
 
-}
+}