refactor(ui): ♻️ streamline ReferenceReplacement dialog and menu integration

Author: esnya

AGENTS.md

@@ -3,6 +3,7 @@
 This file is **authoritative and persistent** for everything under `/ReferenceReplacementMod`. Keep it in version control and treat its directives as mandatory.
 
 ## Directives
+
 1. **Golden rule:** Relentlessly minimize complexity, maximize changeability, and enforce strict static checks to suppress runtime bugs. Names, code, and directory structures must be self-explanatory—avoid relying on comments/docs for basic comprehension.
 2. **Testing cadence:** Hands-on runtime testing happens later in a live Resonite session; until then, document assumptions and leave TODOs rather than speculative fixes.
 3. **Localization:** UI remains English-only until Resonite exposes extensible localization hooks. Do not ship partial translations; revisit only when upstream enables custom locale registration.
@@ -13,11 +14,14 @@ This file is **authoritative and persistent** for everything under `/ReferenceRe
 6. **Data model constraints:** This mod must not introduce new FrooxEngine data-model types or `SyncDelegate` definitions. All functionality must be built on existing data-model constructs to avoid sync registration overhead.
 
 ## Scope / Status
+
 - Repository initialized 2025-11-12 with Reference Replacement mod for ResoniteModLoader.
-- Current deliverable: Dev Tool UI for bulk `ISyncRef` replacement plus creation-menu hook.
+- Current deliverable: Userspace dialog for bulk `ISyncRef` replacement, launched exclusively from the `Create New > Editor` menu entry.
 
 ## Localization Policy (Public Summary)
+
 - English-only interface. Reevaluate once Resonite core supports custom localized strings for Dev Tool menus and UIX builders.
 
 ## History Tracking Rule
+
 - Detailed work history lives in the git commit log; do not maintain manual work logs in docs. Summaries belong in commit messages and PR descriptions only.

README.md

@@ -2,13 +2,7 @@
 
 A [ResoniteModLoader](https://github.com/resonite-modding-group/ResoniteModLoader) mod for [Resonite](https://resonite.com/) that mirrors the Asset Optimization workflow to bulk swap every matching `ISyncRef` inside a single undo batch.
 
-## Features
-
-- Dev Tool context-menu entry (**Reference Replacement…**) to open the dialog from any inspected slot.
-- Userspace dialog with pickers for process root, source reference, and replacement target.
-- Analyze button that previews compatible vs incompatible hits before committing.
-- Replace button that writes every compatible reference atomically for clean undo support.
-- Automatic skip counters so incompatible targets are reported instead of silently failing.
+Launch the tool via `Create New > Editor > Reference Replacement (Mod)` in the Dev Create menu.
 
 ## Installation
 

src/ReferenceReplacement/Logic/ReferenceScanner.cs

@@ -135,55 +135,103 @@ private void VisitMember(ISyncMember member, TraversalPath path)
                 VisitEnumerable(enumerable, path);
             }
 
-            foreach (PropertyInfo enumerableProperty in EnumerableInspector.GetEnumerableProperties(member.GetType()))
+            VisitKnownCollections(member, path);
+        }
+
+        private void VisitKnownCollections(ISyncMember member, TraversalPath path)
+        {
+            switch (member)
             {
-                if (!TryGetEnumerableProperty(member, enumerableProperty, out IEnumerable? nested))
-                {
-                    continue;
-                }
+                case ISyncList syncList:
+                    VisitEnumerableProperty(() => syncList.Elements, path, nameof(ISyncList.Elements));
+                    break;
+                case ISyncBag syncBag:
+                    VisitEnumerableProperty(() => syncBag.Elements, path, nameof(ISyncBag.Elements));
+                    VisitEnumerableProperty(() => syncBag.Values, path, nameof(ISyncBag.Values));
+                    break;
+                case ISyncDictionary syncDictionary:
+                    VisitEnumerableProperty(() => syncDictionary.BoxedEntries, path, nameof(ISyncDictionary.BoxedEntries));
+                    VisitEnumerableProperty(() => syncDictionary.Values, path, nameof(ISyncDictionary.Values));
+                    break;
+                case ISyncArray syncArray:
+                    VisitSyncArray(syncArray, path);
+                    break;
+            }
+        }
 
-                if (nested == null)
-                {
-                    continue;
-                }
+        private void VisitEnumerableProperty(Func<IEnumerable?> accessor, TraversalPath parentPath, string propertyName)
+        {
+            IEnumerable? enumerable;
+            try
+            {
+                enumerable = accessor();
+            }
+            catch (Exception ex) when (IsSafeToIgnore(ex))
+            {
+                return;
+            }
 
-                if (_accumulator.ShouldVisitEnumerable(nested))
-                {
-                    VisitEnumerable(nested, path.NextProperty(enumerableProperty.Name));
-                }
+            if (enumerable == null)
+            {
+                return;
+            }
+
+            if (_accumulator.ShouldVisitEnumerable(enumerable))
+            {
+                VisitEnumerable(enumerable, parentPath.NextProperty(propertyName));
             }
         }
 
-        private static bool TryGetEnumerableProperty(ISyncMember member, PropertyInfo property, out IEnumerable? result)
+        private void VisitSyncArray(ISyncArray array, TraversalPath parentPath)
         {
-            result = null;
-            object? value;
-
+            int count;
             try
             {
-                value = property.GetValue(member);
+                count = array.Count;
             }
-            catch (TargetInvocationException ex) when (IsSafeToIgnore(ex.InnerException))
+            catch (Exception ex) when (IsSafeToIgnore(ex))
             {
-                return false;
+                return;
             }
-            catch (NotSupportedException)
+
+            TraversalPath itemsPath = parentPath.NextProperty("Items");
+            for (int index = 0; index < count; index++)
             {
-                return false;
+                object? element;
+                try
+                {
+                    element = array.GetElement(index);
+                }
+                catch (Exception ex) when (IsSafeToIgnore(ex))
+                {
+                    continue;
+                }
+
+                VisitNestedItem(element, itemsPath.NextIndex(index));
             }
+        }
 
-            if (value is not IEnumerable enumerable)
+        private void VisitNestedItem(object? item, TraversalPath path)
+        {
+            if (item == null)
             {
-                return false;
+                return;
             }
 
-            result = enumerable;
-            return true;
+            switch (item)
+            {
+                case ISyncMember member:
+                    VisitMember(member, path);
+                    break;
+                case IEnumerable nested when _accumulator.ShouldVisitEnumerable(nested):
+                    VisitEnumerable(nested, path);
+                    break;
+            }
         }
 
         private static bool IsSafeToIgnore(Exception? exception)
         {
-            return exception is NotSupportedException;
+            return exception is NotSupportedException or InvalidOperationException;
         }
 
         private void VisitEnumerable(IEnumerable enumerable, TraversalPath path)
@@ -198,15 +246,7 @@ private void VisitEnumerable(IEnumerable enumerable, TraversalPath path)
                     continue;
                 }
 
-                switch (item)
-                {
-                    case ISyncMember member:
-                        VisitMember(member, itemPath);
-                        break;
-                    case IEnumerable nested when _accumulator.ShouldVisitEnumerable(nested):
-                        VisitEnumerable(nested, itemPath);
-                        break;
-                }
+                VisitNestedItem(item, itemPath);
 
                 index++;
             }
@@ -354,25 +394,6 @@ private bool SupportsTarget(ISyncRef syncRef)
 
     private static class EnumerableInspector
     {
-        private static readonly ConditionalWeakTable<Type, PropertyInfo[]> Cache = new();
-
-        internal static PropertyInfo[] GetEnumerableProperties(Type type)
-        {
-            if (Cache.TryGetValue(type, out var cached))
-            {
-                return cached;
-            }
-
-            PropertyInfo[] discovered = Array.FindAll(
-                type.GetProperties(BindingFlags.Instance | BindingFlags.Public),
-                prop => prop.GetIndexParameters().Length == 0 &&
-                        typeof(IEnumerable).IsAssignableFrom(prop.PropertyType) &&
-                        prop.PropertyType != typeof(string));
-
-            Cache.Add(type, discovered);
-            return discovered;
-        }
-
         internal static ISyncRef? TryExtractSyncRef(object candidate)
         {
             Type type = candidate.GetType();
@@ -382,7 +403,7 @@ internal static PropertyInfo[] GetEnumerableProperties(Type type)
             }
 
             PropertyInfo? valueProperty = type.GetProperty("Value");
-            if (valueProperty == null || !typeof(ISyncRef).IsAssignableFrom(valueProperty.PropertyType))
+            if (valueProperty == null)
             {
                 return null;
             }

src/ReferenceReplacement/Patching/DevToolMenuPatch.cs

@@ -21,7 +21,7 @@ public sealed class ReferenceReplacementDialog
     private Text? _detailText;
     private bool _disposed;
 
-    private ReferenceReplacementDialog(User owner, Slot? dialogSlot, Slot? suggestedRoot)
+    private ReferenceReplacementDialog(User owner)
     {
         _owner = owner ?? throw new ArgumentNullException(nameof(owner));
         Slot? userSpace = owner.LocalUserSpace ?? throw new InvalidOperationException("User space is unavailable.");
@@ -34,15 +34,14 @@ private ReferenceReplacementDialog(User owner, Slot? dialogSlot, Slot? suggested
 
         ConfigureRootSlot();
         BuildUI();
-        InitializeInputs(suggestedRoot);
         UpdateStatus("Select inputs to begin.");
         Focus();
         RepositionFor(owner);
     }
 
-    public static ReferenceReplacementDialog Create(User owner, Slot? dialogSlot, Slot? suggestedRoot)
+    public static ReferenceReplacementDialog Create(User owner)
     {
-        return new ReferenceReplacementDialog(owner, dialogSlot, suggestedRoot);
+        return new ReferenceReplacementDialog(owner);
     }
 
     public bool HasProcessRoot => GetProcessRootSlot() != null;
@@ -101,11 +100,6 @@ public void Close()
         ReferenceReplacementDialogManager.Unregister(this);
     }
 
-    private void InitializeInputs(Slot? suggestedRoot)
-    {
-        _processRootRef.Target = suggestedRoot ?? null!;
-    }
-
     private (ISyncRef processRoot, ISyncRef source, ISyncRef target) CreateReferenceFields()
     {
         return (CreateReferenceProxy(), CreateReferenceProxy(), CreateReferenceProxy());
@@ -229,20 +223,20 @@ private void Analyze(bool applyChanges)
             return;
         }
 
-        ReferenceScanResult scanResult = ReferenceScanner.Scan(root, source, target);
-        if (scanResult.Matches.Count == 0)
-        {
-            UpdateStatus("No references found in the selected root.");
-            return;
-        }
-
         if (!applyChanges)
         {
+            ReferenceScanResult scanResult = ReferenceScanner.Scan(root, source, target);
+            if (scanResult.Matches.Count == 0)
+            {
+                UpdateStatus("No references found in the selected root.");
+                return;
+            }
+
             UpdateStatus($"Found {scanResult.Matches.Count} references (skipped {scanResult.IncompatibleCount}).", scanResult);
             return;
         }
 
-        ApplyReplacement(scanResult, root, target);
+        ApplyReplacement(root, source, target);
     }
 
     private bool TryResolveInputs(out Slot root, out IWorldElement source, out IWorldElement target, out string message)
@@ -304,8 +298,15 @@ private bool TryResolveInputs(out Slot root, out IWorldElement source, out IWorl
         return _processRootRef.Target as Slot;
     }
 
-    private void ApplyReplacement(ReferenceScanResult scanResult, Slot root, IWorldElement target)
+    private void ApplyReplacement(Slot root, IWorldElement source, IWorldElement target)
     {
+        ReferenceScanResult scanResult = ReferenceScanner.Scan(root, source, target);
+        if (scanResult.Matches.Count == 0)
+        {
+            UpdateStatus("No references found in the selected root.");
+            return;
+        }
+
         World? world = root.World;
         if (world == null)
         {

src/ReferenceReplacement/UI/ReferenceReplacementDialog.cs

@@ -1,24 +1,17 @@
-using System;
-using System.Collections.Generic;
-using Elements.Core;
 using FrooxEngine;
 
 namespace ReferenceReplacement.UI;
 
 internal static class ReferenceReplacementDialogManager
 {
-    public static void Show(Slot? dialogSlot, Slot? suggestedRoot)
+    public static void Show(User? localUser)
     {
-        User? localUser = dialogSlot?.World?.LocalUser ?? suggestedRoot?.World?.LocalUser;
         if (localUser == null)
         {
-            dialogSlot?.Destroy();
             return;
         }
 
-        dialogSlot?.Destroy();
-
-        ReferenceReplacementDialog.Create(localUser, null, suggestedRoot);
+        ReferenceReplacementDialog.Create(localUser);
     }
 
     public static void Unregister(ReferenceReplacementDialog dialog)