refactor(UI): ♻️ streamline dialog management and entry point logic

Author: esnya

Directory.Build.props

@@ -8,6 +8,7 @@
 
   <PropertyGroup Condition="'$(ResoniteAssembliesDir)'==''">
     <ResoniteAssembliesDir>$(MSBuildThisFileDirectory)Resonite/</ResoniteAssembliesDir>
+    <ResoniteAssembliesDir Condition="Exists('/mnt/c/Program Files (x86)/Steam/steamapps/common/Resonite/')">/mnt/c/Program Files (x86)/Steam/steamapps/common/Resonite/</ResoniteAssembliesDir>
     <ResoniteAssembliesDir Condition="Exists('C:\\Program Files (x86)\\Steam\\steamapps\\common\\Resonite\\')">C:\\Program Files (x86)\\Steam\\steamapps\\common\\Resonite\\</ResoniteAssembliesDir>
     <ResoniteAssembliesDir Condition="Exists('$(HOME)/.steam/steam/steamapps/common/Resonite/')">$(HOME)/.steam/steam/steamapps/common/Resonite/</ResoniteAssembliesDir>
   </PropertyGroup>

src/ReferenceReplacement/Properties/AssemblyInfo.cs

@@ -2,4 +2,4 @@
 
 [assembly: AssemblyVersion("0.1.0.0")]
 [assembly: AssemblyFileVersion("0.1.0.0")]
-[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("ReferenceReplacement.Tests")]
+[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("ReferenceReplacement.Tests")]

src/ReferenceReplacement/ReferenceReplacementMod.cs

@@ -63,8 +63,8 @@ private static void RegisterCreationEntry()
             return;
         }
 
-        DevCreateNewForm.AddAction(CreationMenuCategory, CreationMenuLabel, ReferenceReplacementEntryPoint.OpenFromSlot);
+        DevCreateNewForm.AddAction(CreationMenuCategory, CreationMenuLabel, ReferenceReplacementDialog.OpenFromSlot);
 
         _creationEntryRegistered = true;
     }
-}
+}

src/ReferenceReplacement/UI/ReferenceReplacementDialog.cs

@@ -14,7 +14,6 @@ namespace ReferenceReplacement.UI;
 
 public sealed class ReferenceReplacementDialog
 {
-    private readonly User _owner;
     private readonly Slot _rootSlot;
     private readonly ISyncRef _processRootRef;
     private readonly ISyncRef _sourceRef;
@@ -24,15 +23,28 @@ public sealed class ReferenceReplacementDialog
     private Text? _detailText;
     private bool _disposed;
 
+    public static void OpenFromSlot(Slot creationSlot)
+    {
+        ArgumentNullException.ThrowIfNull(creationSlot);
+
+        User? localUser = creationSlot.World?.LocalUser;
+        if (localUser == null)
+        {
+            creationSlot.Destroy();
+            return;
+        }
+
+        _ = Create(localUser, creationSlot);
+    }
+
     private ReferenceReplacementDialog(User owner, Slot dialogSlot)
     {
-        _owner = owner ?? throw new ArgumentNullException(nameof(owner));
+        ArgumentNullException.ThrowIfNull(owner);
         _rootSlot = dialogSlot ?? throw new ArgumentNullException(nameof(dialogSlot));
         _rootSlot.Destroyed += OnSlotDestroyed;
         ClearSlot(_rootSlot);
 
         (_processRootRef, _sourceRef, _targetRef) = CreateReferenceFields();
-        ClearInputs();
 
         ConfigureRootSlot();
         BuildUI();
@@ -63,7 +75,7 @@ public void RepositionFor(User? user)
             return;
         }
 
-        PrepareRootSlot(user);
+        ResetRootTransform();
         _rootSlot.PositionInFrontOfUser(float3.Backward);
         if (user.LocalUserRoot != null)
         {
@@ -86,8 +98,6 @@ public void Close()
         {
             _rootSlot.Destroy();
         }
-
-        ReferenceReplacementDialogManager.Unregister(this);
     }
 
     private (ISyncRef processRoot, ISyncRef source, ISyncRef target) CreateReferenceFields()
@@ -97,7 +107,7 @@ public void Close()
 
     private ISyncRef CreateReferenceProxy()
     {
-        var proxy = _rootSlot.AttachComponent<ReferenceProxy>();
+        ReferenceProxy proxy = _rootSlot.AttachComponent<ReferenceProxy>();
         proxy.Persistent = false;
         return ExtractSyncRef(proxy);
     }
@@ -123,7 +133,6 @@ private void OnSlotDestroyed(IDestroyable _)
         }
 
         _disposed = true;
-        ReferenceReplacementDialogManager.Unregister(this);
     }
 
     private void ConfigureRootSlot()
@@ -358,21 +367,8 @@ private static void ClearSlot(Slot slot)
         }
     }
 
-    private void ClearInputs()
-    {
-        _processRootRef.Target = null!;
-        _sourceRef.Target = null!;
-        _targetRef.Target = null!;
-    }
-
-    private void PrepareRootSlot(User owner)
+    private void ResetRootTransform()
     {
-        Slot? parent = owner.LocalUserSpace;
-        if (parent != null && _rootSlot.Parent != parent)
-        {
-            _rootSlot.SetParent(parent, false);
-        }
-
         _rootSlot.LocalPosition = float3.Zero;
         _rootSlot.LocalRotation = floatQ.Identity;
     }