Skip to content

Review ansible rules: dependabot not supported, verify pre-commit linting setup #151

Description

@markcallen

Summary

The current ansible agent rules need to be reviewed for two issues:

1. Dependabot does not support Ansible

The cicd agent rules instruct agents to create a .github/dependabot.yml with package-ecosystem: 'npm' and github-actions entries. However, when those rules are applied to an ansible project, agents may incorrectly add a dependabot config — Dependabot has no supported package ecosystem for Ansible (ansible-galaxy, requirements.yml, collections). Adding a dependabot entry for an unsupported ecosystem either does nothing or causes confusing noise.

Action needed:

  • The ansible/ansible-linting.md and ansible/ansible-cicd.md rules (if they exist, or the shared cicd rules when applied to ansible) should explicitly state that Dependabot does not support Ansible and should not be configured for it.
  • The shared common/cicd.md rules should either note the ansible exception or the ansible-specific rules should override/suppress the dependabot section.

2. Verify pre-commit linting and git-hooks setup for Ansible

The ansible/ansible-git-hooks.md rules specify pre-commit as the hook tool, and ansible/ansible-linting.md documents ansible-lint and yamllint as the baseline tools. This is the correct approach for Ansible. However, the rules should be audited to confirm:

  • ansible-linting.md explicitly recommends pre-commit for local hook enforcement (coordinate with git-hooks rules)
  • ansible-git-hooks.md configures .pre-commit-config.yaml with the correct hooks: ansible-lint, yamllint, and ansible-playbook --syntax-check
  • The pre-push stage runs the ansible test/validation commands (not just commit-time lint)
  • The pre-commit autoupdate workflow is documented
  • There is no reference to Husky or lint-staged (those are TypeScript-specific and should not appear in ansible rules)

References

  • ansible/ansible-linting.md — baseline tooling: ansible-lint, yamllint
  • ansible/ansible-git-hooks.md — hook strategy: pre-commit
  • common/cicd.md — Dependabot configuration (npm + github-actions; does not mention ansible exception)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions