Skip to content

Commit fcecb3f

Browse files
author
sshevchenko
committed
Fix Codacy warnings.
1 parent 72e487d commit fcecb3f

2 files changed

Lines changed: 9 additions & 14 deletions

File tree

sequentially-ce/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyF.scala

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,20 +67,15 @@ object SequentiallyF {
6767
/** Create a SequentiallyF instance with custom semaphores and dispatcher.
6868
* Useful for testing.
6969
*/
70-
def resource[F[_], K](
70+
def resource[F[_] : Async, K](
7171
semaphores: Vector[Semaphore[F]]
72-
)(implicit
73-
F: Async[F]
7472
): Resource[F, SequentiallyF[F, K]] =
7573
Resource.pure(new SequentiallyF[F, K](semaphores))
7674

7775
/** Create a SequentiallyF instance with default configuration.
7876
* Bucket count = (availableProcessors max 1) * 5
7977
*/
80-
def resource[F[_], K](
81-
implicit
82-
F: Async[F]
83-
): Resource[F, SequentiallyF[F, K]] = {
78+
def resource[F[_] : Async, K](): Resource[F, SequentiallyF[F, K]] = {
8479
val bucketCount = (Runtime.getRuntime.availableProcessors() max 1) * 5
8580

8681
for {

sequentially-ce/src/test/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyCatsSpec.scala

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class SequentiallyFSpec extends AnyWordSpec with Matchers with ScalaFutures with
3131
"SequentiallyF" should {
3232

3333
"execute tasks in parallel for different keys without Thread.sleep" in {
34-
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int].allocated.unsafeRunSync()
34+
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int]().allocated.unsafeRunSync()
3535

3636
try {
3737
val startBarrier = new CyclicBarrier(3)
@@ -84,7 +84,7 @@ class SequentiallyFSpec extends AnyWordSpec with Matchers with ScalaFutures with
8484
}
8585

8686
"execute tasks sequentially for the same key" in {
87-
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int].allocated.unsafeRunSync()
87+
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int]().allocated.unsafeRunSync()
8888

8989
try {
9090
val executionOrder = new AtomicInteger(0)
@@ -127,7 +127,7 @@ class SequentiallyFSpec extends AnyWordSpec with Matchers with ScalaFutures with
127127
}
128128

129129
"handle exceptions without breaking sequential execution" in {
130-
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int].allocated.unsafeRunSync()
130+
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int]().allocated.unsafeRunSync()
131131

132132
try {
133133
val executionOrder = new AtomicInteger(0)
@@ -217,7 +217,7 @@ class SequentiallyFSpec extends AnyWordSpec with Matchers with ScalaFutures with
217217
}
218218

219219
"execute F-based tasks correctly with applyF" in {
220-
val (seq, cleanup) = SequentiallyF.resource[IO, Int].allocated.unsafeRunSync()
220+
val (seq, cleanup) = SequentiallyF.resource[IO, Int]().allocated.unsafeRunSync()
221221
val sequentially = seq.asInstanceOf[SequentiallyF[IO, Int]]
222222

223223
try {
@@ -253,7 +253,7 @@ class SequentiallyFSpec extends AnyWordSpec with Matchers with ScalaFutures with
253253
}
254254

255255
"handle F[_] exceptions in applyF without breaking sequential execution" in {
256-
val (seq, cleanup) = SequentiallyF.resource[IO, Int].allocated.unsafeRunSync()
256+
val (seq, cleanup) = SequentiallyF.resource[IO, Int]().allocated.unsafeRunSync()
257257
val sequentially = seq.asInstanceOf[SequentiallyF[IO, Int]]
258258

259259
try {
@@ -311,7 +311,7 @@ class SequentiallyFSpec extends AnyWordSpec with Matchers with ScalaFutures with
311311
}
312312

313313
"handle F[_] exceptions in parallel for different keys" in {
314-
val (seq, cleanup) = SequentiallyF.resource[IO, Int].allocated.unsafeRunSync()
314+
val (seq, cleanup) = SequentiallyF.resource[IO, Int]().allocated.unsafeRunSync()
315315
val sequentially = seq.asInstanceOf[SequentiallyF[IO, Int]]
316316

317317
try {
@@ -358,7 +358,7 @@ class SequentiallyFSpec extends AnyWordSpec with Matchers with ScalaFutures with
358358
}
359359

360360
"maintain correctness under concurrent stress" in {
361-
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int].allocated.unsafeRunSync()
361+
val (sequentially, cleanup) = SequentiallyF.resource[IO, Int]().allocated.unsafeRunSync()
362362

363363
try {
364364
val numKeys = 50

0 commit comments

Comments
 (0)