[bugfix] Return 404 for not found schema id

Author: marmoure

src/main/java/com/evolvedbinary/bblValidator/controller/SchemaController.java

@@ -41,7 +41,7 @@ public HttpResponse<Object> getSchema(@PathVariable("schema-id") final String sc
         final String schema = schemaService.getSchema(schemaId);
         if (schema == null) {
             return HttpResponse
-                    .badRequest()
+                    .notFound()
                     .contentType(MediaType.APPLICATION_JSON_TYPE)
                     .body(new ErrorResponse(ErrorResponse.Code.SCHEMA_NOT_FOUND,"Schema not found with ID: " + schemaId));
         }

src/test/java/com/evolvedbinary/bblValidator/controller/SchemaControllerTest.java

@@ -109,7 +109,7 @@ void getInvalidSchema() {
         final HttpClientResponseException exception = assertThrows(HttpClientResponseException.class, () -> client.toBlocking().exchange(request, String.class));
 
         // assert the response status
-        assertEquals(HttpStatus.BAD_REQUEST, exception.getStatus());
+        assertEquals(HttpStatus.NOT_FOUND, exception.getStatus());
 
         // assert the X-BBLVALIDATOR-VERSION is present and it's returning the expected value.
         assertEquals(version, exception.getResponse().getHeaders().get(BBLVALIDATOR_VERSION_HEADER));