[bugfix] minor bugfixes during review

Author: marmoure

pom.xml

@@ -100,6 +100,13 @@
     </dependencies>
 
     <build>
+        <resources>
+            <resource>
+                <directory>src/main/resources</directory>
+                <filtering>true</filtering>
+            </resource>
+        </resources>
+
         <plugins>
             <!-- Maven Compiler Plugin -->
             <plugin>

src/main/java/com/evolvedbinary/bblValidator/controller/SchemaController.java

@@ -7,17 +7,15 @@
 import io.micronaut.http.annotation.Get;
 import io.micronaut.http.annotation.Produces;
 import io.micronaut.http.annotation.PathVariable;
+import jakarta.inject.Inject;
 
 import java.util.List;
 
 @Controller("/schema")
 public class SchemaController {
 
-    private final SchemaService schemaService;
-
-    public SchemaController(SchemaService schemaService) {
-        this.schemaService = schemaService;
-    }
+    @Inject
+    SchemaService schemaService;
 
     @Get
     @Produces(MediaType.APPLICATION_JSON)

src/main/java/com/evolvedbinary/bblValidator/controller/ValidateController.java

@@ -9,6 +9,7 @@
 import io.micronaut.http.annotation.Controller;
 import io.micronaut.http.annotation.Post;
 import io.micronaut.http.annotation.QueryValue;
+import jakarta.inject.Inject;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -22,16 +23,8 @@
 public class ValidateController {
 
     private static final Logger LOG = LoggerFactory.getLogger(ValidateController.class);
-    private final FileDownloadService fileDownloadService;
-
-    /**
-     * Constructor for ValidateController.
-     *
-     * @param fileDownloadService service for downloading files
-     */
-    public ValidateController(FileDownloadService fileDownloadService) {
-        this.fileDownloadService = fileDownloadService;
-    }
+    @Inject
+    FileDownloadService fileDownloadService;
 
     /**
      * Handles form URL encoded validation requests.

src/main/java/com/evolvedbinary/bblValidator/controller/VersionController.java

@@ -10,11 +10,8 @@
 @Controller
 public class VersionController {
 
-    private final String version;
-
-    public VersionController(@Value("${api.version}") String version) {
-        this.version = version;
-    }
+    @Value("${api.version}")
+    String version;
 
     @Get("/version")
     @Produces(MediaType.APPLICATION_JSON)

src/main/java/com/evolvedbinary/bblValidator/dto/ValidationResponse.java

@@ -48,7 +48,7 @@ public String getSource() {
         return source;
     }
 
-    public void setSource(String url) {
+    public void setSource(String source) {
         this.source = source;
     }
 }

src/main/java/com/evolvedbinary/bblValidator/service/SchemaService.java

@@ -19,6 +19,7 @@
 import java.util.Map;
 import java.util.stream.Stream;
 
+// TODO talk to Adam about syncronaztion
 @Singleton
 public class SchemaService {
 
@@ -53,6 +54,12 @@ public void loadSchemas() {
     }
 
     private void loadSchemasFromClasspath() {
+        // close the file input stream
+        // try with resoucres
+        // avoid class path
+        // in application yaml add a property for schema folder
+        // make it relative to the start up location
+        // if it starts with a slash then resolve it as absolut path
         try {
             // Get resource URL and list files
             ClassLoader classLoader = getClass().getClassLoader();

src/main/resources/application.yml

@@ -4,4 +4,4 @@ micronaut:
   server:
     port: 8080
 api:
-  version: 1.0.0
+  version: ${project.version}