Move prepared_iter size assertion after cleanup (facebook#14144)

jaykorean · meta-codesync[bot] · commit 2f583aed8f66 · 2025-11-21T13:30:31.000-08:00
Summary: Fixing crash test failure caused by `prepared_iters_.size() == 0` Pull Request resolved: facebook#14144 Test Plan: ``` python3 -u tools/db_crashtest.py --stress_cmd=./db_stress --cleanup_cmd='' --simple blackbox ``` Reviewed By: krhancoc Differential Revision: D87656914 Pulled By: jaykorean fbshipit-source-id: 9ef7cf4ea5d34fe9dee6219b32323e91a2ea3e5f
diff --git a/db/version_set.cc b/db/version_set.cc
@@ -1020,11 +1020,11 @@ class LevelIterator final : public InternalIterator {
   ~LevelIterator() override {
     delete file_iter_.Set(nullptr);
     // Clean up any prepared iterators that weren't used
-    assert(prepared_iters_.size() == 0);
     for (auto& entry : prepared_iters_) {
       delete entry.second;
     }
     prepared_iters_.clear();
+    assert(prepared_iters_.size() == 0);
   }
 
   // Seek to the first file with a key >= target.

Original file line number	Diff line number	Diff line change
`@@ -1020,11 +1020,11 @@ class LevelIterator final : public InternalIterator {`
`1020`	`1020`	`~LevelIterator() override {`
`1021`	`1021`	`delete file_iter_.Set(nullptr);`
`1022`	`1022`	`// Clean up any prepared iterators that weren't used`
`1023`		`- assert(prepared_iters_.size() == 0);`
`1024`	`1023`	`for (auto& entry : prepared_iters_) {`
`1025`	`1024`	`delete entry.second;`
`1026`	`1025`	`}`
`1027`	`1026`	`prepared_iters_.clear();`
	`1027`	`+ assert(prepared_iters_.size() == 0);`
`1028`	`1028`	`}`
`1029`	`1029`
`1030`	`1030`	`// Seek to the first file with a key >= target.`