Linter

Author: alpe

block/components.go

@@ -114,7 +114,7 @@ func (bc *Components) Stop() error {
 		}
 	}
 	if bc.Syncer != nil {
-		if err := bc.Syncer.Stop(); err != nil {
+		if err := bc.Syncer.Stop(context.Background()); err != nil {
 			errs = errors.Join(errs, fmt.Errorf("failed to stop syncer: %w", err))
 		}
 	}

block/internal/syncing/syncer.go

@@ -165,9 +165,9 @@ func (s *Syncer) Start(ctx context.Context) (err error) {
 	ctx, cancel := context.WithCancel(ctx)
 	s.ctx, s.cancel = ctx, cancel
 
-	defer func() {
+	defer func() { //nolint: contextcheck // use new context as parent can be cancelled already
 		if err != nil {
-			_ = s.Stop()
+			_ = s.Stop(context.Background())
 		}
 	}()
 
@@ -226,7 +226,7 @@ func (s *Syncer) Start(ctx context.Context) (err error) {
 }
 
 // Stop shuts down the syncing component
-func (s *Syncer) Stop() error {
+func (s *Syncer) Stop(ctx context.Context) error {
 	if s.cancel == nil {
 		return nil
 	}
@@ -244,7 +244,7 @@ func (s *Syncer) Stop() error {
 	// Skip draining if we're shutting down due to a critical error (e.g. execution
 	// client unavailable).
 	if !s.hasCriticalError.Load() {
-		drainCtx, drainCancel := context.WithTimeout(context.Background(), 5*time.Second)
+		drainCtx, drainCancel := context.WithTimeout(ctx, 5*time.Second)
 		defer drainCancel()
 
 		drained := 0

block/internal/syncing/syncer_test.go

@@ -1156,7 +1156,7 @@ func TestSyncer_Stop_SkipsDrainOnCriticalError(t *testing.T) {
 	// Stop must complete quickly — no drain, no ExecuteTxs calls
 	done := make(chan struct{})
 	go func() {
-		_ = s.Stop()
+		_ = s.Stop(t.Context())
 		close(done)
 	}()
 
@@ -1225,7 +1225,7 @@ func TestSyncer_Stop_DrainWorksWithoutCriticalError(t *testing.T) {
 		// hasCriticalError is false (default) — drain should process events including ExecuteTxs
 		s.wg.Go(func() {})
 
-		_ = s.Stop()
+		_ = s.Stop(t.Context())
 
 		// Verify ExecuteTxs was actually called during drain
 		mockExec.AssertExpectations(t)

node/failover.go

@@ -255,7 +255,7 @@ func (f *failoverState) runCatchupPhase(ctx context.Context) error {
 	if err := f.bc.Syncer.Start(ctx); err != nil {
 		return fmt.Errorf("catchup syncer start: %w", err)
 	}
-	defer f.bc.Syncer.Stop() // nolint:errcheck // not critical
+	defer f.bc.Syncer.Stop(context.Background()) // nolint:errcheck,contextcheck // not critical
 
 	caughtUp, err := f.waitForCatchup(ctx)
 	if err != nil {