chore: remove span assertions

Author: chatton

test/e2e/benchmark/spamoor_erc20_test.go

@@ -100,20 +100,6 @@ func (s *SpamoorSuite) TestERC20Throughput() {
 	w.addEntries(summary.entries("ERC20Throughput"))
 	w.addSpans(traces.allSpans())
 
-	// assertions
 	s.Require().Greater(sent, float64(0), "at least one transaction should have been sent")
 	s.Require().Zero(failed, "no transactions should have failed")
-
-	// assert expected ev-node spans are present
-	assertSpanNames(t, traces.evNode, []string{
-		"BlockExecutor.ProduceBlock",
-		"BlockExecutor.ApplyBlock",
-		"Executor.ExecuteTxs",
-		"Executor.SetFinal",
-		"Engine.ForkchoiceUpdated",
-		"Engine.NewPayload",
-		"Engine.GetPayload",
-		"Sequencer.GetNextBatch",
-		"DA.Submit",
-	}, serviceName)
 }

test/e2e/benchmark/spamoor_smoke_test.go

@@ -79,34 +79,6 @@ func (s *SpamoorSuite) TestSpamoorSmoke() {
 	traces := s.collectTraces(e, "ev-node-smoke")
 	w.addSpans(traces.allSpans())
 
-	// assert expected ev-node span names
-	assertSpanNames(t, traces.evNode, []string{
-		"BlockExecutor.ProduceBlock",
-		"BlockExecutor.ApplyBlock",
-		"BlockExecutor.CreateBlock",
-		"BlockExecutor.RetrieveBatch",
-		"Executor.ExecuteTxs",
-		"Executor.SetFinal",
-		"Engine.ForkchoiceUpdated",
-		"Engine.NewPayload",
-		"Engine.GetPayload",
-		"Eth.GetBlockByNumber",
-		"Sequencer.GetNextBatch",
-		"DASubmitter.SubmitHeaders",
-		"DASubmitter.SubmitData",
-		"DA.Submit",
-	}, "ev-node-smoke")
-
-	// assert expected ev-reth span names when traces are available
-	if len(traces.evReth) > 0 {
-		assertSpanNames(t, traces.evReth, []string{
-			"build_payload",
-			"execute_tx",
-			"try_build",
-			"validate_transaction",
-		}, "ev-reth")
-	}
-
 	s.Require().Greater(sent, float64(0), "at least one transaction should have been sent")
 	s.Require().Zero(fail, "no transactions should have failed")
 }

test/e2e/benchmark/traces.go

@@ -3,11 +3,9 @@
 package benchmark
 
 import (
-	"testing"
 	"time"
 
 	e2e "github.com/evstack/ev-node/test/e2e"
-	"github.com/stretchr/testify/require"
 )
 
 // jaegerSpan holds the fields we extract from Jaeger's untyped JSON response.
@@ -16,7 +14,7 @@ type jaegerSpan struct {
 	duration      float64 // microseconds
 }
 
-func (j jaegerSpan) SpanName() string           { return j.operationName }
+func (j jaegerSpan) SpanName() string            { return j.operationName }
 func (j jaegerSpan) SpanDuration() time.Duration { return time.Duration(j.duration) * time.Microsecond }
 
 // extractSpansFromTraces walks Jaeger's []any response and pulls out span operation names and durations.
@@ -53,15 +51,3 @@ func toTraceSpans(spans []jaegerSpan) []e2e.TraceSpan {
 	}
 	return out
 }
-
-// assertSpanNames verifies that all expected span names appear in the trace data.
-func assertSpanNames(t testing.TB, spans []e2e.TraceSpan, expected []string, label string) {
-	t.Helper()
-	opNames := make(map[string]struct{}, len(spans))
-	for _, span := range spans {
-		opNames[span.SpanName()] = struct{}{}
-	}
-	for _, name := range expected {
-		require.Contains(t, opNames, name, "expected span %q not found in %s traces", name, label)
-	}
-}