fix: defer emitRunResult so results are written even on test failure

Move emitRunResult into a deferred closure in all three test functions.
If the test fails after metrics are collected, the structured JSON is
still written. If it fails before result data exists, the defer is a
no-op.

Author: chatton

test/e2e/benchmark/gasburner_test.go

@@ -23,6 +23,15 @@ func (s *SpamoorSuite) TestGasBurner() {
 
 	cfg.log(t)
 
+	var result *benchmarkResult
+	var wallClock time.Duration
+	var spamoorStats *runSpamoorStats
+	defer func() {
+		if result != nil {
+			emitRunResult(t, cfg, result, wallClock, spamoorStats)
+		}
+	}()
+
 	e := s.setupEnv(cfg)
 	api := e.spamoorAPI
 
@@ -83,7 +92,7 @@ func (s *SpamoorSuite) TestGasBurner() {
 	if err := waitForDrain(drainCtx, t.Logf, e.ethClient, 10); err != nil {
 		t.Logf("warning: %v", err)
 	}
-	wallClock := time.Since(loadStart)
+	wallClock = time.Since(loadStart)
 
 	endHeader, err := e.ethClient.HeaderByNumber(ctx, nil)
 	s.Require().NoError(err, "failed to get end block header")
@@ -96,7 +105,7 @@ func (s *SpamoorSuite) TestGasBurner() {
 
 	traces := s.collectTraces(e, cfg.ServiceName)
 
-	result := newBenchmarkResult("GasBurner", bm, traces)
+	result = newBenchmarkResult("GasBurner", bm, traces)
 	s.Require().Greater(result.summary.SteadyState, time.Duration(0), "expected non-zero steady-state duration")
 	result.log(t, wallClock)
 	w.addEntries(result.entries())
@@ -105,6 +114,5 @@ func (s *SpamoorSuite) TestGasBurner() {
 	s.Require().NoError(mErr, "failed to get final metrics")
 	sent := sumCounter(metrics["spamoor_transactions_sent_total"])
 	failed := sumCounter(metrics["spamoor_transactions_failed_total"])
-
-	emitRunResult(t, cfg, result, wallClock, &runSpamoorStats{Sent: sent, Failed: failed})
+	spamoorStats = &runSpamoorStats{Sent: sent, Failed: failed}
 }

test/e2e/benchmark/spamoor_defi_test.go

@@ -29,6 +29,15 @@ func (s *SpamoorSuite) TestDeFiSimulation() {
 	w := newResultWriter(t, "DeFiSimulation")
 	defer w.flush()
 
+	var result *benchmarkResult
+	var wallClock time.Duration
+	var spamoorStats *runSpamoorStats
+	defer func() {
+		if result != nil {
+			emitRunResult(t, cfg, result, wallClock, spamoorStats)
+		}
+	}()
+
 	e := s.setupEnv(cfg)
 
 	uniswapConfig := map[string]any{
@@ -93,7 +102,7 @@ func (s *SpamoorSuite) TestDeFiSimulation() {
 	if err := waitForDrain(drainCtx, t.Logf, e.ethClient, 10); err != nil {
 		t.Logf("warning: %v", err)
 	}
-	wallClock := time.Since(loadStart)
+	wallClock = time.Since(loadStart)
 
 	endHeader, err := e.ethClient.HeaderByNumber(ctx, nil)
 	s.Require().NoError(err, "failed to get end block header")
@@ -106,7 +115,7 @@ func (s *SpamoorSuite) TestDeFiSimulation() {
 
 	traces := s.collectTraces(e, cfg.ServiceName)
 
-	result := newBenchmarkResult("DeFiSimulation", bm, traces)
+	result = newBenchmarkResult("DeFiSimulation", bm, traces)
 	s.Require().Greater(result.summary.SteadyState, time.Duration(0), "expected non-zero steady-state duration")
 	result.log(t, wallClock)
 	w.addEntries(result.entries())
@@ -115,6 +124,5 @@ func (s *SpamoorSuite) TestDeFiSimulation() {
 	s.Require().NoError(mErr, "failed to get final metrics")
 	sent := sumCounter(metrics["spamoor_transactions_sent_total"])
 	failed := sumCounter(metrics["spamoor_transactions_failed_total"])
-
-	emitRunResult(t, cfg, result, wallClock, &runSpamoorStats{Sent: sent, Failed: failed})
+	spamoorStats = &runSpamoorStats{Sent: sent, Failed: failed}
 }

test/e2e/benchmark/spamoor_erc20_test.go

@@ -23,6 +23,15 @@ func (s *SpamoorSuite) TestERC20Throughput() {
 	w := newResultWriter(t, "ERC20Throughput")
 	defer w.flush()
 
+	var result *benchmarkResult
+	var wallClock time.Duration
+	var spamoorStats *runSpamoorStats
+	defer func() {
+		if result != nil {
+			emitRunResult(t, cfg, result, wallClock, spamoorStats)
+		}
+	}()
+
 	e := s.setupEnv(cfg)
 
 	erc20Config := map[string]any{
@@ -68,7 +77,7 @@ func (s *SpamoorSuite) TestERC20Throughput() {
 	if err := waitForDrain(drainCtx, t.Logf, e.ethClient, 10); err != nil {
 		t.Logf("warning: %v", err)
 	}
-	wallClock := time.Since(loadStart)
+	wallClock = time.Since(loadStart)
 
 	endHeader, err := e.ethClient.HeaderByNumber(ctx, nil)
 	s.Require().NoError(err, "failed to get end block header")
@@ -80,13 +89,13 @@ func (s *SpamoorSuite) TestERC20Throughput() {
 
 	traces := s.collectTraces(e, cfg.ServiceName)
 
-	result := newBenchmarkResult("ERC20Throughput", bm, traces)
+	result = newBenchmarkResult("ERC20Throughput", bm, traces)
 	s.Require().Greater(result.summary.SteadyState, time.Duration(0), "expected non-zero steady-state duration")
 	result.log(t, wallClock)
 	w.addEntries(result.entries())
 
+	spamoorStats = &runSpamoorStats{Sent: sent, Failed: failed}
+
 	s.Require().Greater(sent, float64(0), "at least one transaction should have been sent")
 	s.Require().Zero(failed, "no transactions should have failed")
-
-	emitRunResult(t, cfg, result, wallClock, &runSpamoorStats{Sent: sent, Failed: failed})
 }