Fix CI: register GitHubActionsTestLogger MTP extension and address PR feedback

- Explicitly register GitHubActionsTestLogger as a TestingPlatformBuilderHook
  to fix --report-github Unknown option error in CI (the packages build
  props do not flow correctly with single TargetFramework projects)
- Remove redundant RegexOptions.Compiled from all [GeneratedRegex] attributes
  (source generator already compiles at build time)
- Use pattern matching null checks (is null) instead of == null
- Wrap List<T> assignments with .AsReadOnly() for true immutability on
  IReadOnlyList<T> properties in ComparisonFormatParser and TwoPartFormatParser

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: niemyjski

src/Exceptionless.DateTimeExtensions/DateMath.cs

@@ -27,17 +27,16 @@ public static partial class DateMath
     // https://www.elastic.co/docs/reference/elasticsearch/rest-apis/common-options
     [GeneratedRegex(
         @"\G(?<anchor>now|(?<date>\d{4}-?\d{2}-?\d{2}(?:[T\s](?:\d{1,2}(?::?\d{2}(?::?\d{2})?)?(?:\.\d{1,3})?)?(?:[+-]\d{2}:?\d{2}|Z)?)?)\|\|)" +
-        @"(?<operations>(?:(?:[+\-]|\\?/)\d*[yMwdhHms])*)(?=\s|$|[\]\}])",
-        RegexOptions.Compiled)]
+        @"(?<operations>(?:(?:[+\-]|\\?/)\d*[yMwdhHms])*)(?=\s|$|[\]\}])")]
     internal static partial Regex ParserRegex();
 
     // Pre-compiled regex for operation parsing to avoid repeated compilation
     // Supports both / and \/ (escaped forward slash) for rounding operations
-    [GeneratedRegex(@"([+\-]|\\?/)(\d*)([yMwdhHms])", RegexOptions.Compiled)]
+    [GeneratedRegex(@"([+\-]|\\?/)(\d*)([yMwdhHms])")]
     private static partial Regex OperationRegex();
 
     // Pre-compiled regex for offset parsing to avoid repeated compilation
-    [GeneratedRegex(@"(Z|[+-]\d{2}:\d{2})$", RegexOptions.Compiled)]
+    [GeneratedRegex(@"(Z|[+-]\d{2}:\d{2})$")]
     private static partial Regex OffsetRegex();
 
     /// <summary>

src/Exceptionless.DateTimeExtensions/FormatParsers/FormatParsers/ComparisonFormatParser.cs

@@ -23,12 +23,12 @@ namespace Exceptionless.DateTimeExtensions.FormatParsers;
 [Priority(24)]
 public partial class ComparisonFormatParser : IFormatParser
 {
-    [GeneratedRegex(@"^\s*(>=?|<=?)\s*", RegexOptions.Compiled)]
+    [GeneratedRegex(@"^\s*(>=?|<=?)\s*")]
     private static partial Regex OperatorRegex();
 
     public ComparisonFormatParser()
     {
-        Parsers = new List<IPartParser>(DateTimeRange.PartParsers);
+        Parsers = new List<IPartParser>(DateTimeRange.PartParsers).AsReadOnly();
     }
 
     public IReadOnlyList<IPartParser> Parsers { get; private set; }
@@ -66,14 +66,14 @@ public ComparisonFormatParser()
                 continue;
 
             value = parser.Parse(match, relativeBaseTime, isUpperLimit);
-            if (value == null)
+            if (value is null)
                 continue;
 
             index += match.Length;
             break;
         }
 
-        if (value == null)
+        if (value is null)
             return null;
 
         // Verify entire input was consumed (only trailing whitespace allowed)

src/Exceptionless.DateTimeExtensions/FormatParsers/FormatParsers/TwoPartFormatParser.cs

@@ -17,15 +17,15 @@ public partial class TwoPartFormatParser : IFormatParser
 
     public TwoPartFormatParser()
     {
-        Parsers = new List<IPartParser>(DateTimeRange.PartParsers);
+        Parsers = new List<IPartParser>(DateTimeRange.PartParsers).AsReadOnly();
     }
 
     public TwoPartFormatParser(IEnumerable<IPartParser> parsers, bool includeDefaults = false)
     {
         var list = new List<IPartParser>(parsers);
         if (includeDefaults)
             list.AddRange(DateTimeRange.PartParsers);
-        Parsers = list;
+        Parsers = list.AsReadOnly();
     }
 
     public IReadOnlyList<IPartParser> Parsers { get; private set; }
@@ -81,7 +81,7 @@ public TwoPartFormatParser(IEnumerable<IPartParser> parsers, bool includeDefault
             // For non-wildcard parsers, bracket inclusivity determines rounding direction.
             bool isUpperLimit = parser is not WildcardPartParser && !minInclusive;
             start = parser.Parse(match, relativeBaseTime, isUpperLimit);
-            if (start == null)
+            if (start is null)
                 continue;
 
             index += match.Length;
@@ -103,7 +103,7 @@ public TwoPartFormatParser(IEnumerable<IPartParser> parsers, bool includeDefault
 
             bool isUpperLimit = parser is WildcardPartParser || maxInclusive;
             end = parser.Parse(match, relativeBaseTime, isUpperLimit);
-            if (end == null)
+            if (end is null)
                 continue;
 
             index += match.Length;
@@ -132,10 +132,10 @@ public TwoPartFormatParser(IEnumerable<IPartParser> parsers, bool includeDefault
     /// </summary>
     private static bool IsValidBracketPair(char? opening, char? closing)
     {
-        if (opening == null && closing == null)
+        if (opening is null && closing is null)
             return true;
 
-        if (opening == null || closing == null)
+        if (opening is null || closing is null)
             return false;
 
         bool validOpening = opening is '[' or '{';

tests/Exceptionless.DateTimeExtensions.Tests/Exceptionless.DateTimeExtensions.Tests.csproj

@@ -1,20 +1,18 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <Import Project="..\..\build\common.props" />
   <PropertyGroup>
-    <TargetFramework>net10.0</TargetFramework>
+    <TargetFrameworks>net10.0</TargetFrameworks>
     <OutputType>Exe</OutputType>
     <IsPackable>False</IsPackable>
-    <TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
-    <GenerateProgramFile>false</GenerateProgramFile>
-    <NoWarn>$(NoWarn);CS8625;CS8892</NoWarn>
+    <NoWarn>$(NoWarn);CS8625</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\src\Exceptionless.DateTimeExtensions\Exceptionless.DateTimeExtensions.csproj" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
     <PackageReference Include="xunit.v3.mtp-v2" Version="3.2.2" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" PrivateAssets="All" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />
     <PackageReference Include="Foundatio.Xunit.v3" Version="13.0.0-beta1" />
     <PackageReference Include="GitHubActionsTestLogger" Version="3.0.1" PrivateAssets="All" />
   </ItemGroup>