Fix bank account ineffective concurrency test

tobias-haenel · tobias-haenel · commit 3d5e6d2566c4 · 2026-03-30T18:27:50.000+02:00
diff --git a/exercises/practice/bank-account/.meta/Generator.tpl b/exercises/practice/bank-account/.meta/Generator.tpl
@@ -33,9 +33,9 @@ public class {{ testClass }}
                     Assert.Equal({{ test.expected }}m, account.{{ op | to_call }});
                 {{ end -}}
             {{- else if op.operation == "concurrent" }}
+            var tasks = new List<Task>();
             for (int i = 0; i < 500; i++)
             {
-                var tasks = new List<Task>();
                 tasks.Add(Task.Factory.StartNew(() =>
                 {
                     for (int j = 0; j < 100; j++)
@@ -45,8 +45,8 @@ public class {{ testClass }}
                         {{- end -}}
                     }
                 }));
-                await Task.WhenAll(tasks.ToArray());
             }
+            await Task.WhenAll(tasks.ToArray());
             {{- else }}
             account.{{ op | to_call }};
             {{- end -}}

Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,9 @@ public class {{ testClass }}`
`33`	`33`	`Assert.Equal({{ test.expected }}m, account.{{ op \| to_call }});`
`34`	`34`	`{{ end -}}`
`35`	`35`	`{{- else if op.operation == "concurrent" }}`
	`36`	`+ var tasks = new List<Task>();`
`36`	`37`	`for (int i = 0; i < 500; i++)`
`37`	`38`	`{`
`38`		`- var tasks = new List<Task>();`
`39`	`39`	`tasks.Add(Task.Factory.StartNew(() =>`
`40`	`40`	`{`
`41`	`41`	`for (int j = 0; j < 100; j++)`
`@@ -45,8 +45,8 @@ public class {{ testClass }}`
`45`	`45`	`{{- end -}}`
`46`	`46`	`}`
`47`	`47`	`}));`
`48`		`- await Task.WhenAll(tasks.ToArray());`
`49`	`48`	`}`
	`49`	`+ await Task.WhenAll(tasks.ToArray());`
`50`	`50`	`{{- else }}`
`51`	`51`	`account.{{ op \| to_call }};`
`52`	`52`	`{{- end -}}`