remove some smarty warnings

Author: dleffler

framework/modules/navigation/models/section.php

@@ -424,6 +424,7 @@ public static function navhierarchy($notyui=false) {
                 $obj->text = $sections[$i]->name;
                 $obj->title = $sections[$i]->page_title;
                 $obj->description = $sections[$i]->description;
+//                $obj->depth = 0;
                 $obj->new_window = $sections[$i]->new_window;
                 $obj->expFile = $sections[$i]->expFile;
                 $obj->glyph = $sections[$i]->glyph;

framework/plugins/bootstrap4/function.bootstrap_navbar.php

@@ -88,7 +88,7 @@ function build_menu($page, $params) {
             $menu .= ' class="nav-item disabled';
         else
             $menu .= ' class="nav-item';
-        if ($page->depth)
+        if (!empty($page->depth))
             $menu .= '"><a class="dropdown-item' . $active . '" href="'.$page->url.'"'.($page->new_window?' target="_blank"':'') . ' title="'. $page->title .'">' . $menu_item . '</a></li>'."\n";
         else
             $menu .= '"><a class="nav-link" href="'.$page->url.'"'.($page->new_window?' target="_blank"':'') . ' title="'. $page->title .'">' . $menu_item . '</a></li>'."\n";
@@ -102,12 +102,12 @@ function build_menu($page, $params) {
             $active = " nav-item active";
             $menu .= ' active';
         }
-        if ($page->depth)
+        if (!empty($page->depth))
             $menu .= '"><a href="'.$page->url.'" data-target="dropdownMenu' . $page->id . '" class="dropdown-item dropdown-toggle' . $active . '" href="'.$page->url.'" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"'.($page->new_window?' target="_blank"':'').' title="'. $page->title .'">' . $menu_item;
-        else
-            $menu .= '"><a href="'.$page->url.'" data-target="dropdownMenu' . $page->id . '" class="nav-link dropdown-toggle" href="'.$page->url.'" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"'.($page->new_window?' target="_blank"':'').' title="'. $page->title .'">' . $menu_item;
-        if (empty($page->depth))
+        else {
+            $menu .= '"><a href="' . $page->url . '" data-target="dropdownMenu' . $page->id . '" class="nav-link dropdown-toggle" href="' . $page->url . '" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"' . ($page->new_window ? ' target="_blank"' : '') . ' title="' . $page->title . '">' . $menu_item;
             $menu .= '<b class="caret"></b>';
+        }
         $menu .= '</a>'."\n".'<ul class="dropdown-menu'.($params['menualign']==='right'?' float-right':'').'" role="menu" id="dropdownMenu' . $page->id . ' aria-labelledby="dropdownMenu' . $page->id . '">'."\n";
         if ($page->url !== "#") {  // we also need a 'menu item' for active parent pages
             $topmenu = new stdClass();

framework/plugins/bootstrap5/function.bootstrap_navbar.php

@@ -90,7 +90,7 @@ function build_menu($page, $params) {
             $menu .= ' class="nav-item disabled';
         else
             $menu .= ' class="nav-item';
-        if ($page->depth)
+        if (!empty($page->depth))
             $menu .= '"><a class="dropdown-item' . $active . '" href="'.$page->url.'"'.($page->new_window?' target="_blank"':'') . ' title="'. $page->title .'">' . $menu_item . '</a></li>'."\n";
         else
             $menu .= '"><a class="nav-link" href="'.$page->url.'"'.($page->new_window?' target="_blank"':'') . ' title="'. $page->title .'">' . $menu_item . '</a></li>'."\n";
@@ -104,12 +104,12 @@ function build_menu($page, $params) {
             $active = " nav-item active";
             $menu .= ' active';
         }
-        if ($page->depth)
+        if (!empty($page->depth))
             $menu .= '"><a href="'.$page->url.'" data-bs-target="dropdownMenu' . $page->id . '" class="dropdown-item dropdown-toggle' . $active . '" href="'.$page->url.'" data-bs-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"'.($page->new_window?' target="_blank"':'').' title="'. $page->title .'">' . $menu_item;
-        else
-            $menu .= '"><a href="'.$page->url.'" data-bs-target="dropdownMenu' . $page->id . '" class="nav-link dropdown-toggle" href="'.$page->url.'" data-bs-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"'.($page->new_window?' target="_blank"':'').' title="'. $page->title .'">' . $menu_item;
-        if (empty($page->depth))
+        else {
+            $menu .= '"><a href="' . $page->url . '" data-bs-target="dropdownMenu' . $page->id . '" class="nav-link dropdown-toggle" href="' . $page->url . '" data-bs-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"' . ($page->new_window ? ' target="_blank"' : '') . ' title="' . $page->title . '">' . $menu_item;
             $menu .= '<b class="caret"></b>';
+        }
         $menu .= '</a>'."\n".'<ul class="dropdown-menu'.($params['menualign']==='right'?' float-right':'').'" role="menu" id="dropdownMenu' . $page->id . ' aria-labelledby="dropdownMenu' . $page->id . '">'."\n";
         if ($page->url !== "#") {  // we also need a 'menu item' for active parent pages
             $topmenu = new stdClass();