Add back old .NET framework support

for DotVVM unit tests ;(

Author: exyi

exampleTest/CheckTestOutput.Example.csproj

@@ -1,7 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net6.0;net472</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">net6.0</TargetFrameworks>
+
 
     <IsPackable>false</IsPackable>
     <RollForward>major</RollForward>

src/CheckTestOutput.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net6.0;net7.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net7.0</TargetFrameworks>
     <LangVersion>9</LangVersion>
 
     <Description>Simple helper which checks that output of a test matches a file. If not matching, just git staging the new file will accept the new version.</Description>
@@ -16,7 +16,7 @@
 
     <AssemblyOriginatorKeyFile>dotvvmwizard.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
-    <PublicSign>true</PublicSign>
+    <!-- <PublicSign >true</PublicSign> -->
 
     <PackageReadmeFile>README.md</PackageReadmeFile>
 
@@ -30,6 +30,10 @@
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.1'">
     <PackageReference Include="System.Text.Json" Version="5.0.2" />
   </ItemGroup>
+  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
+    <PackageReference Include="System.Text.Json" Version="5.0.2" />
+    <PackageReference Include="MedallionShell.StrongName" Version="1.6.2" />
+  </ItemGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>

src/OutputChecker.cs

@@ -88,6 +88,7 @@ private Process StartGitProcess(params string[] args)
 #if DEBUG
             Console.WriteLine("Running git command: " + string.Join(" ", args));
 #endif
+#if NETSTANDARD2_1_OR_GREATER || NET6_0_OR_GREATER
             // run `git ...args` in CheckDirectory working directory with 3 second timeout
             var procInfo = new ProcessStartInfo("git")
             {
@@ -102,9 +103,12 @@ private Process StartGitProcess(params string[] args)
             };
             foreach (var a in args)
                 procInfo.ArgumentList.Add(a);
-
-
             return Process.Start(procInfo);
+#else
+            // Old frameworks don't support ArgumentList, so I rather pull in a dependency than write my own escaping
+            var command = Medallion.Shell.Shell.Default.Run("git", args, options => options.WorkingDirectory(CheckDirectory).Timeout(TimeSpan.FromSeconds(15)));
+            return command.Process;
+#endif
         }
 
         private void HandleProcessExit(Process proc, Task outputReaderTask, params string[] args)
@@ -145,21 +149,13 @@ private string[] RunGitCommand(params string[] args)
 
         private byte[] RunGitBinaryCommand(params string[] args)
         {
-            const int BUFFER_SIZE = 1024;
-
             var proc = StartGitProcess(args);
 
-            List<byte> ret = new();
+            MemoryStream ret = new();
 
             var outputReaderTask = Task.Run(() =>
             {
-                byte[] buffer = new byte[BUFFER_SIZE];
-
-                int charsRead = 0;
-                while ((charsRead = proc.StandardOutput.BaseStream.Read(buffer, 0, BUFFER_SIZE)) != 0)
-                {
-                    ret.AddRange(buffer.AsSpan(0, charsRead).ToArray());
-                }
+                proc.StandardOutput.BaseStream.CopyTo(ret);
             });
 
             HandleProcessExit(proc, outputReaderTask, args);
@@ -323,7 +319,7 @@ internal void CheckOutputBinaryCore(byte[] outputBytes, string checkName, string
                 {
                     using (var t = File.Create(filename))
                     {
-                        t.Write(outputBytes);
+                        t.Write(outputBytes, 0, outputBytes.Length);
                     }
                 }
                 return;
@@ -333,7 +329,7 @@ internal void CheckOutputBinaryCore(byte[] outputBytes, string checkName, string
             {
                 using (var t = File.Create(filename))
                 {
-                    t.Write(outputBytes);
+                    t.Write(outputBytes, 0, outputBytes.Length);
                 }
 
                 if (IsModified(filename))