Fix birthplace encoding/decoding when the municipality has been created after the birthdate. #210 #213

Author: fabiocaccamo

src/codicefiscale/codicefiscale.py

@@ -180,8 +180,9 @@ def _get_birthplace_fallback(
 ) -> dict[str, dict[str, Any]] | None:
     # avoid wrong birthplace code error when birthdate falls in
     # missing date-range in the data-source even if birthplace code is valid
-    if len(birthplaces_options) > 1:
-        for index in range(len(birthplaces_options) - 1):
+    birthplaces_options_count = len(birthplaces_options)
+    if birthplaces_options_count > 1:
+        for index in range(birthplaces_options_count - 1):
             birthplace_option = birthplaces_options[index]
             birthplace_option_next = birthplaces_options[(index + 1)]
             date_deleted = _get_date(birthplace_option["date_deleted"])
@@ -199,6 +200,16 @@ def _get_birthplace_fallback(
                             return birthplace_option.copy()
                     return birthplace_option_next.copy()
 
+    # Fix issues #210, #213
+    # sometimes the code has been assigned after date of birth and
+    # the municipality was not yet active at birthdate time,
+    # let's return the first municipality created after birthdate_date
+    for index in range(birthplaces_options_count):
+        birthplace_option = birthplaces_options[index]
+        date_created = _get_date(birthplace_option["date_created"])
+        if date_created:
+            if birthdate_date <= date_created:
+                return birthplace_option.copy()
     return None
 
 

tests/issues/test_issue_0210_0213.py

@@ -0,0 +1,83 @@
+import datetime
+
+from codicefiscale import codicefiscale
+
+
+def test_issue_0210():
+    """
+    Test for municipality activated after birthdate.
+    https://github.com/fabiocaccamo/python-codicefiscale/issues/210
+    """
+    code = "CCCFBA30H66F991T"
+    assert codicefiscale.is_valid(code)
+    code_data = codicefiscale.decode(code)
+    code_data.pop("omocodes")
+    expected_code_data = {
+        "code": "CCCFBA30H66F991T",
+        "gender": "F",
+        "birthdate": datetime.datetime(1930, 6, 26, 0, 0),
+        "birthplace": {
+            "active": False,
+            "code": "F991",
+            "date_created": "1958-01-26T00:00:00",
+            "date_deleted": "1965-01-07T00:00:00",
+            "name": "Nuxis",
+            "name_alt": "",
+            "name_alt_trans": "",
+            "name_slugs": ["nuxis"],
+            "name_trans": "Nuxis",
+            "province": "CA",
+        },
+        "raw": {
+            "code": "CCCFBA30H66F991T",
+            "lastname": "CCC",
+            "firstname": "FBA",
+            "birthdate": "30H66",
+            "birthdate_year": "30",
+            "birthdate_month": "H",
+            "birthdate_day": "66",
+            "birthplace": "F991",
+            "cin": "T",
+        },
+    }
+    assert code_data == expected_code_data
+
+
+def test_issue_0213():
+    """
+    Test for municipality activated after birthdate.
+    https://github.com/fabiocaccamo/python-codicefiscale/issues/213
+    """
+    code = "DBRGRZ53R66F059C"
+    assert codicefiscale.is_valid(code)
+    code_data = codicefiscale.decode(code)
+    code_data.pop("omocodes")
+    expected_code_data = {
+        "code": "DBRGRZ53R66F059C",
+        "gender": "F",
+        "birthdate": datetime.datetime(1953, 10, 26, 0, 0),
+        "birthplace": {
+            "active": True,
+            "code": "F059",
+            "date_created": "1955-08-19T00:00:00",
+            "date_deleted": "",
+            "name": "Mattinata",
+            "name_alt": "",
+            "name_alt_trans": "",
+            "name_slugs": ["mattinata"],
+            "name_trans": "Mattinata",
+            "province": "FG",
+        },
+        "raw": {
+            "code": "DBRGRZ53R66F059C",
+            "lastname": "DBR",
+            "firstname": "GRZ",
+            "birthdate": "53R66",
+            "birthdate_year": "53",
+            "birthdate_month": "R",
+            "birthdate_day": "66",
+            "birthplace": "F059",
+            "cin": "C",
+        },
+    }
+    assert code_data == expected_code_data

tests/test_encode.py

@@ -246,10 +246,10 @@ def test_encode_birthplace_invalid_arguments():
         codicefiscale.encode_birthplace("Area 51")
 
 
-def test_encode_birthplace_invalid_birthdate():
-    """Test invalid birthdate for encoding birthplaces."""
-    with pytest.raises(ValueError):
-        codicefiscale.encode_birthplace("Torino", "01/01/1888")
+def test_encode_birthplace_created_after_birthdate():
+    """Test encoding birthplace created after birthdate."""
+    result = codicefiscale.encode_birthplace("Torino", "01/01/1888")
+    assert result == "L219"
 
 
 def test_encode_cin(cin_test_cases):