Skip to content

Commit 34ff018

Browse files
rlyerlymeta-codesync[bot]
authored andcommitted
Minor cleanups in navy
Summary: - Use std::max instead of manually calculating max - Remove unused header - Fix bad grammar in comments Reviewed By: AlnisM Differential Revision: D97170969 fbshipit-source-id: cedd24ceaf675328f65547416ec303ad8359ea65
1 parent d8b4d95 commit 34ff018

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

cachelib/navy/driver/Driver.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#include "cachelib/navy/admission_policy/AdmissionPolicy.h"
2929
#include "cachelib/navy/common/Buffer.h"
3030
#include "cachelib/navy/common/Device.h"
31-
#include "cachelib/navy/engine/Engine.h"
3231
#include "cachelib/navy/engine/EnginePair.h"
3332
#include "cachelib/navy/scheduler/JobScheduler.h"
3433

@@ -126,10 +125,10 @@ class Driver final : public AbstractCache {
126125
// @param cb a callback function be triggered when the remove complete.
127126
void removeAsync(HashedKey key, RemoveCallback cb) override;
128127

129-
// ensure all pending job have been completed
128+
// ensure all pending jobs have been completed
130129
void drain() override;
131130

132-
// ensure all pending job have been completed and data has been flush to
131+
// ensure all pending jobs have been completed and data has been flushed to
133132
// device(s).
134133
void flush() override;
135134

cachelib/navy/serialization/RecordIO.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,8 @@ class DeviceMetaDataWriter final : public RecordWriter {
6767
explicit DeviceMetaDataWriter(Device& dev, size_t metadataSize)
6868
: dev_(dev),
6969
metadataSize_{metadataSize},
70-
blockSize_{dev_.getIOAlignmentSize() >= kBlockSizeDefault
71-
? dev_.getIOAlignmentSize()
72-
: kBlockSizeDefault} {}
70+
blockSize_{
71+
std::max<size_t>(dev_.getIOAlignmentSize(), kBlockSizeDefault)} {}
7372

7473
~DeviceMetaDataWriter() override {
7574
uint8_t* bufferData = buffer_.data();
@@ -174,9 +173,8 @@ class DeviceMetaDataReader final : public RecordReader {
174173
explicit DeviceMetaDataReader(Device& dev, size_t metadataSize)
175174
: dev_{dev},
176175
metadataSize_{metadataSize},
177-
blockSize_{dev_.getIOAlignmentSize() >= kBlockSizeDefault
178-
? dev_.getIOAlignmentSize()
179-
: kBlockSizeDefault} {}
176+
blockSize_{
177+
std::max<size_t>(dev_.getIOAlignmentSize(), kBlockSizeDefault)} {}
180178
~DeviceMetaDataReader() override = default;
181179

182180
std::unique_ptr<folly::IOBuf> readRecord() override {

0 commit comments

Comments
 (0)