File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 2828#include " cachelib/navy/admission_policy/AdmissionPolicy.h"
2929#include " cachelib/navy/common/Buffer.h"
3030#include " cachelib/navy/common/Device.h"
31- #include " cachelib/navy/engine/Engine.h"
3231#include " cachelib/navy/engine/EnginePair.h"
3332#include " cachelib/navy/scheduler/JobScheduler.h"
3433
@@ -126,10 +125,10 @@ class Driver final : public AbstractCache {
126125 // @param cb a callback function be triggered when the remove complete.
127126 void removeAsync (HashedKey key, RemoveCallback cb) override ;
128127
129- // ensure all pending job have been completed
128+ // ensure all pending jobs have been completed
130129 void drain () override ;
131130
132- // ensure all pending job have been completed and data has been flush to
131+ // ensure all pending jobs have been completed and data has been flushed to
133132 // device(s).
134133 void flush () override ;
135134
Original file line number Diff line number Diff line change @@ -67,9 +67,8 @@ class DeviceMetaDataWriter final : public RecordWriter {
6767 explicit DeviceMetaDataWriter (Device& dev, size_t metadataSize)
6868 : dev_(dev),
6969 metadataSize_{metadataSize},
70- blockSize_{dev_.getIOAlignmentSize () >= kBlockSizeDefault
71- ? dev_.getIOAlignmentSize ()
72- : kBlockSizeDefault } {}
70+ blockSize_{
71+ std::max<size_t >(dev_.getIOAlignmentSize (), kBlockSizeDefault )} {}
7372
7473 ~DeviceMetaDataWriter () override {
7574 uint8_t * bufferData = buffer_.data ();
@@ -174,9 +173,8 @@ class DeviceMetaDataReader final : public RecordReader {
174173 explicit DeviceMetaDataReader (Device& dev, size_t metadataSize)
175174 : dev_{dev},
176175 metadataSize_{metadataSize},
177- blockSize_{dev_.getIOAlignmentSize () >= kBlockSizeDefault
178- ? dev_.getIOAlignmentSize ()
179- : kBlockSizeDefault } {}
176+ blockSize_{
177+ std::max<size_t >(dev_.getIOAlignmentSize (), kBlockSizeDefault )} {}
180178 ~DeviceMetaDataReader () override = default ;
181179
182180 std::unique_ptr<folly::IOBuf> readRecord () override {
You can’t perform that action at this time.
0 commit comments