`ArtifactTree::cleanup_finished` panics in open source builds

[9999years]

soft_error! returns Err(err) in open source builds and Ok(err) (maybe?) at FB:

buck2/app/buck2_env/src/soft_error.rs

Lines 294 to 302 in 38080ae

	// @oss-disable: let is_open_source = false;
	let is_open_source = true; // @oss-enable
	if is_open_source {
	// We don't log these, and we have no legacy users, and they might not upgrade that often,
	// so lets just break open source things immediately.
	return Err(err);
	}
	Ok(err)

This seems pretty clearly designed to preferentially crash open source users ("lets just break open source things immediately").

Well, here's an .unwrap() call:

buck2/app/buck2_execute_impl/src/materializers/deferred/artifact_tree.rs

Lines 394 to 395 in 38080ae

	// NOTE: This shouldn't normally happen?
	soft_error!("cleanup_finished_vacant", e, quiet: true).unwrap();

This whole approach seems bad.

[9999years]

Some files that do soft_error!(...).unwrap() (maybe not complete):

app/buck2_execute_impl/src/materializers/deferred/artifact_tree.rs
app/buck2_execute_impl/src/materializers/deferred/command_processor.rs
app/buck2_execute_impl/src/sqlite/incremental_state_db.rs