Improve error handling when reading config file

Author: MSE99

index.js

@@ -184,15 +184,17 @@ Hook.prototype.initialize = function initialize () {
   this.root = this.root.stdout.toString().trim()
 
   if (fs.existsSync(path.join(this.root, '.pre-commit.json'))) {
-    let preCommitConfig
+    let configFile
 
     try {
-      const raw = fs.readFileSync(path.join(this.root, '.pre-commit.json'), 'utf-8').toString()
-      preCommitConfig = JSON.parse(raw)
-    } catch (err) {}
+      const rawText = fs.readFileSync(path.join(this.root, '.pre-commit.json'), 'utf-8').toString()
+      configFile = JSON.parse(rawText)
+    } catch (e) {
+      return this.log(this.format(Hook.log.preCommitConfig, e.message), 1)
+    }
 
-    if (typeof preCommitConfig === 'object' && !Array.isArray(preCommitConfig)) {
-      this.configFile = preCommitConfig
+    if (typeof configFile === 'object' && !Array.isArray(configFile)) {
+      this.configFile = configFile
     }
   }
 
@@ -298,6 +300,14 @@ Hook.log = {
     'Skipping the pre-commit hook.'
   ].join('\n'),
 
+  preCommitConfig: [
+    'Received an error while parsing or locating the `.pre-commit.json` file:',
+    '',
+    '  %s',
+    '',
+    'Skipping the pre-commit hook.'
+  ].join('\n'),
+
   run: [
     'We have nothing pre-commit hooks to run. Either you\'re missing the `scripts`',
     'in your `package.json` or have configured pre-commit to run nothing.',

test.js

@@ -26,7 +26,7 @@ t.test('pre-commit', function (t) {
   })
 
   t.test('#parse', function (t) {
-    t.plan(8)
+    t.plan(9)
 
     let hook
 
@@ -143,7 +143,7 @@ t.test('pre-commit', function (t) {
       t.strictSame(typeof hook.config.run, 'undefined')
     })
 
-    t.test('overrides the `pre-commit` config property in package.json with the config inside pre-commit.json if it exists', function (t) {
+    t.test('overrides the `pre-commit` config property in package.json with the config inside `.pre-commit.json` if it exists', function (t) {
       t.plan(1)
 
       const Hook = proxyquire('.', {
@@ -163,6 +163,40 @@ t.test('pre-commit', function (t) {
       // ----
       t.same(hook.config.run, ['lint', 'bench'])
     })
+
+    t.test('should properly handle errors while trying to read and parse the contents of `.pre-commit.json`', function (t) {
+      t.plan(4)
+
+      let Hook = proxyquire('.', {
+        fs: {
+          existsSync () {
+            return true
+          },
+          readFileSync () {
+            throw new Error()
+          }
+        }
+      })
+
+      hook = new Hook(exit)
+
+      Hook = proxyquire('.', {
+        fs: {
+          existsSync () { return true },
+          readFileSync () {
+            return Buffer.from('{ "bad": [json }')
+          }
+        }
+      })
+
+      hook = new Hook(exit)
+
+      // *****************
+      function exit (code, lines) {
+        t.not(lines.length, 0)
+        t.equal(code, 1)
+      }
+    })
   })
 
   t.test('#log', function (t) {