[CDTOOL-1070] feat(logging): Add support for 'processing region' attribute. (#1491)

All logging commands (create/describe/list/update) now support the
'processing region' attribute.

 All Submissions:

* [X] Have you followed the guidelines in our Contributing document?
* [X] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?

<!-- You can erase any parts of this template not applicable to your
Pull Request. -->

### New Feature Submissions:

* [X] Does your submission pass tests?

### Changes to Core Features:

* [ ] Have you added an explanation of what your changes do and why
you'd like us to include them?
* [ ] Have you written new tests for your core changes, as applicable?
* [ ] Have you successfully run tests with your changes locally?

### User Impact

* [ ] What is the user impact of this change?

### Are there any considerations that need to be addressed for release?

<!-- Any breaking changes, etc -->

Author: kpfleming

CHANGELOG.md

@@ -9,6 +9,7 @@
 - feat(config-store): Allow for dynamic limits on Config Store entry lengths [#1485](https://github.com/fastly/cli/pull/1485)
 - feat(backend): Add support for 'prefer IPv6' attribute. ([#1487](https://github.com/fastly/cli/pull/1487))
 - feat(tools/domain): add `suggest` and `status` domain tools endpoints ([#1482](https://github.com/fastly/cli/pull/1482))
+- feat(logging): Add support for 'processing region' attribute. ([#1491](https://github.com/fastly/cli/pull/1491))
 
 ### Bug fixes:
 - fix(sso): Don't display the token after authentication. ([#1490](https://github.com/fastly/cli/pull/1490))

pkg/commands/logging/azureblob/azureblob_integration_test.go

@@ -327,6 +327,7 @@ func listBlobStoragesOK(i *fastly.ListBlobStoragesInput) ([]*fastly.BlobStorage,
 			Placement:         fastly.ToPointer("none"),
 			ResponseCondition: fastly.ToPointer("Prevent default logging"),
 			CompressionCodec:  fastly.ToPointer("zstd"),
+			ProcessingRegion:  fastly.ToPointer("us"),
 		},
 		{
 			ServiceID:         fastly.ToPointer(i.ServiceID),
@@ -345,6 +346,7 @@ func listBlobStoragesOK(i *fastly.ListBlobStoragesInput) ([]*fastly.BlobStorage,
 			Placement:         fastly.ToPointer("none"),
 			PublicKey:         fastly.ToPointer(pgpPublicKey()),
 			CompressionCodec:  fastly.ToPointer("zstd"),
+			ProcessingRegion:  fastly.ToPointer("us"),
 		},
 	}, nil
 }
@@ -385,6 +387,7 @@ Version: 1
 		Public key: `+pgpPublicKey()+`
 		File max bytes: 0
 		Compression codec: zstd
+		Processing region: us
 	BlobStorage 2/2
 		Service ID: 123
 		Version: 1
@@ -404,6 +407,7 @@ Version: 1
 		Public key: `+pgpPublicKey()+`
 		File max bytes: 0
 		Compression codec: zstd
+		Processing region: us
 `) + "\n\n"
 
 func getBlobStorageOK(i *fastly.GetBlobStorageInput) (*fastly.BlobStorage, error) {
@@ -423,6 +427,7 @@ func getBlobStorageOK(i *fastly.GetBlobStorageInput) (*fastly.BlobStorage, error
 		MessageType:       fastly.ToPointer("classic"),
 		TimestampFormat:   fastly.ToPointer("%Y-%m-%dT%H:%M:%S.000"),
 		Placement:         fastly.ToPointer("none"),
+		ProcessingRegion:  fastly.ToPointer("us"),
 		PublicKey:         fastly.ToPointer(pgpPublicKey()),
 		CompressionCodec:  fastly.ToPointer("zstd"),
 	}, nil
@@ -445,6 +450,7 @@ Name: logs
 Path: /logs
 Period: 3600
 Placement: none
+Processing region: us
 Public key: `+pgpPublicKey()+`
 Response condition: Prevent default logging
 SAS token: token

pkg/commands/logging/azureblob/azureblob_test.go

@@ -53,6 +53,7 @@ func TestCreateBlobStorageInput(t *testing.T) {
 				ResponseCondition: fastly.ToPointer("Prevent default logging"),
 				TimestampFormat:   fastly.ToPointer("%Y-%m-%dT%H:%M:%S.000"),
 				Placement:         fastly.ToPointer("none"),
+				ProcessingRegion:  fastly.ToPointer("eu"),
 				PublicKey:         fastly.ToPointer(pgpPublicKey()),
 				CompressionCodec:  fastly.ToPointer("zstd"),
 			},
@@ -129,6 +130,7 @@ func TestUpdateBlobStorageInput(t *testing.T) {
 				MessageType:       fastly.ToPointer("new8"),
 				TimestampFormat:   fastly.ToPointer("new9"),
 				Placement:         fastly.ToPointer("new10"),
+				ProcessingRegion:  fastly.ToPointer("eu"),
 				PublicKey:         fastly.ToPointer("new11"),
 				CompressionCodec:  fastly.ToPointer("new12"),
 			},
@@ -276,6 +278,7 @@ func createCommandAll() *azureblob.CreateCommand {
 		ResponseCondition: argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "Prevent default logging"},
 		TimestampFormat:   argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "%Y-%m-%dT%H:%M:%S.000"},
 		Placement:         argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "none"},
+		ProcessingRegion:  argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "eu"},
 		MessageType:       argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "classic"},
 		PublicKey:         argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: pgpPublicKey()},
 		CompressionCodec:  argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "zstd"},
@@ -364,6 +367,7 @@ func updateCommandAll() *azureblob.UpdateCommand {
 		MessageType:       argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new8"},
 		TimestampFormat:   argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new9"},
 		Placement:         argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new10"},
+		ProcessingRegion:  argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "eu"},
 		PublicKey:         argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new11"},
 		CompressionCodec:  argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new12"},
 	}

pkg/commands/logging/azureblob/create.go

@@ -40,6 +40,7 @@ type CreateCommand struct {
 	ResponseCondition argparser.OptionalString
 	TimestampFormat   argparser.OptionalString
 	Placement         argparser.OptionalString
+	ProcessingRegion  argparser.OptionalString
 	PublicKey         argparser.OptionalString
 	FileMaxBytes      argparser.OptionalInt
 	CompressionCodec  argparser.OptionalString
@@ -79,6 +80,7 @@ func NewCreateCommand(parent argparser.Registerer, g *global.Data) *CreateComman
 	common.Path(c.CmdClause, &c.Path)
 	common.Period(c.CmdClause, &c.Period)
 	common.Placement(c.CmdClause, &c.Placement)
+	common.ProcessingRegion(c.CmdClause, &c.ProcessingRegion, "Azure Blob Storage")
 	common.PublicKey(c.CmdClause, &c.PublicKey)
 	common.ResponseCondition(c.CmdClause, &c.ResponseCondition)
 	c.CmdClause.Flag("sas-token", "The Azure shared access signature providing write access to the blob service objects. Be sure to update your token before it expires or the logging functionality will not work").Action(c.SASToken.Set).StringVar(&c.SASToken.Value)
@@ -151,6 +153,9 @@ func (c *CreateCommand) ConstructInput(serviceID string, serviceVersion int) (*f
 	if c.Placement.WasSet {
 		input.Placement = &c.Placement.Value
 	}
+	if c.ProcessingRegion.WasSet {
+		input.ProcessingRegion = &c.ProcessingRegion.Value
+	}
 	if c.PublicKey.WasSet {
 		input.PublicKey = &c.PublicKey.Value
 	}

pkg/commands/logging/azureblob/describe.go

@@ -107,6 +107,7 @@ func (c *DescribeCommand) Exec(_ io.Reader, out io.Writer) error {
 		"Path":               fastly.ToValue(o.Path),
 		"Period":             fastly.ToValue(o.Period),
 		"Placement":          fastly.ToValue(o.Placement),
+		"Processing region":  fastly.ToValue(o.ProcessingRegion),
 		"Public key":         fastly.ToValue(o.PublicKey),
 		"Response condition": fastly.ToValue(o.ResponseCondition),
 		"SAS token":          fastly.ToValue(o.SASToken),

pkg/commands/logging/azureblob/list.go

@@ -129,6 +129,7 @@ func (c *ListCommand) Exec(_ io.Reader, out io.Writer) error {
 		fmt.Fprintf(out, "\t\tPublic key: %s\n", fastly.ToValue(azureblob.PublicKey))
 		fmt.Fprintf(out, "\t\tFile max bytes: %d\n", fastly.ToValue(azureblob.FileMaxBytes))
 		fmt.Fprintf(out, "\t\tCompression codec: %s\n", fastly.ToValue(azureblob.CompressionCodec))
+		fmt.Fprintf(out, "\t\tProcessing region: %s\n", fastly.ToValue(azureblob.ProcessingRegion))
 	}
 	fmt.Fprintln(out)
 

pkg/commands/logging/azureblob/update.go

@@ -40,6 +40,7 @@ type UpdateCommand struct {
 	ResponseCondition argparser.OptionalString
 	TimestampFormat   argparser.OptionalString
 	Placement         argparser.OptionalString
+	ProcessingRegion  argparser.OptionalString
 	PublicKey         argparser.OptionalString
 	FileMaxBytes      argparser.OptionalInt
 	CompressionCodec  argparser.OptionalString
@@ -82,6 +83,7 @@ func NewUpdateCommand(parent argparser.Registerer, g *global.Data) *UpdateComman
 	common.Path(c.CmdClause, &c.Path)
 	common.Period(c.CmdClause, &c.Period)
 	common.Placement(c.CmdClause, &c.Placement)
+	common.ProcessingRegion(c.CmdClause, &c.ProcessingRegion, "Azure Blob Storage")
 	common.PublicKey(c.CmdClause, &c.PublicKey)
 	common.ResponseCondition(c.CmdClause, &c.ResponseCondition)
 	c.CmdClause.Flag("sas-token", "The Azure shared access signature providing write access to the blob service objects. Be sure to update your token before it expires or the logging functionality will not work").Action(c.SASToken.Set).StringVar(&c.SASToken.Value)
@@ -149,6 +151,9 @@ func (c *UpdateCommand) ConstructInput(serviceID string, serviceVersion int) (*f
 	if c.Placement.WasSet {
 		input.Placement = &c.Placement.Value
 	}
+	if c.ProcessingRegion.WasSet {
+		input.ProcessingRegion = &c.ProcessingRegion.Value
+	}
 	if c.PublicKey.WasSet {
 		input.PublicKey = &c.PublicKey.Value
 	}

pkg/commands/logging/bigquery/bigquery_integration_test.go

@@ -300,6 +300,7 @@ func listBigQueriesOK(i *fastly.ListBigQueriesInput) ([]*fastly.BigQuery, error)
 			Template:          fastly.ToPointer("%Y%m%d"),
 			Placement:         fastly.ToPointer("none"),
 			ResponseCondition: fastly.ToPointer("Prevent default logging"),
+			ProcessingRegion:  fastly.ToPointer("us"),
 		},
 		{
 			ServiceID:         fastly.ToPointer(i.ServiceID),
@@ -315,6 +316,7 @@ func listBigQueriesOK(i *fastly.ListBigQueriesInput) ([]*fastly.BigQuery, error)
 			Template:          fastly.ToPointer("%Y%m%d"),
 			Placement:         fastly.ToPointer("none"),
 			ResponseCondition: fastly.ToPointer("Prevent default logging"),
+			ProcessingRegion:  fastly.ToPointer("us"),
 		},
 	}, nil
 }
@@ -351,6 +353,7 @@ Version: 1
 		Response condition: Prevent default logging
 		Placement: none
 		Format version: 0
+		Processing region: us
 	BigQuery 2/2
 		Service ID: 123
 		Version: 1
@@ -366,6 +369,7 @@ Version: 1
 		Response condition: Prevent default logging
 		Placement: none
 		Format version: 0
+		Processing region: us
 `) + "\n\n"
 
 func getBigQueryOK(i *fastly.GetBigQueryInput) (*fastly.BigQuery, error) {
@@ -383,6 +387,7 @@ func getBigQueryOK(i *fastly.GetBigQueryInput) (*fastly.BigQuery, error) {
 		Template:          fastly.ToPointer("%Y%m%d"),
 		Placement:         fastly.ToPointer("none"),
 		ResponseCondition: fastly.ToPointer("Prevent default logging"),
+		ProcessingRegion:  fastly.ToPointer("us"),
 	}, nil
 }
 
@@ -397,6 +402,7 @@ Format: %h %l %u %t "%r" %>s %b
 Format version: 0
 Name: logs
 Placement: none
+Processing region: us
 Project ID: my-project
 Response condition: Prevent default logging
 Secret key: -----BEGIN RSA PRIVATE KEY-----MIIEogIBAAKCA

pkg/commands/logging/bigquery/bigquery_test.go

@@ -53,6 +53,7 @@ func TestCreateBigQueryInput(t *testing.T) {
 				Format:            fastly.ToPointer(`%h %l %u %t "%r" %>s %b`),
 				ResponseCondition: fastly.ToPointer("Prevent default logging"),
 				Placement:         fastly.ToPointer("none"),
+				ProcessingRegion:  fastly.ToPointer("eu"),
 				FormatVersion:     fastly.ToPointer(2),
 			},
 		},
@@ -138,6 +139,7 @@ func TestUpdateBigQueryInput(t *testing.T) {
 				Template:          fastly.ToPointer("new7"),
 				ResponseCondition: fastly.ToPointer("new8"),
 				Placement:         fastly.ToPointer("new9"),
+				ProcessingRegion:  fastly.ToPointer("eu"),
 				Format:            fastly.ToPointer("new10"),
 				FormatVersion:     fastly.ToPointer(3),
 			},
@@ -269,6 +271,7 @@ func createCommandAll() *bigquery.CreateCommand {
 		Template:          argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "template"},
 		ResponseCondition: argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "Prevent default logging"},
 		Placement:         argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "none"},
+		ProcessingRegion:  argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "eu"},
 		Format:            argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: `%h %l %u %t "%r" %>s %b`},
 		FormatVersion:     argparser.OptionalInt{Optional: argparser.Optional{WasSet: true}, Value: 2},
 	}
@@ -352,6 +355,7 @@ func updateCommandAll() *bigquery.UpdateCommand {
 		Template:          argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new7"},
 		ResponseCondition: argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new8"},
 		Placement:         argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new9"},
+		ProcessingRegion:  argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "eu"},
 		Format:            argparser.OptionalString{Optional: argparser.Optional{WasSet: true}, Value: "new10"},
 		FormatVersion:     argparser.OptionalInt{Optional: argparser.Optional{WasSet: true}, Value: 3},
 	}

pkg/commands/logging/bigquery/create.go

@@ -32,6 +32,7 @@ type CreateCommand struct {
 	Format            argparser.OptionalString
 	FormatVersion     argparser.OptionalInt
 	Placement         argparser.OptionalString
+	ProcessingRegion  argparser.OptionalString
 	ProjectID         argparser.OptionalString
 	ResponseCondition argparser.OptionalString
 	SecretKey         argparser.OptionalString
@@ -68,6 +69,7 @@ func NewCreateCommand(parent argparser.Registerer, g *global.Data) *CreateComman
 	common.FormatVersion(c.CmdClause, &c.FormatVersion)
 	c.CmdClause.Flag("name", "The name of the BigQuery logging object. Used as a primary key for API access").Short('n').Action(c.EndpointName.Set).StringVar(&c.EndpointName.Value)
 	common.Placement(c.CmdClause, &c.Placement)
+	common.ProcessingRegion(c.CmdClause, &c.ProcessingRegion, "BigQuery")
 	c.CmdClause.Flag("project-id", "Your Google Cloud Platform project ID").Action(c.ProjectID.Set).StringVar(&c.ProjectID.Value)
 	common.ResponseCondition(c.CmdClause, &c.ResponseCondition)
 	c.CmdClause.Flag("secret-key", "Your Google Cloud Platform account secret key. The private_key field in your service account authentication JSON.").Action(c.SecretKey.Set).StringVar(&c.SecretKey.Value)
@@ -114,6 +116,9 @@ func (c *CreateCommand) ConstructInput(serviceID string, serviceVersion int) (*f
 	if c.Placement.WasSet {
 		input.Placement = &c.Placement.Value
 	}
+	if c.ProcessingRegion.WasSet {
+		input.ProcessingRegion = &c.ProcessingRegion.Value
+	}
 	if c.ProjectID.WasSet {
 		input.ProjectID = &c.ProjectID.Value
 	}