[CDTOOL-1195] Correct 'tls-custom activation enable' command parameters to reflect expected input from API (#1562)

### Change summary
This fixes #1329. 
This PR correctly maps the required fields for creating a TLS
Activation. Previously we were inputting a unclear `id` field and not
intaking the required `tls_domain` api field. The input flags have been
updated to require the following flags instead:
```
  --cert-id=CERT-ID                         Alphanumeric string identifying a TLS certificate
  --tls-config-id=TLS-CONFIG-ID  Alphanumeric string identifying a TLS configuration
  --tls-domain=TLS-DOMAIN        The domain name associated with the TLS activation
```

 All Submissions:

* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?

<!-- You can erase any parts of this template not applicable to your
Pull Request. -->

### New Feature Submissions:

* [x] Does your submission pass tests?

### Changes to Core Features:

* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?

### User Impact

Users may now use the CLI for creating new TLS activations. 

### Are there any considerations that need to be addressed for release?

This is a breaking change as we are modifying command parameters.

Author: rcaril

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [Unreleased]
 
 ### Breaking:
+- breaking(tls-custom): correct 'tls-custom activation enable' command parameters to reflect expected input from API ([#1562](https://github.com/fastly/cli/pull/1562))
 
 ### Enhancements:
 - build(dockerfile-rust): add wasm tools to the rust docker container ([#1552](https://github.com/fastly/cli/pull/1552))

pkg/commands/tls/custom/activation/activation_test.go

@@ -16,6 +16,8 @@ import (
 const (
 	mockResponseID        = "123"
 	mockResponseCertID    = "456"
+	mockResponseConfigID  = "789"
+	mockResponseDomain    = "tls.example.com"
 	validateAPIError      = "validate API error"
 	validateAPISuccess    = "validate API success"
 	validateMissingIDFlag = "validate missing --id flag"
@@ -24,14 +26,19 @@ const (
 func TestTLSCustomActivationEnable(t *testing.T) {
 	scenarios := []testutil.CLIScenario{
 		{
-			Name:      validateMissingIDFlag,
-			Args:      "--cert-id example",
-			WantError: "required flag --id not provided",
+			Name:      "validate missing CertID flag",
+			Args:      fmt.Sprintf("--tls-config-id %s --tls-domain %s", mockResponseConfigID, mockResponseDomain),
+			WantError: "required flag --cert-id not provided",
 		},
 		{
-			Name:      validateMissingIDFlag,
-			Args:      "--id example",
-			WantError: "required flag --cert-id not provided",
+			Name:      "validate missing ConfigID flag",
+			Args:      fmt.Sprintf("--cert-id %s --tls-domain %s", mockResponseCertID, mockResponseDomain),
+			WantError: "required flag --tls-config-id not provided",
+		},
+		{
+			Name:      "validate missing Domain Flag",
+			Args:      fmt.Sprintf("--cert-id %s --tls-config-id %s", mockResponseCertID, mockResponseConfigID),
+			WantError: "required flag --tls-domain not provided",
 		},
 		{
 			Name: validateAPIError,
@@ -40,7 +47,7 @@ func TestTLSCustomActivationEnable(t *testing.T) {
 					return nil, testutil.Err
 				},
 			},
-			Args:      "--cert-id example --id example",
+			Args:      fmt.Sprintf("--cert-id %s --tls-config-id %s --tls-domain %s", mockResponseCertID, mockResponseConfigID, mockResponseDomain),
 			WantError: testutil.Err.Error(),
 		},
 		{
@@ -49,14 +56,11 @@ func TestTLSCustomActivationEnable(t *testing.T) {
 				CreateTLSActivationFn: func(_ context.Context, _ *fastly.CreateTLSActivationInput) (*fastly.TLSActivation, error) {
 					return &fastly.TLSActivation{
 						ID: mockResponseID,
-						Certificate: &fastly.CustomTLSCertificate{
-							ID: mockResponseCertID,
-						},
 					}, nil
 				},
 			},
-			Args:       "--cert-id example --id example",
-			WantOutput: fmt.Sprintf("Enabled TLS Activation '%s' (Certificate '%s')", mockResponseID, mockResponseCertID),
+			Args:       fmt.Sprintf("--cert-id %s --tls-config-id %s --tls-domain %s", mockResponseCertID, mockResponseConfigID, mockResponseDomain),
+			WantOutput: fmt.Sprintf("SUCCESS: Enabled TLS Activation '%s' (Certificate '%s', Configuration '%s')", mockResponseID, mockResponseCertID, mockResponseConfigID),
 		},
 	}
 

pkg/commands/tls/custom/activation/create.go

@@ -19,7 +19,8 @@ func NewCreateCommand(parent argparser.Registerer, g *global.Data) *CreateComman
 
 	// Required.
 	c.CmdClause.Flag("cert-id", "Alphanumeric string identifying a TLS certificate").Required().StringVar(&c.certID)
-	c.CmdClause.Flag("id", "Alphanumeric string identifying a TLS activation").Required().StringVar(&c.id)
+	c.CmdClause.Flag("tls-config-id", "Alphanumeric string identifying a TLS configuration").Required().StringVar(&c.tlsConfigID)
+	c.CmdClause.Flag("tls-domain", "The domain name associated with the TLS certificate").Required().StringVar(&c.tlsDomain)
 
 	return &c
 }
@@ -28,8 +29,9 @@ func NewCreateCommand(parent argparser.Registerer, g *global.Data) *CreateComman
 type CreateCommand struct {
 	argparser.Base
 
-	certID string
-	id     string
+	certID      string
+	tlsConfigID string
+	tlsDomain   string
 }
 
 // Exec invokes the application logic for the command.
@@ -39,22 +41,24 @@ func (c *CreateCommand) Exec(_ io.Reader, out io.Writer) error {
 	r, err := c.Globals.APIClient.CreateTLSActivation(context.TODO(), input)
 	if err != nil {
 		c.Globals.ErrLog.AddWithContext(err, map[string]any{
-			"TLS Activation ID":             c.id,
+			"TLS Configuration ID":          c.tlsConfigID,
 			"TLS Activation Certificate ID": c.certID,
+			"TLS Domain":                    c.tlsDomain,
 		})
 		return err
 	}
 
-	text.Success(out, "Enabled TLS Activation '%s' (Certificate '%s')", r.ID, r.Certificate.ID)
+	text.Success(out, "Enabled TLS Activation '%s' (Certificate '%s', Configuration '%s')", r.ID, c.certID, c.tlsConfigID)
 	return nil
 }
 
 // constructInput transforms values parsed from CLI flags into an object to be used by the API client library.
 func (c *CreateCommand) constructInput() *fastly.CreateTLSActivationInput {
 	var input fastly.CreateTLSActivationInput
 
-	input.ID = c.id
+	input.Configuration = &fastly.TLSConfiguration{ID: c.tlsConfigID}
 	input.Certificate = &fastly.CustomTLSCertificate{ID: c.certID}
+	input.Domain = &fastly.TLSDomain{ID: c.tlsDomain}
 
 	return &input
 }