Skip to content

Commit a720700

Browse files
Add Rust 1.93.0 to the Rust version blocklist. (#1653)
### Change summary Rust 1.93.0 has a bug in the wasm32-wasip2 target, so it doesn't affect current Fastly users, however there are potential future use cases affected by it, so add a blocklist rule for it. All Submissions: * [x] Have you followed the guidelines in our Contributing document? * [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/fastly/cli/pulls) for the same update/change? <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### User Impact Users using Rust 1.93.0 will need to upgrade to Rust 1.93.1. --------- Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
1 parent e97c3b9 commit a720700

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

.fastly/config.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ toolchain_constraint = ">= 1.21" # Go toolchain constraint for use wit
1818
toolchain_constraint_tinygo = ">= 1.18" # Go toolchain constraint for use with TinyGo.
1919

2020
[language.rust]
21-
toolchain_constraint = ">= 1.78 != 1.91.0" # Rust 1.91.0 produces broken WASM packages which crash when handling requests
21+
# * Rust 1.91.0 has a bug where it produces broken wasm packages which crash
22+
# when handling requests; the bug is fixed in Rust 1.91.1.
23+
# * Rust 1.93.0 has a bug on wasm32-wasip2 where it leaks file descriptors in
24+
# `std::fs::File`; the bug is fixed in Rust 1.93.1.
25+
toolchain_constraint = ">= 1.78 != 1.91.0 != 1.93.0"
2226
wasm_wasi_target = "wasm32-wasip1"
2327

2428
[wasm-tools]

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ both the old and new forms are:
110110
- feat(service/resourcelink): moved the `resource-link` commands under the `service` command, with an unlisted and deprecated alias of `resource-link` ([#1635](https://github.com/fastly/cli/pull/1635))
111111
- feat(service/logging): moved the `logging` commands under the `service` command, with an unlisted and deprecated alias of `logging` ([#1642](https://github.com/fastly/cli/pull/1642))
112112
- feat(service/auth): moved the `service-auth` commands under the `service` command and renamed to `auth`, with an unlisted and deprecated alias of `service-auth` ([#1643](https://github.com/fastly/cli/pull/1643))
113+
- feat(compute/build): Block version 1.93.0 of Rust to avoid a wasm32-wasip2 bug. ([#1653](https://github.com/fastly/cli/pull/1653))
113114

114115
### Bug fixes:
115116

0 commit comments

Comments
 (0)