[CDTOOL-1265] Move vcl commands under service (#1616)

### Change summary

 <!--
Briefly describe the changes introduced in this pull request. Include
context or
reasoning behind the changes, even if they seem minor. If relevant, link
to any
related discussions (e.g. Slack threads, tickets, documents).
-->

 All Submissions:

* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?

<!-- You can erase any parts of this template not applicable to your
Pull Request. -->

### New Feature Submissions:

* [x] Does your submission pass tests?

```
// Sampled a few tests, they all seems to run
make test TEST_ARGS="-run TestConditionCreate ./pkg/commands/service/vcl/condition"
ok      github.com/fastly/cli/pkg/commands/service/vcl/condition        1.050s
make test TEST_ARGS="-run TestCustomCreate ./pkg/commands/service/vcl/custom"
ok      github.com/fastly/cli/pkg/commands/service/vcl/custom   1.024s [no tests to run]
make test TEST_ARGS="-run TestSnippetCreate ./pkg/commands/service/vcl/snippet"
ok      github.com/fastly/cli/pkg/commands/service/vcl/snippet  1.022s [no tests to run]
make test TEST_ARGS="-run TestVCLDescribe ./pkg/commands/service/vcl"
ok      github.com/fastly/cli/pkg/commands/service/vcl  1.063s
```

### Changes to Core Features:

* [ ] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?

### User Impact

None as alias' have been implemented.

Author: rcaril

CHANGELOG.md

@@ -13,6 +13,7 @@
 - refactor(argparser/flags.go): add flag conversion utilities for converting string flags to bools and checking ascending and desecnding flags ([#1611](https://github.com/fastly/cli/pull/1611))
 - feat(service/purge): Add 'service purge' command as replacement for 'purge', with an unlisted and deprecated alias of 'purge'. ([#1612](https://github.com/fastly/cli/pull/1612))
 - feat(service/version): Add 'service version ...' commands as replacements for 'service-version ...', with unlisted and deprecated aliases of 'service-version ...'. ([#1614](https://github.com/fastly/cli/pull/1614))
+- feat(vcl): moved the `vcl` command under the `service` command, with an unlisted and deprecated alias of `vcl` ([#1616](https://github.com/fastly/cli/pull/1616))
 
 ### Bug fixes:
 

pkg/app/run_test.go

@@ -100,7 +100,6 @@ tls-subscription
 tools
 update
 user
-vcl
 version
 whoami
 `,

pkg/commands/alias/vcl/condition/create.go

@@ -0,0 +1,29 @@
+package condition
+
+import (
+	"io"
+
+	newcmd "github.com/fastly/cli/pkg/commands/service/vcl/condition"
+
+	"github.com/fastly/cli/pkg/argparser"
+	"github.com/fastly/cli/pkg/global"
+	"github.com/fastly/cli/pkg/text"
+)
+
+// CreateCommand wraps the CreateCommand from the newcmd package.
+type CreateCommand struct {
+	*newcmd.CreateCommand
+}
+
+// NewCreateCommand returns a usable command registered under the parent.
+func NewCreateCommand(parent argparser.Registerer, g *global.Data) *CreateCommand {
+	c := CreateCommand{newcmd.NewCreateCommand(parent, g)}
+	c.CmdClause.Hidden()
+	return &c
+}
+
+// Exec implements the command interface.
+func (c *CreateCommand) Exec(in io.Reader, out io.Writer) error {
+	text.Deprecated(out, "Use the 'service vcl condition create' command instead.")
+	return c.CreateCommand.Exec(in, out)
+}

pkg/commands/alias/vcl/condition/delete.go

@@ -0,0 +1,29 @@
+package condition
+
+import (
+	"io"
+
+	newcmd "github.com/fastly/cli/pkg/commands/service/vcl/condition"
+
+	"github.com/fastly/cli/pkg/argparser"
+	"github.com/fastly/cli/pkg/global"
+	"github.com/fastly/cli/pkg/text"
+)
+
+// DeleteCommand wraps the DeleteCommand from the newcmd package.
+type DeleteCommand struct {
+	*newcmd.DeleteCommand
+}
+
+// NewDeleteCommand returns a usable command registered under the parent.
+func NewDeleteCommand(parent argparser.Registerer, g *global.Data) *DeleteCommand {
+	c := DeleteCommand{newcmd.NewDeleteCommand(parent, g)}
+	c.CmdClause.Hidden()
+	return &c
+}
+
+// Exec implements the command interface.
+func (c *DeleteCommand) Exec(in io.Reader, out io.Writer) error {
+	text.Deprecated(out, "Use the 'service vcl condition delete' command instead.")
+	return c.DeleteCommand.Exec(in, out)
+}

pkg/commands/alias/vcl/condition/describe.go

@@ -0,0 +1,29 @@
+package condition
+
+import (
+	"io"
+
+	newcmd "github.com/fastly/cli/pkg/commands/service/vcl/condition"
+
+	"github.com/fastly/cli/pkg/argparser"
+	"github.com/fastly/cli/pkg/global"
+	"github.com/fastly/cli/pkg/text"
+)
+
+// DescribeCommand wraps the DescribeCommand from the newcmd package.
+type DescribeCommand struct {
+	*newcmd.DescribeCommand
+}
+
+// NewDescribeCommand returns a usable command registered under the parent.
+func NewDescribeCommand(parent argparser.Registerer, g *global.Data) *DescribeCommand {
+	c := DescribeCommand{newcmd.NewDescribeCommand(parent, g)}
+	c.CmdClause.Hidden()
+	return &c
+}
+
+// Exec implements the command interface.
+func (c *DescribeCommand) Exec(in io.Reader, out io.Writer) error {
+	text.Deprecated(out, "Use the 'service vcl condition describe' command instead.")
+	return c.DescribeCommand.Exec(in, out)
+}

pkg/commands/alias/vcl/condition/doc.go

@@ -0,0 +1,2 @@
+// Package condition contains deprecated aliases for the 'service vcl' condition commands.
+package condition

pkg/commands/alias/vcl/condition/list.go

@@ -0,0 +1,31 @@
+package condition
+
+import (
+	"io"
+
+	newcmd "github.com/fastly/cli/pkg/commands/service/vcl/condition"
+
+	"github.com/fastly/cli/pkg/argparser"
+	"github.com/fastly/cli/pkg/global"
+	"github.com/fastly/cli/pkg/text"
+)
+
+// ListCommand wraps the ListCommand from the newcmd package.
+type ListCommand struct {
+	*newcmd.ListCommand
+}
+
+// NewListCommand returns a usable command registered under the parent.
+func NewListCommand(parent argparser.Registerer, g *global.Data) *ListCommand {
+	c := ListCommand{newcmd.NewListCommand(parent, g)}
+	c.CmdClause.Hidden()
+	return &c
+}
+
+// Exec implements the command interface.
+func (c *ListCommand) Exec(in io.Reader, out io.Writer) error {
+	if !c.JSONOutput.Enabled {
+		text.Deprecated(out, "Use the 'service vcl condition list' command instead.")
+	}
+	return c.ListCommand.Exec(in, out)
+}

pkg/commands/alias/vcl/condition/root.go

@@ -0,0 +1,31 @@
+package condition
+
+import (
+	"io"
+
+	"github.com/fastly/cli/pkg/argparser"
+	"github.com/fastly/cli/pkg/global"
+)
+
+// RootCommand is the parent command for all subcommands in this package.
+// It should be installed under the primary root command.
+type RootCommand struct {
+	argparser.Base
+	// no flags
+}
+
+// CommandName is the string to be used to invoke this command.
+const CommandName = "condition"
+
+// NewRootCommand returns a new command registered in the parent.
+func NewRootCommand(parent argparser.Registerer, g *global.Data) *RootCommand {
+	var c RootCommand
+	c.Globals = g
+	c.CmdClause = parent.Command(CommandName, "Manipulate Fastly VCL conditions").Hidden()
+	return &c
+}
+
+// Exec implements the command interface.
+func (c *RootCommand) Exec(_ io.Reader, _ io.Writer) error {
+	panic("unreachable")
+}

pkg/commands/alias/vcl/condition/update.go

@@ -0,0 +1,29 @@
+package condition
+
+import (
+	"io"
+
+	newcmd "github.com/fastly/cli/pkg/commands/service/vcl/condition"
+
+	"github.com/fastly/cli/pkg/argparser"
+	"github.com/fastly/cli/pkg/global"
+	"github.com/fastly/cli/pkg/text"
+)
+
+// UpdateCommand wraps the UpdateCommand from the newcmd package.
+type UpdateCommand struct {
+	*newcmd.UpdateCommand
+}
+
+// NewUpdateCommand returns a usable command registered under the parent.
+func NewUpdateCommand(parent argparser.Registerer, g *global.Data) *UpdateCommand {
+	c := UpdateCommand{newcmd.NewUpdateCommand(parent, g)}
+	c.CmdClause.Hidden()
+	return &c
+}
+
+// Exec implements the command interface.
+func (c *UpdateCommand) Exec(in io.Reader, out io.Writer) error {
+	text.Deprecated(out, "Use the 'service vcl condition update' command instead.")
+	return c.UpdateCommand.Exec(in, out)
+}

pkg/commands/alias/vcl/custom/create.go

@@ -0,0 +1,29 @@
+package custom
+
+import (
+	"io"
+
+	newcmd "github.com/fastly/cli/pkg/commands/service/vcl/custom"
+
+	"github.com/fastly/cli/pkg/argparser"
+	"github.com/fastly/cli/pkg/global"
+	"github.com/fastly/cli/pkg/text"
+)
+
+// CreateCommand wraps the CreateCommand from the newcmd package.
+type CreateCommand struct {
+	*newcmd.CreateCommand
+}
+
+// NewCreateCommand returns a usable command registered under the parent.
+func NewCreateCommand(parent argparser.Registerer, g *global.Data) *CreateCommand {
+	c := CreateCommand{newcmd.NewCreateCommand(parent, g)}
+	c.CmdClause.Hidden()
+	return &c
+}
+
+// Exec implements the command interface.
+func (c *CreateCommand) Exec(in io.Reader, out io.Writer) error {
+	text.Deprecated(out, "Use the 'service vcl custom create' command instead.")
+	return c.CreateCommand.Exec(in, out)
+}