Commit c7b8baf
authored
fix(compute): clarify fastly.toml error message when file not found (#1556)
Add "file not found" to the `ErrReadingManifest` error message to make
it clearer that the file doesn't exist, rather than a parsing or
permission error.
### Change summary
The current error message "error reading fastly.toml" is somewhat
ambiguous and doesn't clearly indicate whether the file is missing or
has parsing errors. The remediation text was present but it still seems
easy to misinterpret the actual problem (as proven by it managing to
throw both me, Claude and ChatGPT off 😅).
This change adds ": file not found" to the error message to make it even
more apparent that the file doesn't exist.
**Before:**
ERROR: error reading fastly.toml. Ensure the Fastly CLI is being run
within a directory containing a fastly.toml
file...
**After:**
ERROR: error reading fastly.toml: file not found. Ensure the Fastly CLI
is being run within a directory containing
a fastly.toml file...
All Submissions:
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for
the same update/change?
### Changes to Core Features:
* [x] Have you written new tests for your core changes, as applicable?
* [ ] Have you successfully run tests with your changes locally?
### User Impact
* Users will now more easily understand that the `fastly.toml` file is
missing.1 parent 21873c6 commit c7b8baf
4 files changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
303 | | - | |
| 303 | + | |
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
| |||
494 | 494 | | |
495 | 495 | | |
496 | 496 | | |
497 | | - | |
| 497 | + | |
498 | 498 | | |
499 | 499 | | |
500 | 500 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
0 commit comments