Skip to content

Commit fb3bbe4

Browse files
committed
Apply suggestions from review
1 parent 346bba9 commit fb3bbe4

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

pkg/commands/compute/serve.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -600,22 +600,22 @@ func (c *ServeCommand) GetPushpinProxyPort(out io.Writer) (uint16, error) {
600600
}
601601
pushpinProxyPort = uint16(pushpinProxyPortInt)
602602
if c.Globals.Verbose() {
603-
text.Output(out, "DEBUG: Using Pushpin proxy port from --pushpin-proxy-port flag: %d", pushpinProxyPort)
603+
text.Info(out, "Using Pushpin proxy port from --pushpin-proxy-port flag: %d", pushpinProxyPort)
604604
}
605605
return pushpinProxyPort, nil
606606
}
607607

608608
pushpinProxyPort = c.Globals.Manifest.File.LocalServer.Pushpin.PushpinProxyPort
609609
if pushpinProxyPort != 0 {
610610
if c.Globals.Verbose() {
611-
text.Output(out, "DEBUG: Using Pushpin proxy port via `local_server.pushpin.proxy_port` setting: %d", pushpinProxyPort)
611+
text.Info(out, "Using Pushpin proxy port via `local_server.pushpin.proxy_port` setting: %d", pushpinProxyPort)
612612
}
613613
return pushpinProxyPort, nil
614614
}
615615

616616
pushpinProxyPort = 7677
617617
if c.Globals.Verbose() {
618-
text.Output(out, "DEBUG: Using default Pushpin proxy port %d", pushpinProxyPort)
618+
text.Info(out, "Using default Pushpin proxy port %d", pushpinProxyPort)
619619
}
620620
return pushpinProxyPort, nil
621621
}
@@ -640,22 +640,22 @@ func (c *ServeCommand) GetPushpinPublishPort(out io.Writer) (uint16, error) {
640640
}
641641
pushpinPublishPort = uint16(pushpinPublishPortInt)
642642
if c.Globals.Verbose() {
643-
text.Output(out, "DEBUG: Using Pushpin publish handler port from --pushpin-publish-port flag: %d", pushpinPublishPort)
643+
text.Info(out, "Using Pushpin publish handler port from --pushpin-publish-port flag: %d", pushpinPublishPort)
644644
}
645645
return pushpinPublishPort, nil
646646
}
647647

648648
pushpinPublishPort = c.Globals.Manifest.File.LocalServer.Pushpin.PushpinPublishPort
649649
if pushpinPublishPort != 0 {
650650
if c.Globals.Verbose() {
651-
text.Output(out, "DEBUG: Using Pushpin publish handler port via `local_server.pushpin.publish_port` setting: %d", pushpinPublishPort)
651+
text.Info(out, "Using Pushpin publish handler port via `local_server.pushpin.publish_port` setting: %d", pushpinPublishPort)
652652
}
653653
return pushpinPublishPort, nil
654654
}
655655

656656
pushpinPublishPort = 5561
657657
if c.Globals.Verbose() {
658-
text.Output(out, "DEBUG: Using default Pushpin publish handler port %d", pushpinPublishPort)
658+
text.Info(out, "Using default Pushpin publish handler port %d", pushpinPublishPort)
659659
}
660660
return pushpinPublishPort, nil
661661
}
@@ -669,21 +669,21 @@ func (c *ServeCommand) GetPushpinRunner(out io.Writer) (bin string, err error) {
669669
pushpinRunnerBinPath := c.pushpinRunnerBinPath
670670
if pushpinRunnerBinPath != "" {
671671
if c.Globals.Verbose() {
672-
text.Output(out, "DEBUG: Using user provided install of Pushpin runner via --pushpin-path flag: %s", pushpinRunnerBinPath)
672+
text.Info(out, "Using user provided install of Pushpin runner via --pushpin-path flag: %s", pushpinRunnerBinPath)
673673
}
674674
return filepath.Abs(pushpinRunnerBinPath)
675675
}
676676

677677
pushpinRunnerBinPath = c.Globals.Manifest.File.LocalServer.Pushpin.PushpinPath
678678
if pushpinRunnerBinPath != "" {
679679
if c.Globals.Verbose() {
680-
text.Output(out, "DEBUG: Using user provided install of Pushpin runner via `local_server.pushpin.pushpin_path` setting: %s", pushpinRunnerBinPath)
680+
text.Info(out, "Using user provided install of Pushpin runner via `local_server.pushpin.pushpin_path` setting: %s", pushpinRunnerBinPath)
681681
}
682682
return filepath.Abs(pushpinRunnerBinPath)
683683
}
684684

685685
if c.Globals.Verbose() {
686-
text.Output(out, "DEBUG: No --pushpin-path provided, attempting to find 'pushpin' in your PATH...")
686+
text.Info(out, "No --pushpin-path provided, attempting to find 'pushpin' in your PATH...")
687687
}
688688
pushpinRunnerBinPath, err = exec.LookPath("pushpin")
689689
if err != nil {
@@ -694,7 +694,7 @@ func (c *ServeCommand) GetPushpinRunner(out io.Writer) (bin string, err error) {
694694
}
695695

696696
if c.Globals.Verbose() {
697-
text.Output(out, "DEBUG: Found Pushpin runner via $PATH lookup: %s", pushpinRunnerBinPath)
697+
text.Info(out, "Found Pushpin runner via $PATH lookup: %s", pushpinRunnerBinPath)
698698
}
699699
return filepath.Abs(pushpinRunnerBinPath)
700700
}
@@ -812,7 +812,7 @@ func (c *pushpinContext) buildPushpinConf() string {
812812
// command line and/or fastly.toml. The cleanup function on the returned pushpinContext
813813
// needs to eventually be called by the caller to shut down Pushpin.
814814
func (c *ServeCommand) startPushpin(spinner text.Spinner, out io.Writer) (pushpinContext, error) {
815-
text.Output(out, "%s: %s", text.BoldYellow("EXPERIMENTAL"), "Enabling Pushpin support for local testing of Fanout.")
815+
text.Info(out, "Enabling experimental Pushpin support for local testing of Fanout.")
816816

817817
pushpinCtx := pushpinContext{}
818818

@@ -863,7 +863,7 @@ func (c *ServeCommand) startPushpin(spinner text.Spinner, out io.Writer) (pushpi
863863
if err != nil {
864864
return pushpinCtx, err
865865
}
866-
msg := "Running local Pushpin"
866+
msg := "Starting Pushpin"
867867
spinner.Message(msg + "...")
868868

869869
spinner.StopMessage(msg)
@@ -1007,7 +1007,7 @@ func (c *ServeCommand) startPushpin(spinner text.Spinner, out io.Writer) (pushpi
10071007
}
10081008
}
10091009

1010-
text.Success(out, "Local Pushpin started.")
1010+
text.Success(out, "Pushpin started.")
10111011
text.Break(out)
10121012

10131013
return pushpinCtx, nil

0 commit comments

Comments
 (0)