breaking: remove assemblyscript (#1001)

* remove: assemblyscript

Author: Integralist

.goreleaser.yml

@@ -72,11 +72,9 @@ archives:
     <<: *archive_defaults
     wrap_in_directory: false
     format: zip
-
 # https://goreleaser.com/customization/aur/
 aurs:
-  -
-    homepage: "https://github.com/fastly/cli"
+  - homepage: "https://github.com/fastly/cli"
     description: "A CLI for interacting with the Fastly platform"
     maintainers:
       - 'oss@fastly.com'
@@ -182,6 +180,6 @@ changelog:
 #       - --label=created={{ time "2006-01-02T15:04:05Z07:00" }}
 #       - --label=revision={{ .FullCommit }}
 #       - --label=licenses=Apache-2.0
-#   dockerfile: Dockerfile-assemblyscript
+#   dockerfile: Dockerfile-node
 # - <<: *build_opts
 #   dockerfile: Dockerfile-rust

CHANGELOG.md

@@ -10,6 +10,8 @@
   [#1419](https://github.com/fastly/cli/pull/1419)
 - breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi [#1382](https://github.com/fastly/cli/pull/1382)
 
+- breaking(language.assemblyscript): Remove support for AssemblyScript [#1001](https://github.com/fastly/cli/pull/1001/files)
+
 **Enhancements:**
 
 - fix(compute/init): Updates for renamed TypeScript default starter kit

TESTING.md

@@ -29,9 +29,8 @@ Some integration tests aren't run outside of the CI environment, to enable these
 The available environment variables are:
 
 - `TEST_COMPUTE_INIT`: runs `TestInit`.
-- `TEST_COMPUTE_BUILD`: runs `TestBuildRust`, `TestBuildAssemblyScript` and `TestBuildJavaScript`.
+- `TEST_COMPUTE_BUILD`: runs `TestBuildRust`, `TestBuildJavaScript`, `TestBuildGo`.
 - `TEST_COMPUTE_BUILD_RUST`: runs `TestBuildRust`.
-- `TEST_COMPUTE_BUILD_ASSEMBLYSCRIPT`: runs `TestBuildAssemblyScript`.
 - `TEST_COMPUTE_BUILD_JAVASCRIPT`: runs `TestBuildJavaScript`.
 - `TEST_COMPUTE_DEPLOY`: runs `TestDeploy`.
 

pkg/commands/compute/build.go

@@ -696,12 +696,6 @@ func identifyToolchain(c *BuildCommand) (string, error) {
 func language(toolchain, manifestFilename string, c *BuildCommand, in io.Reader, out io.Writer, spinner text.Spinner) (*Language, error) {
 	var language *Language
 	switch toolchain {
-	case "assemblyscript":
-		language = NewLanguage(&LanguageOptions{
-			Name:            "assemblyscript",
-			SourceDirectory: AsSourceDirectory,
-			Toolchain:       NewAssemblyScript(c, in, manifestFilename, out, spinner),
-		})
 	case "go":
 		language = NewLanguage(&LanguageOptions{
 			Name:            "go",

pkg/commands/compute/build_test.go

@@ -668,201 +668,6 @@ func TestBuildJavaScript(t *testing.T) {
 	}
 }
 
-func TestBuildAssemblyScript(t *testing.T) {
-	if os.Getenv("TEST_COMPUTE_BUILD_ASSEMBLYSCRIPT") == "" && os.Getenv("TEST_COMPUTE_BUILD") == "" {
-		t.Log("skipping test")
-		t.Skip("Set TEST_COMPUTE_BUILD to run this test")
-	}
-
-	args := testutil.SplitArgs
-
-	scenarios := []struct {
-		name                 string
-		args                 []string
-		fastlyManifest       string
-		wantError            string
-		wantRemediationError string
-		wantOutput           []string
-		npmInstall           bool
-	}{
-		{
-			name:                 "no fastly.toml manifest",
-			args:                 args("compute build"),
-			wantError:            "error reading fastly.toml",
-			wantRemediationError: "Run `fastly compute init` to ensure a correctly configured manifest.",
-		},
-		{
-			name: "empty language",
-			args: args("compute build"),
-			fastlyManifest: `
-			manifest_version = 2
-			name = "test"`,
-			wantError: "language cannot be empty, please provide a language",
-		},
-		{
-			name: "unknown language",
-			args: args("compute build"),
-			fastlyManifest: `
-			manifest_version = 2
-			name = "test"
-			language = "foobar"`,
-			wantError: "unsupported language foobar",
-		},
-		// The following test validates that the project compiles successfully even
-		// though the fastly.toml manifest has no build script. There should be a
-		// default build script inserted.
-		//
-		// NOTE: This test passes --verbose so we can validate specific outputs.
-		{
-			name: "build script inserted dynamically when missing",
-			args: args("compute build --verbose"),
-			fastlyManifest: `
-			manifest_version = 2
-			name = "test"
-      language = "assemblyscript"`,
-			wantOutput: []string{
-				"No [scripts.build] found in fastly.toml.", // requires --verbose
-				"The following default build command for",
-				"npm exec -- asc",
-			},
-		},
-		{
-			name: "build error",
-			args: args("compute build"),
-			fastlyManifest: `
-			manifest_version = 2
-			name = "test"
-			language = "assemblyscript"
-
-      [scripts]
-      build = "echo no compilation happening"`,
-			wantRemediationError: compute.DefaultBuildErrorRemediation,
-		},
-		// NOTE: This test passes --verbose so we can validate specific outputs.
-		{
-			name: "successful build",
-			args: args("compute build --verbose"),
-			fastlyManifest: fmt.Sprintf(`
-			manifest_version = 2
-			name = "test"
-			language = "assemblyscript"
-
-      [scripts]
-      build = "%s"`, compute.AsDefaultBuildCommand),
-			wantOutput: []string{
-				"Creating ./bin directory (for Wasm binary)",
-				"Built package",
-			},
-			npmInstall: true,
-		},
-	}
-	for testcaseIdx := range scenarios {
-		testcase := &scenarios[testcaseIdx]
-		t.Run(testcase.name, func(t *testing.T) {
-			// We're going to chdir to a build environment,
-			// so save the PWD to return to, afterwards.
-			pwd, err := os.Getwd()
-			if err != nil {
-				t.Fatal(err)
-			}
-
-			wasmtoolsBinName := "wasm-tools"
-
-			// Windows was having issues when trying to move a tmpBin file (which
-			// represents the latest binary downloaded from GitHub) to binPath (which
-			// represents the existing binary installed on a user's machine).
-			//
-			// The problem was, for the sake of the tests, I just create one file
-			// `wasmtoolsBinName` and used that for both `tmpBin` and `binPath` and
-			// this works fine on *nix systems. But once Windows did `os.Rename()` and
-			// move tmpBin to binPath it would no longer be able to set permissions on
-			// the binPath because it didn't think the file existed any more. My guess
-			// is that moving a file over itself causes Windows to remove the file.
-			//
-			// So to work around that issue I just create two separate files because
-			// in reality that's what the CLI will be dealing with. I only used one
-			// file for the sake of test case convenience (which ironically became
-			// very INCONVENIENT when the tests started unexpectedly failing on
-			// Windows and caused me a long time debugging).
-			latestDownloaded := wasmtoolsBinName + "-latest-downloaded"
-
-			// Create test environment
-			rootdir := testutil.NewEnv(testutil.EnvOpts{
-				T: t,
-				Copy: []testutil.FileIO{
-					{Src: filepath.Join("testdata", "build", "assemblyscript", "package.json"), Dst: "package.json"},
-					{Src: filepath.Join("testdata", "build", "assemblyscript", "assembly", "index.ts"), Dst: filepath.Join("assembly", "index.ts")},
-				},
-				Write: []testutil.FileIO{
-					{Src: `#!/usr/bin/env bash
-            echo wasm-tools 1.0.4`, Dst: wasmtoolsBinName, Executable: true},
-					{Src: `#!/usr/bin/env bash
-            echo wasm-tools 2.0.0`, Dst: latestDownloaded, Executable: true},
-					{Src: testcase.fastlyManifest, Dst: manifest.Filename},
-				},
-			})
-			defer os.RemoveAll(rootdir)
-			wasmtoolsBinPath := filepath.Join(rootdir, wasmtoolsBinName)
-
-			// Before running the test, chdir into the build environment.
-			// When we're done, chdir back to our original location.
-			// This is so we can reliably copy the testdata/ fixtures.
-			if err := os.Chdir(rootdir); err != nil {
-				t.Fatal(err)
-			}
-			defer func() {
-				_ = os.Chdir(pwd)
-			}()
-
-			// NOTE: We only want to run `npm install` for the success case.
-			if testcase.npmInstall {
-				// gosec flagged this:
-				// G204 (CWE-78): Subprocess launched with variable
-				// Disabling as we control this command.
-				// #nosec
-				// nosemgrep
-				c := exec.Command("npm", "install")
-				c.Stdout = os.Stdout
-				c.Stderr = os.Stderr
-
-				err = c.Run()
-				if err != nil {
-					t.Fatal(err)
-				}
-			}
-
-			var stdout threadsafe.Buffer
-			app.Init = func(_ []string, _ io.Reader) (*global.Data, error) {
-				opts := testutil.MockGlobalData(testcase.args, &stdout)
-				opts.Versioners = global.Versioners{
-					WasmTools: mock.AssetVersioner{
-						AssetVersion:    "1.2.3",
-						BinaryFilename:  wasmtoolsBinName,
-						DownloadOK:      true,
-						DownloadedFile:  latestDownloaded,
-						InstallFilePath: wasmtoolsBinPath, // avoid overwriting developer's actual wasm-tools install
-					},
-				}
-				return opts, nil
-			}
-			err = app.Run(testcase.args, nil)
-
-			t.Log(stdout.String())
-
-			testutil.AssertRemediationErrorContains(t, err, testcase.wantRemediationError)
-
-			// NOTE: Some errors we want to assert only the remediation.
-			// e.g. a 'stat' error isn't the same across operating systems/platforms.
-			if testcase.wantError != "" {
-				testutil.AssertErrorContains(t, err, testcase.wantError)
-			}
-			for _, s := range testcase.wantOutput {
-				testutil.AssertStringContains(t, stdout.String(), s)
-			}
-		})
-	}
-}
-
 // NOTE: TestBuildOther also validates the post_build settings.
 func TestBuildOther(t *testing.T) {
 	args := testutil.SplitArgs

pkg/commands/compute/testdata/build/assemblyscript/assembly/index.ts

@@ -168,10 +168,9 @@ type Profile struct {
 
 // StarterKitLanguages represents language specific starter kits.
 type StarterKitLanguages struct {
-	AssemblyScript []StarterKit `toml:"assemblyscript"`
-	Go             []StarterKit `toml:"go"`
-	JavaScript     []StarterKit `toml:"javascript"`
-	Rust           []StarterKit `toml:"rust"`
+	Go         []StarterKit `toml:"go"`
+	JavaScript []StarterKit `toml:"javascript"`
+	Rust       []StarterKit `toml:"rust"`
 }
 
 // StarterKit represents starter kit specific configuration.