Small refactor

Author: JuanVqz

app/jobs/puzzle_inventory_check_job.rb

@@ -13,13 +13,17 @@ def perform
   private
 
   def send_low_inventory_notification(count)
+    channel_id = ENV["SHIELD_NOTIFICATIONS_CHANNEL"]
+    return Rails.logger.warn("SHIELD_NOTIFICATIONS_CHANNEL is not configured, skipping low inventory notification") unless channel_id
+
     notification_message = SlackClient::Messages::LowPuzzleInventoryNotification.new(count).create
-    send_message(notification_message, channel_id: ENV.fetch("SHIELD_NOTIFICATIONS_CHANNEL", nil))
+    send_message(notification_message, channel_id: channel_id)
   end
 
   def send_message(message, channel_id:)
     SlackClient::Client.instance.chat_postMessage(channel: channel_id, blocks: message)
   rescue Slack::Web::Api::Errors::SlackError => e
+    Sentry.capture_exception(e)
     Rails.logger.error "Failed to send Slack message: #{e.message} #{e.response_metadata}"
   end
 end

test/jobs/puzzle_inventory_check_job_test.rb

@@ -3,6 +3,7 @@
 class PuzzleInventoryCheckJobTest < ActiveJob::TestCase
   setup do
     Puzzle.approved.where(sent_at: nil).delete_all
+    ENV["SHIELD_NOTIFICATIONS_CHANNEL"] = "test-channel"
   end
 
   test "sends notification when fewer than 5 approved unsent puzzles exist" do