Skip to content

Commit 60b5719

Browse files
febus982claude
andcommitted
Remove unnecessary partial wrapper in order_by registry
The partial() wrapper was not needed since asc and desc can be referenced directly as callables. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 112c0a5 commit 60b5719

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

sqlalchemy_bind_manager/_repository/base_repository.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@
1919
# DEALINGS IN THE SOFTWARE.
2020

2121
from abc import ABC
22-
from functools import partial
2322
from typing import (
2423
Any,
25-
Callable,
2624
Dict,
2725
Generic,
2826
Iterable,
@@ -131,9 +129,9 @@ def _filter_order_by(
131129
:param order_by: a list of columns, or tuples (column, direction)
132130
:return: The filtered query
133131
"""
134-
_partial_registry: Dict[Literal["asc", "desc"], Callable] = {
135-
"desc": partial(desc),
136-
"asc": partial(asc),
132+
_order_funcs: Dict[Literal["asc", "desc"], type] = {
133+
"desc": desc,
134+
"asc": asc,
137135
}
138136

139137
for value in order_by:
@@ -143,7 +141,7 @@ def _filter_order_by(
143141
else:
144142
self._validate_mapped_property(value[0])
145143
stmt = stmt.order_by(
146-
_partial_registry[value[1]](getattr(self._model, value[0]))
144+
_order_funcs[value[1]](getattr(self._model, value[0]))
147145
)
148146

149147
return stmt

0 commit comments

Comments
 (0)