Skip to content

Commit 3e21d58

Browse files
committed
chore: remove loading Spinner
1 parent becb1b1 commit 3e21d58

5 files changed

Lines changed: 6 additions & 56 deletions

File tree

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/AuthProvider.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import React, {
99
} from 'react';
1010

1111
import { AuthMode, createFetchWithAuth } from './fetchWithAuth';
12-
import LoadingSpinner from './components/LoadingSpinner';
1312
import { usePreviousSignIn } from './hooks/usePreviousSignIn';
1413
import {
1514
AuthenticatorTransportFuture,
@@ -42,6 +41,7 @@ export interface AuthContextType {
4241
credentials: Credential[];
4342
updateCredential: (credential: Credential) => Promise<Credential>;
4443
deleteCredential: (credentialId: string) => Promise<void>;
44+
loading: boolean;
4545
}
4646

4747
export interface Credential {
@@ -136,6 +136,7 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({
136136
const hasRole = (role: string) => user?.roles?.includes(role);
137137

138138
const validateToken = async () => {
139+
setLoading(true);
139140
try {
140141
const response = await fetchWithAuth(`users/me`, {
141142
method: 'GET',
@@ -197,19 +198,12 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({
197198
}
198199
}, [user, isAuthenticated, markSignedIn]);
199200

200-
if (loading) {
201-
return (
202-
<div className="min-h-screen flex items-center justify-center bg-gray-100">
203-
<LoadingSpinner />;
204-
</div>
205-
);
206-
}
207-
208201
return (
209202
<AuthContext.Provider
210203
value={{
211204
user,
212205
logout,
206+
loading,
213207
deleteUser,
214208
isAuthenticated,
215209
hasRole,

src/components/LoadingSpinner.tsx

Lines changed: 0 additions & 14 deletions
This file was deleted.

tests/authProvider.test.tsx

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { AuthProvider, useAuth } from '../src/AuthProvider';
33
import { createFetchWithAuth } from '../src/fetchWithAuth';
44

55
jest.mock('../src/fetchWithAuth');
6-
jest.mock('../src/components/LoadingSpinner', () => () => <div>Loading...</div>);
76
jest.mock('@/context/InternalAuthContext', () => ({
87
InternalAuthProvider: ({ children }: any) => <div>{children}</div>,
98
}));
@@ -31,17 +30,6 @@ describe('AuthProvider', () => {
3130
jest.clearAllMocks();
3231
});
3332

34-
it('renders loading spinner initially', async () => {
35-
await act(async () => {
36-
render(
37-
<AuthProvider apiHost={apiHost}>
38-
<div>Child</div>
39-
</AuthProvider>
40-
);
41-
});
42-
expect(screen.getByText('Child')).toBeInTheDocument();
43-
});
44-
4533
it('loads user and token successfully', async () => {
4634
mockFetchWithAuthImpl.mockResolvedValueOnce({
4735
ok: true,

tests/loadingSpinner.test.tsx

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)