Skip to content

Commit a7abb95

Browse files
committed
removed extra comments per change requested
1 parent e5b44fa commit a7abb95

2 files changed

Lines changed: 3 additions & 61 deletions

File tree

src/AuthProvider.tsx

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -108,18 +108,8 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({
108108
method: 'POST',
109109
body: JSON.stringify({ identifier, passkeyAvailable }),
110110
});
111-
if (!passkeyAvailable) {
112-
// setShowFallbackOptions(true);
113-
return response;
114-
}
115111

116-
try {
117-
return response;
118-
} catch (err) {
119-
console.error('Passkey login failed', err);
120-
// setShowFallbackOptions(true);
121-
return response;
122-
}
112+
return response;
123113
};
124114

125115
const handlePasskeyLogin = async () => {
@@ -144,23 +134,16 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({
144134

145135
if (verificationResult.message === 'Success') {
146136
if (verificationResult.mfaLogin) {
147-
// navigate('/mfaLogin');
148-
// need to return "Success"
149-
// can just return a bool, if success true otherwise false anywhere else
150137
return true;
151138
}
152139
await validateToken();
153-
// navigate('/');
154-
// need to return validateToken response/message
155140
return false;
156141
} else {
157142
console.error('Passkey login failed:', verificationResult.message);
158-
// return failed
159143
return false;
160144
}
161145
} catch (error) {
162146
console.error('Passkey login error:', error);
163-
// throw error?
164147
return false;
165148
}
166149
};

src/views/Login.tsx

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -63,47 +63,6 @@ const Login: React.FC = () => {
6363
return isValidEmail(email) && isValidPhoneNumber(phone);
6464
};
6565

66-
// const handlePasskeyLogin = async () => {
67-
// try {
68-
// const response = await fetchWithAuth(`/webAuthn/login/start`, {
69-
// method: 'POST',
70-
// });
71-
72-
// if (!response.ok) {
73-
// console.error('Something went wrong getting webauthn options');
74-
// return;
75-
// }
76-
77-
// const options = await response.json();
78-
// const credential = await startAuthentication({ optionsJSON: options });
79-
80-
// const verificationResponse = await fetchWithAuth(`/webAuthn/login/finish`, {
81-
// method: 'POST',
82-
// body: JSON.stringify({ assertionResponse: credential }),
83-
// });
84-
85-
// if (!verificationResponse.ok) {
86-
// console.error('Failed to verify passkey');
87-
// }
88-
89-
// const verificationResult = await verificationResponse.json();
90-
91-
// if (verificationResult.message === 'Success') {
92-
// if (verificationResult.mfaLogin) {
93-
// navigate('/mfaLogin');
94-
// return;
95-
// }
96-
// await validateToken();
97-
// navigate('/');
98-
// return;
99-
// } else {
100-
// console.error('Passkey login failed:', verificationResult.message);
101-
// }
102-
// } catch (error) {
103-
// console.error('Passkey login error:', error);
104-
// }
105-
// };
106-
10766
const register = async () => {
10867
setFormErrors('');
10968

@@ -175,9 +134,9 @@ const Login: React.FC = () => {
175134
e.preventDefault();
176135

177136
if (mode === 'login') {
178-
login(identifier, passkeyAvailable);
137+
const loginRes = await login(identifier, passkeyAvailable);
179138

180-
if (passkeyAvailable) {
139+
if (loginRes.ok && passkeyAvailable) {
181140
const passkeyResult = await handlePasskeyLogin();
182141
if (passkeyResult) {
183142
navigate('/');

0 commit comments

Comments
 (0)