Removed unnecessary Get-Variable calls which caused issues

ffeldhaus · ffeldhaus · commit caa6b1f552f3 · 2018-07-04T12:28:25.000+02:00
diff --git a/src/OnCommand-Insight.psm1 b/src/OnCommand-Insight.psm1
@@ -7001,11 +7001,11 @@ function Global:Get-OciDatastores {
             $Uri += '?'
             $Separator = ''
             if ($limit) {
-                $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"
+                $Uri += "$($Separator)limit=$limit"
                 $Separator = '&'
             }
             if ($limit -and $offset) {
-                $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"
+                $Uri += "$($Separator)offset=$offset"
                 $Separator = '&'
             }
             if ($expand) {
@@ -9180,11 +9180,11 @@ function Global:Get-OciFabrics {
                 $Separator = '&'
             }
             if ($limit) {
-                $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"
+                $Uri += "$($Separator)limit=$limit"
                 $Separator = '&'
             }
             if ($limit -and $offset) {
-                $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"
+                $Uri += "$($Separator)offset=$offset"
                 $Separator = '&'
             }
             if ($expand) {
@@ -9636,15 +9636,15 @@ function Global:Get-OciPortsByFabric {
                 $Separator = '&'
             }
             if ($sort) {
-                $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"
+                $Uri += "$($Separator)sort=$sort"
                 $Separator = '&'
             }
             if ($limit) {
-                $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"
+                $Uri += "$($Separator)limit=$limit"
                 $Separator = '&'
             }
             if ($limit -and $offset) {
-                $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"
+                $Uri += "$($Separator)offset=$offset"
                 $Separator = '&'
             }
             if ($expand) {
@@ -10634,15 +10634,15 @@ function Global:Get-OciHosts {
                 $Separator = '&'
             }
             if ($sort) {
-                $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"
+                $Uri += "$($Separator)sort=$sort"
                 $Separator = '&'
             }
             if ($limit) {
-                $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"
+                $Uri += "$($Separator)limit=$limit"
                 $Separator = '&'
             }
             if ($limit -and $offset) {
-                $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"
+                $Uri += "$($Separator)offset=$offset"
                 $Separator = '&'
             }
             if ($expand) {
@@ -21190,15 +21190,15 @@ function Global:Get-OciStorages {
             $Separator = '&'
         }
         if ($sort) {
-            $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"
+            $Uri += "$($Separator)sort=$sort"
             $Separator = '&'
         }
         if ($limit) {
-            $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"
+            $Uri += "$($Separator)limit=$limit"
             $Separator = '&'
         }
         if ($limit -and $offset) {
-            $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"
+            $Uri += "$($Separator)offset=$offset"
             $Separator = '&'
         }
         if ($expand) {
@@ -23816,15 +23816,15 @@ function Global:Get-OciSwitches {
                 $Separator = '&'
             }
             if ($sort) {
-                $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"
+                $Uri += "$($Separator)sort=$sort"
                 $Separator = '&'
             }
             if ($limit) {
-                $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"
+                $Uri += "$($Separator)limit=$limit"
                 $Separator = '&'
             }
             if ($limit -and $offset) {
-                $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"
+                $Uri += "$($Separator)offset=$offset"
                 $Separator = '&'
             }
             if ($expand) {
@@ -25337,15 +25337,15 @@ function Global:Get-OciVirtualMachines {
                 $Separator = '&'
             }
             if ($sort) {
-                $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"
+                $Uri += "$($Separator)sort=$sort"
                 $Separator = '&'
             }
             if ($limit) {
-                $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"
+                $Uri += "$($Separator)limit=$limit"
                 $Separator = '&'
             }
             if ($limit -and $offset) {
-                $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"
+                $Uri += "$($Separator)offset=$offset"
                 $Separator = '&'
             }
             if ($expand) {

Original file line number	Diff line number	Diff line change
`@@ -7001,11 +7001,11 @@ function Global:Get-OciDatastores {`
`7001`	`7001`	`$Uri += '?'`
`7002`	`7002`	`$Separator = ''`
`7003`	`7003`	`if ($limit) {`
`7004`		`- $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"`
	`7004`	`+ $Uri += "$($Separator)limit=$limit"`
`7005`	`7005`	`$Separator = '&'`
`7006`	`7006`	`}`
`7007`	`7007`	`if ($limit -and $offset) {`
`7008`		`- $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"`
	`7008`	`+ $Uri += "$($Separator)offset=$offset"`
`7009`	`7009`	`$Separator = '&'`
`7010`	`7010`	`}`
`7011`	`7011`	`if ($expand) {`
`@@ -9180,11 +9180,11 @@ function Global:Get-OciFabrics {`
`9180`	`9180`	`$Separator = '&'`
`9181`	`9181`	`}`
`9182`	`9182`	`if ($limit) {`
`9183`		`- $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"`
	`9183`	`+ $Uri += "$($Separator)limit=$limit"`
`9184`	`9184`	`$Separator = '&'`
`9185`	`9185`	`}`
`9186`	`9186`	`if ($limit -and $offset) {`
`9187`		`- $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"`
	`9187`	`+ $Uri += "$($Separator)offset=$offset"`
`9188`	`9188`	`$Separator = '&'`
`9189`	`9189`	`}`
`9190`	`9190`	`if ($expand) {`
`@@ -9636,15 +9636,15 @@ function Global:Get-OciPortsByFabric {`
`9636`	`9636`	`$Separator = '&'`
`9637`	`9637`	`}`
`9638`	`9638`	`if ($sort) {`
`9639`		`- $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"`
	`9639`	`+ $Uri += "$($Separator)sort=$sort"`
`9640`	`9640`	`$Separator = '&'`
`9641`	`9641`	`}`
`9642`	`9642`	`if ($limit) {`
`9643`		`- $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"`
	`9643`	`+ $Uri += "$($Separator)limit=$limit"`
`9644`	`9644`	`$Separator = '&'`
`9645`	`9645`	`}`
`9646`	`9646`	`if ($limit -and $offset) {`
`9647`		`- $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"`
	`9647`	`+ $Uri += "$($Separator)offset=$offset"`
`9648`	`9648`	`$Separator = '&'`
`9649`	`9649`	`}`
`9650`	`9650`	`if ($expand) {`
`@@ -10634,15 +10634,15 @@ function Global:Get-OciHosts {`
`10634`	`10634`	`$Separator = '&'`
`10635`	`10635`	`}`
`10636`	`10636`	`if ($sort) {`
`10637`		`- $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"`
	`10637`	`+ $Uri += "$($Separator)sort=$sort"`
`10638`	`10638`	`$Separator = '&'`
`10639`	`10639`	`}`
`10640`	`10640`	`if ($limit) {`
`10641`		`- $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"`
	`10641`	`+ $Uri += "$($Separator)limit=$limit"`
`10642`	`10642`	`$Separator = '&'`
`10643`	`10643`	`}`
`10644`	`10644`	`if ($limit -and $offset) {`
`10645`		`- $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"`
	`10645`	`+ $Uri += "$($Separator)offset=$offset"`
`10646`	`10646`	`$Separator = '&'`
`10647`	`10647`	`}`
`10648`	`10648`	`if ($expand) {`
`@@ -21190,15 +21190,15 @@ function Global:Get-OciStorages {`
`21190`	`21190`	`$Separator = '&'`
`21191`	`21191`	`}`
`21192`	`21192`	`if ($sort) {`
`21193`		`- $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"`
	`21193`	`+ $Uri += "$($Separator)sort=$sort"`
`21194`	`21194`	`$Separator = '&'`
`21195`	`21195`	`}`
`21196`	`21196`	`if ($limit) {`
`21197`		`- $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"`
	`21197`	`+ $Uri += "$($Separator)limit=$limit"`
`21198`	`21198`	`$Separator = '&'`
`21199`	`21199`	`}`
`21200`	`21200`	`if ($limit -and $offset) {`
`21201`		`- $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"`
	`21201`	`+ $Uri += "$($Separator)offset=$offset"`
`21202`	`21202`	`$Separator = '&'`
`21203`	`21203`	`}`
`21204`	`21204`	`if ($expand) {`
`@@ -23816,15 +23816,15 @@ function Global:Get-OciSwitches {`
`23816`	`23816`	`$Separator = '&'`
`23817`	`23817`	`}`
`23818`	`23818`	`if ($sort) {`
`23819`		`- $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"`
	`23819`	`+ $Uri += "$($Separator)sort=$sort"`
`23820`	`23820`	`$Separator = '&'`
`23821`	`23821`	`}`
`23822`	`23822`	`if ($limit) {`
`23823`		`- $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"`
	`23823`	`+ $Uri += "$($Separator)limit=$limit"`
`23824`	`23824`	`$Separator = '&'`
`23825`	`23825`	`}`
`23826`	`23826`	`if ($limit -and $offset) {`
`23827`		`- $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"`
	`23827`	`+ $Uri += "$($Separator)offset=$offset"`
`23828`	`23828`	`$Separator = '&'`
`23829`	`23829`	`}`
`23830`	`23830`	`if ($expand) {`
`@@ -25337,15 +25337,15 @@ function Global:Get-OciVirtualMachines {`
`25337`	`25337`	`$Separator = '&'`
`25338`	`25338`	`}`
`25339`	`25339`	`if ($sort) {`
`25340`		`- $Uri += "$($Separator)sort=$((Get-Variable 'sort').Value)"`
	`25340`	`+ $Uri += "$($Separator)sort=$sort"`
`25341`	`25341`	`$Separator = '&'`
`25342`	`25342`	`}`
`25343`	`25343`	`if ($limit) {`
`25344`		`- $Uri += "$($Separator)limit=$((Get-Variable 'limit').Value)"`
	`25344`	`+ $Uri += "$($Separator)limit=$limit"`
`25345`	`25345`	`$Separator = '&'`
`25346`	`25346`	`}`
`25347`	`25347`	`if ($limit -and $offset) {`
`25348`		`- $Uri += "$($Separator)offset=$((Get-Variable 'offset').Value)"`
	`25348`	`+ $Uri += "$($Separator)offset=$offset"`
`25349`	`25349`	`$Separator = '&'`
`25350`	`25350`	`}`
`25351`	`25351`	`if ($expand) {`