Skip to content

Commit 5130486

Browse files
committed
make eslint happy
1 parent 16c9b8b commit 5130486

4 files changed

Lines changed: 12 additions & 14 deletions

File tree

lib/hook.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ module.exports = function (cfg, wrapper, callback) {
2222
if (!orig) return;
2323
obj[method] = function () {
2424
var opts = arguments[optionsArgIndex];
25-
var file = typeof opts == 'string' ? opts : opts.filename;
25+
var file = null;
26+
if (opts) {
27+
file = typeof opts == 'string' ? opts : opts.filename;
28+
}
2629
if (file) callback(file);
2730
return orig.apply(this, arguments);
2831
};
@@ -32,12 +35,12 @@ module.exports = function (cfg, wrapper, callback) {
3235
* (Re-)install hooks for all registered file extensions.
3336
*/
3437
function updateHooks() {
35-
for (var ext in require.extensions) {
38+
Object.keys(require.extensions).forEach(function (ext) {
3639
var fn = require.extensions[ext];
37-
if (fn.name !== 'nodeDevHook') {
40+
if (typeof fn === 'function' && fn.name !== 'nodeDevHook') {
3841
require.extensions[ext] = createHook(fn);
3942
}
40-
}
43+
});
4144
}
4245

4346
/**

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "node-dev",
3-
"version": "3.1.1",
3+
"version": "3.1.2",
44
"description": "Restarts your app when files are modified",
55
"keywords": [
66
"restart",
@@ -40,7 +40,8 @@
4040
"devDependencies": {
4141
"coffee-script": "^1.8.0",
4242
"eslint": "^2.0.0",
43-
"eslint-config-airbnb": "^8.0.0",
43+
"eslint-config-airbnb-base": "^3.0.1",
44+
"eslint-plugin-import": "^1.8.1",
4445
"tap": "^5.2.0",
4546
"touch": "^1.0.0"
4647
}

test/fixture/uncaughtExceptionHandler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ process.on('uncaughtException', function (e) {
44
}, 100);
55
});
66

7-
/* eslint-disable no-undef */
7+
// eslint-disable-next-line no-undef
88
foo(); // undefined / throws exception

test/index.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,15 @@
1-
var fs = require('fs');
21
var child = require('child_process');
32
var test = require('tap').test;
43
var touch = require('touch');
54

65
var dir = __dirname + '/fixture';
76
var bin = __dirname + '/../bin/node-dev';
87
var msgFile = dir + '/message.js';
9-
var ignoredFile = dir + '/ignoredModule.js';
10-
11-
12-
// Constants
13-
var MESSAGE = fs.readFileSync(msgFile).toString();
148

159
// Helpers
1610
function touchFile(file) {
1711
return function () {
18-
touch.sync(file ? file : msgFile);
12+
touch.sync(file || msgFile);
1913
};
2014
}
2115

0 commit comments

Comments
 (0)