Skip to content

Commit ecac5fe

Browse files
authored
Use QueryField Component (#24)
* switch to using the QueryField component instead of textarea
1 parent aaa8f78 commit ecac5fe

4 files changed

Lines changed: 31 additions & 33 deletions

File tree

dist/module.js

Lines changed: 23 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/module.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
],
2222
"screenshots": [],
2323
"version": "1.1.2",
24-
"updated": "2020-06-19"
24+
"updated": "2020-06-30"
2525
},
2626

2727
"dependencies": {

src/QueryEditor.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import defaults from 'lodash/defaults';
22

33
import React, { PureComponent, ChangeEvent } from 'react';
44
import { QueryEditorProps } from '@grafana/data';
5-
import { LegacyForms } from '@grafana/ui';
5+
import { LegacyForms, QueryField } from '@grafana/ui';
66
import { DataSource } from './DataSource';
77
import { MyQuery, MyDataSourceOptions, defaultQuery } from './types';
88

@@ -13,9 +13,11 @@ interface State {}
1313
export class QueryEditor extends PureComponent<Props, State> {
1414
onComponentDidMount() {}
1515

16-
onQueryTextChange = (event: ChangeEvent<HTMLTextAreaElement>) => {
16+
onChangeQuery = (value: string, override?: boolean) => {
1717
const { onChange, query } = this.props;
18-
onChange({ ...query, queryText: event.target.value });
18+
if (onChange) {
19+
onChange({ ...query, queryText: value });
20+
}
1921
};
2022

2123
onDataPathTextChange = (event: ChangeEvent<HTMLInputElement>) => {
@@ -38,7 +40,7 @@ export class QueryEditor extends PureComponent<Props, State> {
3840

3941
return (
4042
<>
41-
<textarea value={queryText || ''} onChange={this.onQueryTextChange} className="gf-form-input" rows={10} />
43+
<QueryField query={queryText || ''} onChange={this.onChangeQuery} portalOrigin="graphQL" />
4244
<div className="gf-form">
4345
<LegacyForms.FormField
4446
labelWidth={8}

0 commit comments

Comments
 (0)