Revert "Code Quality: Added back settings tests (#18311)"

This reverts commit ec9713d.

Author: yair100

tests/Files.InteractionTests/Helper/AxeHelper.cs

@@ -24,17 +24,9 @@ internal static void InitializeAxe()
 			AccessibilityScanner = ScannerFactory.CreateScanner(config);
 		}
 
-		public static void AssertNoAccessibilityErrors(Func<ScanResult, bool>? ignoredIssueFilter = null)
+		public static void AssertNoAccessibilityErrors()
 		{
-			var testResult = AccessibilityScanner
-				.Scan(null)
-				.WindowScanOutputs
-				.SelectMany(output => output.Errors)
-				.Where(error => error.Rule.ID != RuleId.BoundingRectangleNotNull);
-
-			if (ignoredIssueFilter is not null)
-				testResult = testResult.Where(error => !ignoredIssueFilter(error));
-
+			var testResult = AccessibilityScanner.Scan(null).WindowScanOutputs.SelectMany(output => output.Errors).Where(error => error.Rule.ID != RuleId.BoundingRectangleNotNull);
 			if (testResult.Any())
 			{
 				StringBuilder sb = new();
@@ -48,17 +40,6 @@ public static void AssertNoAccessibilityErrors(Func<ScanResult, bool>? ignoredIs
 			}
 		}
 
-		public static bool IsCommunityToolkitWindowsIssue430(ScanResult result)
-		{
-			// CommunityToolkit/Windows#430: SettingsExpander internal controls can report
-			// duplicate Name + LocalizedControlType until the toolkit fix lands.
-			var description = result.Rule.Description;
-			return !string.IsNullOrWhiteSpace(description)
-				&& description.Contains("LocalizedControlType", StringComparison.OrdinalIgnoreCase)
-				&& description.Contains("Name", StringComparison.OrdinalIgnoreCase)
-				&& description.Contains("same", StringComparison.OrdinalIgnoreCase);
-		}
-
 		private static string BuildAssertMessage(ScanResult result)
 		{
 			// e.g., "Element Button(50000) violated rule 'The Name property of a focusable element must not be null.'."

tests/Files.InteractionTests/Tests/SettingsTests.cs

@@ -19,47 +19,48 @@ public void Cleanup()
 		[TestMethod]
 		public void VerifySettingsAreAccessible()
 		{
-			TestHelper.InvokeButtonById("SettingsButton");
-			AxeHelper.AssertNoAccessibilityErrors(AxeHelper.IsCommunityToolkitWindowsIssue430);
+			// TODO uncomment after https://github.com/CommunityToolkit/Windows/issues/430 is resolved
+			//TestHelper.InvokeButtonById("SettingsButton");
+			//AxeHelper.AssertNoAccessibilityErrors();
 
-			var settingsItems = new string[]
-			{
-				"SettingsItemGeneral",
-				"SettingsItemAppearance",
-				"SettingsItemLayout",
-				"SettingsItemFolders",
-				"SettingsItemActions",
-				"SettingsItemTags",
-				"SettingsItemDevTools",
-				"SettingsItemAdvanced",
-				"SettingsItemAbout"
-			};
+			//var settingsItems = new string[]
+			//{
+			//	"SettingsItemGeneral",
+			//	"SettingsItemAppearance",
+			//	//"SettingsItemLayout", TODO find workaround for the "Group by" setting block issue
+			//	"SettingsItemFolders",
+			//	"SettingsItemActions",
+			//	"SettingsItemTags",
+			//	"SettingsItemDevTools",
+			//	"SettingsItemAdvanced",
+			//	"SettingsItemAbout"
+			//};
 
-			foreach (var item in settingsItems)
-			{
-				for (int i = 0; i < 5; i++)
-				{
-					try
-					{
-						System.Console.WriteLine("Invoking button:" + item);
-						System.Threading.Thread.Sleep(3000);
-						TestHelper.InvokeButtonById(item);
-						i = 1000;
-					}
-					catch (System.Exception exc)
-					{
-						System.Console.WriteLine("Failed to invoke the button:" + item + " with exception" + exc.Message);
-					}
+			//foreach (var item in settingsItems)
+			//{
+			//	for (int i = 0; i < 5; i++)
+			//	{
+			//		try
+			//		{
+			//			Console.WriteLine("Invoking button:" + item);
+			//			Thread.Sleep(3000);
+			//			TestHelper.InvokeButtonById(item);
+			//			i = 1000;
+			//		}
+			//		catch (Exception exc)
+			//		{
+			//			Console.WriteLine("Failed to invoke the button:" + item + " with exception" + exc.Message);
+			//		}
 
-				}
-				try
-				{
-					// First run can be flaky due to external components
-					AxeHelper.AssertNoAccessibilityErrors(AxeHelper.IsCommunityToolkitWindowsIssue430);
-				}
-				catch (System.Exception) { }
-				AxeHelper.AssertNoAccessibilityErrors(AxeHelper.IsCommunityToolkitWindowsIssue430);
-			}
+			//	}
+			//	try
+			//	{
+			//		// First run can be flaky due to external components
+			//		AxeHelper.AssertNoAccessibilityErrors();
+			//	}
+			//	catch (System.Exception) { }
+			//	AxeHelper.AssertNoAccessibilityErrors();
+			//}
 		}
 	}
 }