Skip to content

Commit 503198c

Browse files
authored
Merge branch 'main' into renovate/major-guice.version
2 parents 78da1bd + 0570c9a commit 503198c

4 files changed

Lines changed: 15 additions & 19 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![FINOS - Incubating](https://cdn.jsdelivr.net/gh/finos/contrib-toolbox@master/images/badge-incubating.svg)](https://community.finos.org/docs/governance/Software-Projects/stages/incubating)[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/10725/badge)](https://www.bestpractices.dev/projects/10725)[![Maven CI](https://github.com/finos/rune-python-generator/actions/workflows/cve-scanning.yml/badge.svg)](https://github.com/finos/rune-python-generator/actions/workflows/cve-scanning.yml)
1+
[![FINOS - Incubating](https://cdn.jsdelivr.net/gh/finos/contrib-toolbox@master/images/badge-incubating.svg)](https://community.finos.org/docs/governance/Software-Projects/stages/incubating)[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/10725/badge)](https://www.bestpractices.dev/projects/10725)[![Maven CI](https://github.com/finos/rune-python-generator/actions/workflows/scan-cve.yml/badge.svg)](https://github.com/finos/rune-python-generator/actions/workflows/scan-cve.yml)
22

33
<img align="right" width="15%" alt="FINOS" src="https://www.finos.org/hubfs/FINOS/finos-logo/FINOS_Icon_Wordmark_Name_RGB_horizontal.png">
44

pom.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,33 +71,33 @@
7171
<java.enforced.version>[21,22)</java.enforced.version>
7272
<maven.compiler.release>21</maven.compiler.release>
7373

74-
<apache.commons.lang.version>3.13.0</apache.commons.lang.version>
74+
<apache.commons.lang.version>3.19.0</apache.commons.lang.version>
7575
<apache.commons.text.version>1.11.0</apache.commons.text.version>
76-
<commons-io.version>2.20.0</commons-io.version>
76+
<commons-io.version>2.21.0</commons-io.version>
7777
<guava.version>33.3.1-jre</guava.version>
7878

7979
<!-- Release -->
8080
<gpg.keyname>configured-by-release-profile</gpg.keyname>
8181
<repoServerHost>s01.oss.sonatype.org</repoServerHost>
8282
<stagingTimeoutInMinutes>20</stagingTimeoutInMinutes>
8383

84-
<rosetta.dsl.version>9.68.0</rosetta.dsl.version>
84+
<rosetta.dsl.version>9.70.0</rosetta.dsl.version>
8585

8686
<xtext.version>2.38.0</xtext.version>
8787
<guice.version>7.0.0</guice.version>
8888

89-
<slf4j.version>2.0.13</slf4j.version>
90-
<logback.version>1.5.6</logback.version>
89+
<slf4j.version>2.0.17</slf4j.version>
90+
<logback.version>1.5.21</logback.version>
9191

9292
<!-- test -->
93-
<junit.version>6.0.0</junit.version>
93+
<junit.version>6.0.1</junit.version>
9494
<hamcrest.version>3.0</hamcrest.version>
9595

9696
<!-- plugin -->
97-
<maven-enforcer-plugin.version>3.6.1</maven-enforcer-plugin.version>
97+
<maven-enforcer-plugin.version>3.6.2</maven-enforcer-plugin.version>
9898
<maven-checkstyle-plugin.version>3.6.0</maven-checkstyle-plugin.version>
9999
<maven-clean-plugin.version>3.5.0</maven-clean-plugin.version>
100-
<maven-compiler-plugin.version>3.14.0</maven-compiler-plugin.version>
100+
<maven-compiler-plugin.version>3.14.1</maven-compiler-plugin.version>
101101
<maven-surefire-plugin.version>3.5.4</maven-surefire-plugin.version>
102102
<maven-jar-plugin.version>3.1.1</maven-jar-plugin.version>
103103
<maven-install-plugin.version>3.1.4</maven-install-plugin.version>

src/main/java/com/regnosys/rosetta/generator/python/expressions/PythonExpressionGenerator.xtend

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import com.regnosys.rosetta.rosetta.expression.RosettaIntLiteral
3232
import com.regnosys.rosetta.rosetta.expression.RosettaNumberLiteral
3333
import com.regnosys.rosetta.rosetta.expression.RosettaOnlyElement
3434
import com.regnosys.rosetta.rosetta.expression.RosettaOnlyExistsExpression
35-
import com.regnosys.rosetta.rosetta.expression.RosettaReference
3635
import com.regnosys.rosetta.rosetta.expression.RosettaStringLiteral
3736
import com.regnosys.rosetta.rosetta.expression.RosettaSymbolReference
3837
import com.regnosys.rosetta.rosetta.expression.SortOperation
@@ -109,7 +108,8 @@ class PythonExpressionGenerator {
109108
RosettaFeatureCall: generateFeatureCall(expr, ifLevel, isLambda)
110109
RosettaOnlyElement: '''rune_get_only_element(«generateExpression(expr.argument, ifLevel, isLambda)»)'''
111110
RosettaOnlyExistsExpression: '''rune_check_one_of(self, «generateExpression(expr.getArgs().get(0), ifLevel, isLambda)»)'''
112-
RosettaReference: generateReference(expr, ifLevel, isLambda)
111+
RosettaSymbolReference: generateSymbolReference(expr, ifLevel, isLambda)
112+
RosettaImplicitVariable: generateImplicitVariable(expr, ifLevel, isLambda)
113113
default:{
114114
throw new UnsupportedOperationException("Unsupported expression type of " + expr?.class?.simpleName)
115115
}
@@ -260,12 +260,8 @@ class PythonExpressionGenerator {
260260
return _builder.toString
261261
}
262262

263-
264-
private def String generateReference(RosettaReference expr, int ifLevel, boolean isLambda) {
265-
switch (expr) {
266-
RosettaImplicitVariable: '''«expr.name»'''
267-
RosettaSymbolReference: generateSymbolReference(expr, ifLevel, isLambda)
268-
}
263+
private def String generateImplicitVariable(RosettaImplicitVariable expr, int ifLevel, boolean isLambda) {
264+
'''«expr.name»'''
269265
}
270266

271267
private def String generateSymbolReference(RosettaSymbolReference expr, int ifLevel, boolean isLambda) {

src/main/java/com/regnosys/rosetta/generator/python/func/FunctionDependencyProvider.xtend

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import com.regnosys.rosetta.rosetta.expression.RosettaFeatureCall
1616
import com.regnosys.rosetta.rosetta.expression.RosettaFunctionalOperation
1717
import com.regnosys.rosetta.rosetta.expression.RosettaLiteral
1818
import com.regnosys.rosetta.rosetta.expression.RosettaOnlyExistsExpression
19-
import com.regnosys.rosetta.rosetta.expression.RosettaReference
19+
import com.regnosys.rosetta.rosetta.expression.RosettaImplicitVariable
2020
import com.regnosys.rosetta.rosetta.expression.RosettaSymbolReference
2121
import com.regnosys.rosetta.rosetta.expression.RosettaUnaryOperation
2222
import com.regnosys.rosetta.rosetta.expression.RosettaDeepFeatureCall
@@ -94,7 +94,7 @@ class FunctionDependencyProvider {
9494
RosettaExternalFunction,
9595
RosettaEnumValueReference,
9696
RosettaLiteral,
97-
RosettaReference,
97+
RosettaImplicitVariable,
9898
RosettaSymbol,
9999
RosettaDeepFeatureCall:
100100
dependencies = newHashSet()

0 commit comments

Comments
 (0)