Skip to content

Commit cf9decd

Browse files
chore: clean up references to finos_cdm and javadoc warnings
1 parent e645c9b commit cf9decd

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

RELEASE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ Three new flags added to the existing CLI. (Issue [#142](https://github.com/fino
6767
| :--- | :--- | :--- |
6868
| `-e` | `--allow-errors` | Continue generating even when validation errors are present |
6969
| `-w` | `--fail-on-warnings` | Treat validation warnings as errors |
70-
| `-n <name>` | `--project-name` | Override the `pyproject.toml` project name (e.g. `finos_cdm`) |
70+
| `-n <name>` | `--project-name` | Override the `pyproject.toml` project name (e.g. `finos-cdm`) |
7171

7272
The `--allow-errors` flag is useful when generating from sources that contain unresolvable cross-namespace references. Models with errors are skipped; all valid models are still generated.
7373

docs/PR.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ This PR delivers comprehensive function and expression generation support
2727
5. **Completion of support for Type Aliases** — type aliases are resolved with flattened naming conventions and collision handling.
2828

2929
6. **CLI improvements**
30-
- `--project-name` flag enables CDM builds with a custom package prefix (e.g. `finos_cdm`)
30+
- `--project-name` flag enables CDM builds with a custom package prefix (e.g. `finos-cdm`)
3131
- Added flags to control the response to Rune parsing errors (`--allow-errors`) and warnings (`--fail-on-warnings`)
3232
- Execution emits exit codes (`0`/`1`)
3333

python-test/cdm-tests/setup/build_cdm.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ CDM_SOURCE_PATH="$MY_PATH/../rosetta"
4646
PYTHON_TARGET_PATH=$PROJECT_ROOT_PATH/target/python-cdm
4747
PYTHON_SETUP_PATH="$MY_PATH/../../env-setup"
4848
JAR_PATH="$PROJECT_ROOT_PATH/target/python-0.0.0.main-SNAPSHOT.jar"
49-
CDM_PROJECT_NAME="finos_cdm"
49+
CDM_PROJECT_NAME="finos-cdm"
5050
CDM_PREFIX="finos"
5151
CDM_VERSION="1.2.3"
5252
cd ${MY_PATH} || error

src/main/java/com/regnosys/rosetta/generator/python/object/PythonAttributeProcessor.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -370,16 +370,16 @@ private CardinalityInfo processCardinality(RAttribute ra) {
370370
/**
371371
* Collects import statements for the attributes of a Data type.
372372
*
373-
* @param rc The Data type whose attributes are inspected.
374-
* @param imports The set to add import statements to.
375-
* @param standaloneClasses The set of fully-qualified names that are standalone.
376-
* @param includeBundledTypes When {@code true} (standalone file context), imports
377-
* are emitted for all Data types including bundled ones.
378-
* When {@code false} (bundle header context), imports are
379-
* only emitted for enums and standalone Data types —
380-
* bundled types must not be imported via their proxy stub
381-
* because that would create a circular import back into
382-
* the bundle itself.
373+
* @param rc The Data type whose attributes are inspected.
374+
* @param imports The set to add import statements to.
375+
* @param context The context containing information about standalone classes and namespace prefixes.
376+
* @param includeBundledTypes When {@code true} (standalone file context), imports
377+
* are emitted for all Data types including bundled ones.
378+
* When {@code false} (bundle header context), imports are
379+
* only emitted for enums and standalone Data types —
380+
* bundled types must not be imported via their proxy stub
381+
* because that would create a circular import back into
382+
* the bundle itself.
383383
*/
384384
public void getImportsFromAttributes(
385385
Data rc,

0 commit comments

Comments
 (0)