use enum for errors

Author: russellwheatley

FirebaseSwiftUI/FirebaseFacebookSwiftUI/Sources/Views/FacebookButtonView.swift

@@ -5,6 +5,11 @@ import FirebaseAuth
 import FirebaseAuthSwiftUI
 import SwiftUI
 
+public enum FacebookError: Error {
+  case accessToken(String)
+  case authenticationToken(String)
+}
+
 @MainActor
 public struct FacebookButtonView {
   @Environment(AuthService.self) private var authService
@@ -82,13 +87,10 @@ public struct FacebookButtonView {
           .credential(withAccessToken: token.tokenString)
         try await authService.signIn(with: credential)
       } else {
-        throw NSError(
-          domain: "FacebookSwiftErrorDomain",
-          code: 1,
-          userInfo: [
-            NSLocalizedDescriptionKey: "Access token has expired or not available. Please sign-in with Facebook before attempting to create a Facebook provider credential",
-          ]
-        )
+        throw FacebookError
+          .accessToken(
+            "Access token has expired or not available. Please sign-in with Facebook before attempting to create a Facebook provider credential"
+          )
       }
     } catch {
       errorMessage = authService.string.localizedErrorMessage(
@@ -105,13 +107,10 @@ public struct FacebookButtonView {
                                                   rawNonce: rawNonce)
         try await authService.signIn(with: credential)
       } else {
-        throw NSError(
-          domain: "FacebookSwiftErrorDomain",
-          code: 2,
-          userInfo: [
-            NSLocalizedDescriptionKey: "Authentication is not available. Please sign-in with Facebook before attempting to create a Facebook provider credential",
-          ]
-        )
+        throw FacebookError
+          .authenticationToken(
+            "Authentication is not available. Please sign-in with Facebook before attempting to create a Facebook provider credential"
+          )
       }
     } catch {
       errorMessage = authService.string.localizedErrorMessage(

FirebaseSwiftUI/FirebaseGoogleSwiftUI/Sources/Services/GoogleProviderSwift.swift

@@ -6,6 +6,12 @@ let kGoogleUserInfoEmailScope = "https://www.googleapis.com/auth/userinfo.email"
 let kGoogleUserInfoProfileScope = "https://www.googleapis.com/auth/userinfo.profile"
 let kDefaultScopes = [kGoogleUserInfoEmailScope, kGoogleUserInfoProfileScope]
 
+public enum GoogleError: Error {
+  case rootViewController(String)
+  case authenticationToken(String)
+  case user(String)
+}
+
 public class GoogleProviderSwift: @preconcurrency GoogleProviderProtocol {
   let scopes: [String]
   let shortName = "Google"
@@ -21,13 +27,8 @@ public class GoogleProviderSwift: @preconcurrency GoogleProviderProtocol {
   @MainActor public func signInWithGoogle(clientID: String) async throws -> AuthCredential {
     guard let presentingViewController = await (UIApplication.shared.connectedScenes
       .first as? UIWindowScene)?.windows.first?.rootViewController else {
-      throw NSError(
-        domain: "GoogleProviderSwiftErrorDomain",
-        code: 1,
-        userInfo: [
-          NSLocalizedDescriptionKey: "Root View controller is not available to present Google sign-in View.",
-        ]
-      )
+      throw GoogleError
+        .rootViewController("Root View controller is not available to present Google sign-in View.")
     }
 
     let config = GIDConfiguration(clientID: clientID)
@@ -44,13 +45,7 @@ public class GoogleProviderSwift: @preconcurrency GoogleProviderProtocol {
 
         guard let user = result?.user,
               let idToken = user.idToken?.tokenString else {
-          continuation.resume(throwing: NSError(
-            domain: "GoogleProviderSwiftErrorDomain",
-            code: 2,
-            userInfo: [
-              NSLocalizedDescriptionKey: "Failed to retrieve user or idToken.",
-            ]
-          ))
+          continuation.resume(throwing: GoogleError.user("Failed to retrieve user or idToken."))
           return
         }