Skip to content

Commit 2159eaf

Browse files
committed
fix casing and feedback
1 parent 0d08943 commit 2159eaf

8 files changed

Lines changed: 17 additions & 15 deletions

File tree

packages/firebase_ai/firebase_ai/android/src/main/kotlin/io/flutter/plugins/firebase/ai/FirebaseAiPlugin.kt renamed to packages/firebase_ai/firebase_ai/android/src/main/kotlin/io/flutter/plugins/firebase/ai/FirebaseAIPlugin.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2025 Google LLC
1+
// Copyright 2026 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -24,7 +24,7 @@ import io.flutter.plugin.common.MethodChannel
2424
import java.security.MessageDigest
2525
import java.security.NoSuchAlgorithmException
2626

27-
class FirebaseAiPlugin : FlutterPlugin, MethodChannel.MethodCallHandler {
27+
class FirebaseAIPlugin : FlutterPlugin, MethodChannel.MethodCallHandler {
2828
private lateinit var channel: MethodChannel
2929
private lateinit var context: Context
3030

@@ -61,7 +61,7 @@ class FirebaseAiPlugin : FlutterPlugin, MethodChannel.MethodCallHandler {
6161
PackageManager.GET_SIGNING_CERTIFICATES
6262
)
6363
} catch (e: PackageManager.NameNotFoundException) {
64-
Log.d(TAG, "PackageManager couldn't find the package \"$packageName\"")
64+
Log.e(TAG, "PackageManager couldn't find the package \"$packageName\"", e)
6565
return null
6666
}
6767
val signingInfo = packageInfo?.signingInfo ?: return null
@@ -78,7 +78,7 @@ class FirebaseAiPlugin : FlutterPlugin, MethodChannel.MethodCallHandler {
7878
PackageManager.GET_SIGNATURES
7979
)
8080
} catch (e: PackageManager.NameNotFoundException) {
81-
Log.d(TAG, "PackageManager couldn't find the package \"$packageName\"")
81+
Log.e(TAG, "PackageManager couldn't find the package \"$packageName\"", e)
8282
return null
8383
}
8484
@Suppress("DEPRECATION")
@@ -96,6 +96,6 @@ class FirebaseAiPlugin : FlutterPlugin, MethodChannel.MethodCallHandler {
9696
}
9797

9898
companion object {
99-
private const val TAG = "FirebaseAiPlugin"
99+
private const val TAG = "FirebaseAIPlugin"
100100
}
101101
}

packages/firebase_ai/firebase_ai/ios/firebase_ai/Sources/firebase_ai/FirebaseAiPlugin.swift renamed to packages/firebase_ai/firebase_ai/ios/firebase_ai/Sources/firebase_ai/FirebaseAIPlugin.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2025 Google LLC
1+
// Copyright 2026 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -18,7 +18,7 @@
1818
import Flutter
1919
#endif
2020

21-
public class FirebaseAiPlugin: NSObject, FlutterPlugin {
21+
public class FirebaseAIPlugin: NSObject, FlutterPlugin {
2222
public static func register(with registrar: FlutterPluginRegistrar) {
2323
#if canImport(FlutterMacOS)
2424
let messenger = registrar.messenger
@@ -30,7 +30,7 @@ public class FirebaseAiPlugin: NSObject, FlutterPlugin {
3030
name: "plugins.flutter.io/firebase_ai",
3131
binaryMessenger: messenger
3232
)
33-
let instance = FirebaseAiPlugin()
33+
let instance = FirebaseAIPlugin()
3434
registrar.addMethodCallDelegate(instance, channel: channel)
3535
}
3636

packages/firebase_ai/firebase_ai/lib/src/platform_header_helper.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2025 Google LLC
1+
// Copyright 2026 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../../../ios/firebase_ai/Sources/firebase_ai/FirebaseAIPlugin.swift

packages/firebase_ai/firebase_ai/macos/firebase_ai/Sources/firebase_ai/FirebaseAiPlugin.swift

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/firebase_ai/firebase_ai/pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ flutter:
4343
platforms:
4444
android:
4545
package: io.flutter.plugins.firebase.ai
46-
pluginClass: FirebaseAiPlugin
46+
pluginClass: FirebaseAIPlugin
4747
ios:
48-
pluginClass: FirebaseAiPlugin
48+
pluginClass: FirebaseAIPlugin
4949
macos:
50-
pluginClass: FirebaseAiPlugin
50+
pluginClass: FirebaseAIPlugin

packages/firebase_ai/firebase_ai/test/platform_header_helper_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2025 Google LLC
1+
// Copyright 2026 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

tests/integration_test/firebase_ai/firebase_ai_e2e_test.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2025, the Chromium project authors. Please see the AUTHORS file
1+
// Copyright 2026, the Chromium project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

@@ -43,6 +43,7 @@ void main() {
4343
'getPlatformHeaders',
4444
);
4545

46+
expect(headers, isNotNull);
4647
expect(headers, contains('X-Android-Package'));
4748
expect(
4849
headers!['X-Android-Package'],
@@ -64,6 +65,7 @@ void main() {
6465
'getPlatformHeaders',
6566
);
6667

68+
expect(headers, isNotNull);
6769
expect(headers, contains('x-ios-bundle-identifier'));
6870
expect(
6971
headers!['x-ios-bundle-identifier'],

0 commit comments

Comments
 (0)