From ff0b9747202f7baec85eaf8e71e3327e33428275 Mon Sep 17 00:00:00 2001 From: Costa Tsaousis Date: Tue, 9 Jun 2026 10:48:28 +0300 Subject: [PATCH] address 2 more AI quality findings SOW label and slash-zero test Follow-up to PR #37 (which fixed the 3 real Go test issues). This addresses 2 more small, mechanical items from the same AI findings triage that were skipped in PR #37: - .agents/sow/current/SOW-0102: rename the first slice's result heading from 'Final local results' to 'First-slice local results'. The SOW now documents three slice results (First, Second, Third), so calling the first one 'Final' was misleading. - pkg/downloader: extend the /0 filter test in TestParseProcessedFeedFileSanitizesInput to also assert that 5.6.7.0 (the CIDR base address) is omitted alongside 5.6.7.1. Catches regressions where the /0 base is kept while other addresses are dropped. --- ...SOW-0102-20260603-quality-complexity-duplication-coverage.md | 2 +- pkg/downloader/canonical_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.agents/sow/current/SOW-0102-20260603-quality-complexity-duplication-coverage.md b/.agents/sow/current/SOW-0102-20260603-quality-complexity-duplication-coverage.md index b00dc09..9be188f 100644 --- a/.agents/sow/current/SOW-0102-20260603-quality-complexity-duplication-coverage.md +++ b/.agents/sow/current/SOW-0102-20260603-quality-complexity-duplication-coverage.md @@ -1233,7 +1233,7 @@ Acceptance criteria evidence: - `tools/archposture` baseline: source files `587`, source lines `122880`, large files `59`, large functions `49`. - Codacy Cloud pre-edit duplication baseline was `14%`. - Source-only `jscpd` first actionable local scan during this slice found `14` clones, `676` duplicated lines, and `334` duplicated Go lines. -- Final local results: +- First-slice local results: - Root coverage is `70.8%`. - `pkg/iprange` coverage is `67.3%`. - `internal/telemetry` coverage is `91.9%`. diff --git a/pkg/downloader/canonical_test.go b/pkg/downloader/canonical_test.go index dabb6d8..8b62bcc 100644 --- a/pkg/downloader/canonical_test.go +++ b/pkg/downloader/canonical_test.go @@ -103,7 +103,7 @@ func TestParseProcessedFeedFileSanitizesInput(t *testing.T) { t.Fatalf("ParseProcessedFeedFile: %v", err) } assertCanonicalSetContains(t, set, "1.2.3.4", "8.8.8.8") - assertCanonicalSetOmits(t, set, "0.0.0.0", "5.6.7.1") + assertCanonicalSetOmits(t, set, "0.0.0.0", "5.6.7.0", "5.6.7.1") if got, want := set.UniqueCount(), uint64(2); got != want { t.Fatalf("processed unique count = %d, want %d", got, want) }