trigger full refresh on command execution and include delete method in update callbacks

Author: firstof9

openevsehttp/client.py

@@ -118,7 +118,12 @@ async def update(self, force_full: bool = False) -> None:
         # force_full override this behavior.
         urls = [f"{self.url}config"]
 
-        if not self._ws_listening or force_full:
+        if (
+            not self._ws_listening
+            or force_full
+            or not self._status
+            or "state" not in self._status
+        ):
             urls = [f"{self.url}status", f"{self.url}config"]
 
         for url in urls:
@@ -690,6 +695,8 @@ async def set_divert_mode(self, mode: str = "fast") -> None:
             _LOGGER.error("Problem issuing command. Response: %s", response)
             raise UnknownError
 
+        await self.full_refresh()
+
     # Properties
     @property
     def led_brightness(self) -> int | None:

openevsehttp/requester.py

@@ -136,7 +136,7 @@ async def _process_request_with_session(
                     return message
 
                 if (
-                    method in ("post", "patch", "put")
+                    method in ("post", "patch", "put", "delete")
                     and isinstance(message, dict)
                     and message.get("ok", True) is not False
                     and self._update_callback

tests/conftest.py

@@ -110,11 +110,13 @@ def test_charger_new(mock_aioclient):
         TEST_URL_STATUS,
         status=200,
         body=load_fixture("v4_json/status-new.json"),
+        repeat=True,
     )
     mock_aioclient.get(
         TEST_URL_CONFIG,
         status=200,
         body=load_fixture("v4_json/config-new.json"),
+        repeat=True,
     )
     mock_aioclient.get(
         TEST_URL_WS,
@@ -212,11 +214,13 @@ def test_charger_legacy(mock_aioclient):
         TEST_URL_STATUS,
         status=200,
         body=load_fixture("v_legacy_json/status.json"),
+        repeat=True,
     )
     mock_aioclient.get(
         TEST_URL_CONFIG,
         status=200,
         body=load_fixture("v_legacy_json/config.json"),
+        repeat=True,
     )
     mock_aioclient.get(
         TEST_URL_WS,

tests/test_client.py

@@ -1445,6 +1445,7 @@ async def test_led_brightness(mock_aioclient):
     charger._config["version"] = "4.1.0"
     charger._config["led_brightness"] = 128
     mock_aioclient.post(TEST_URL_CONFIG, status=200, body='{"msg": "done"}')
+    charger.requester._update_callback = None
     await charger.set_led_brightness(255)
     assert charger.led_brightness == 128
 
@@ -1458,10 +1459,11 @@ async def test_set_divert_mode(mock_aioclient):
         await charger.set_divert_mode("invalid")
 
     # Success
-    mock_aioclient.post(
-        f"http://{SERVER_URL}/divertmode", status=200, body="Divert Mode changed"
-    )
-    await charger.set_divert_mode("eco")
+    with patch.object(charger, "full_refresh", AsyncMock()):
+        mock_aioclient.post(
+            f"http://{SERVER_URL}/divertmode", status=200, body="Divert Mode changed"
+        )
+        await charger.set_divert_mode("eco")
 
     # Failure
     mock_aioclient.post(f"http://{SERVER_URL}/divertmode", status=200, body="Error")

tests/test_override.py

@@ -122,6 +122,7 @@ async def test_toggle_override_modified_ver(
 async def test_toggle_override_v2(test_charger_legacy, mock_aioclient, caplog):
     """Test legacy toggle override."""
     await test_charger_legacy.update()
+    test_charger_legacy.requester._update_callback = None
     value = {"cmd": "OK", "ret": "$OK"}
     mock_aioclient.post(
         TEST_URL_RAPI,
@@ -318,6 +319,7 @@ async def test_set_override_success(
 ):
     """Verify that set_override correctly sends various override parameters to the device."""
     await test_charger.update()
+    test_charger.requester._update_callback = None
     value = {
         "state": "active",
         "charge_current": 0,
@@ -437,6 +439,7 @@ async def test_get_override(test_charger, test_charger_legacy, mock_aioclient, c
 async def test_set_override_partial(test_charger, mock_aioclient, caplog):
     """Verify that set_override correctly merges partial updates with current override state."""
     await test_charger.update()
+    test_charger.requester._update_callback = None
     value = {
         "state": "active",
         "charge_current": 32,