fix: replace os.path with pathlib for file handling and improve readability

Author: twangodev

examples/getting-started/01_simple_tts.py

@@ -18,7 +18,7 @@
     - Audio file contains the spoken text
 """
 
-import os
+from pathlib import Path
 
 from fishaudio import FishAudio
 from fishaudio.utils import save
@@ -44,7 +44,7 @@ def main():
     save(audio, output_file)
 
     print(f"✓ Audio saved to {output_file}")
-    print(f"  File size: {os.path.getsize(output_file) / 1024:.2f} KB")
+    print(f"  File size: {Path(output_file).stat().st_size / 1024:.2f} KB")
 
 
 if __name__ == "__main__":

src/fishaudio/utils/save.py

@@ -1,6 +1,7 @@
 """Audio saving utility."""
 
 from collections.abc import Iterable
+from pathlib import Path
 from typing import Union
 
 
@@ -32,5 +33,5 @@ def save(audio: Union[bytes, Iterable[bytes]], filename: str) -> None:
         audio = b"".join(audio)
 
     # Write to file
-    with open(filename, "wb") as f:
+    with Path(filename).open("wb") as f:
         f.write(audio)

tests/unit/test_core.py

@@ -101,9 +101,11 @@ def test_init_with_api_key(self, mock_api_key, mock_base_url):
         assert wrapper.base_url == mock_base_url
 
     def test_init_without_api_key_raises(self):
-        with patch.dict("os.environ", {}, clear=True):
-            with pytest.raises(ValueError, match="API key must be provided"):
-                ClientWrapper()
+        with (
+            patch.dict("os.environ", {}, clear=True),
+            pytest.raises(ValueError, match="API key must be provided"),
+        ):
+            ClientWrapper()
 
     def test_init_with_env_var(self, mock_api_key):
         with patch.dict("os.environ", {"FISH_API_KEY": mock_api_key}):
@@ -134,9 +136,11 @@ def test_init_with_api_key(self, mock_api_key, mock_base_url):
         assert wrapper.base_url == mock_base_url
 
     def test_init_without_api_key_raises(self):
-        with patch.dict("os.environ", {}, clear=True):
-            with pytest.raises(ValueError, match="API key must be provided"):
-                AsyncClientWrapper()
+        with (
+            patch.dict("os.environ", {}, clear=True),
+            pytest.raises(ValueError, match="API key must be provided"),
+        ):
+            AsyncClientWrapper()
 
     def test_get_headers(self, mock_api_key):
         wrapper = AsyncClientWrapper(api_key=mock_api_key)

tests/unit/test_utils.py

@@ -16,20 +16,20 @@ def test_save_bytes(self):
         """Test saving bytes to file."""
         audio = b"fake audio data"
 
-        with patch("builtins.open", mock_open()) as m:
+        with patch("pathlib.Path.open", mock_open()) as m:
             save(audio, "output.mp3")
 
-            m.assert_called_once_with("output.mp3", "wb")
+            m.assert_called_once_with("wb")
             m().write.assert_called_once_with(audio)
 
     def test_save_iterator(self):
         """Test saving iterator to file."""
         audio = iter([b"chunk1", b"chunk2", b"chunk3"])
 
-        with patch("builtins.open", mock_open()) as m:
+        with patch("pathlib.Path.open", mock_open()) as m:
             save(audio, "output.mp3")
 
-            m.assert_called_once_with("output.mp3", "wb")
+            m.assert_called_once_with("wb")
             # Should consolidate chunks
             m().write.assert_called_once_with(b"chunk1chunk2chunk3")