Skip to content

Commit 5b2e38f

Browse files
authored
Merge pull request DataDog#3148 from DataDog/yl/profiling-raise-frequency
Update Profiler sampling frequency to 201Hz
2 parents 88de5ea + 24c7062 commit 5b2e38f

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/internal/perfetto/PerfettoProfiler.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,9 @@ internal class PerfettoProfiler(
225225
// increased or configurable if needed.
226226
private const val BUFFER_SIZE_KB = 5120 // 5MB
227227

228-
// Currently we give 101HZ frequency to balance the sampling accuracy and performance
228+
// Currently we give 201HZ frequency to balance the sampling accuracy and performance
229229
// overhead also to avoid lockstep sampling, it can be updated or configurable if needed.
230-
private const val PROFILING_SAMPLING_RATE = 101 // 101Hz
230+
internal const val PROFILING_SAMPLING_RATE = 201 // 201Hz
231231
private const val TELEMETRY_MSG_PROFILING_APP_LAUNCH =
232232
"[Mobile Metric] Profiling App Launch"
233233
private const val TELEMETRY_KEY_PROFILING_APP_LAUNCH = "profiling_app_launch"

features/dd-sdk-android-profiling/src/test/kotlin/com/datadog/android/profiling/internal/PerfettoProfilerTest.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import com.datadog.android.api.InternalLogger
1515
import com.datadog.android.core.metrics.MethodCallSamplingRate
1616
import com.datadog.android.internal.time.TimeProvider
1717
import com.datadog.android.profiling.internal.perfetto.PerfettoProfiler
18+
import com.datadog.android.profiling.internal.perfetto.PerfettoProfiler.Companion.PROFILING_SAMPLING_RATE
1819
import com.datadog.android.profiling.internal.perfetto.PerfettoResult
1920
import fr.xgouchet.elmyr.annotation.IntForgery
2021
import fr.xgouchet.elmyr.annotation.LongForgery
@@ -203,7 +204,7 @@ class PerfettoProfilerTest {
203204
),
204205
"profiling_config" to mapOf(
205206
"buffer_size" to 5120,
206-
"sampling_frequency" to 101
207+
"sampling_frequency" to PROFILING_SAMPLING_RATE
207208
)
208209
)
209210
verify(mockInternalLogger)
@@ -260,7 +261,7 @@ class PerfettoProfilerTest {
260261
),
261262
"profiling_config" to mapOf(
262263
"buffer_size" to 5120,
263-
"sampling_frequency" to 101
264+
"sampling_frequency" to PROFILING_SAMPLING_RATE
264265
)
265266
)
266267
verify(mockInternalLogger)
@@ -318,7 +319,7 @@ class PerfettoProfilerTest {
318319
),
319320
"profiling_config" to mapOf(
320321
"buffer_size" to 5120,
321-
"sampling_frequency" to 101
322+
"sampling_frequency" to PROFILING_SAMPLING_RATE
322323
)
323324
)
324325
verify(mockInternalLogger)

features/dd-sdk-android-profiling/src/test/kotlin/com/datadog/android/profiling/internal/ProfilingConfigurationBuilderTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* Copyright 2016-Present Datadog, Inc.
55
*/
66

7-
@file:OptIn(ExperimentalProfilingApi::class)
8-
97
package com.datadog.android.profiling.internal
108

119
import com.datadog.android.profiling.ExperimentalProfilingApi
@@ -21,6 +19,7 @@ import org.mockito.junit.jupiter.MockitoExtension
2119
import org.mockito.junit.jupiter.MockitoSettings
2220
import org.mockito.quality.Strictness
2321

22+
@OptIn(ExperimentalProfilingApi::class)
2423
@Extensions(
2524
ExtendWith(MockitoExtension::class),
2625
ExtendWith(ForgeExtension::class)

0 commit comments

Comments
 (0)