fix: address golangci-lint errcheck and bodyclose issues

- Close resp.Body in ws/client.go Connect method
- Check error returns for all Close() calls
- Check error returns for SetReadDeadline/SetWriteDeadline
- Use assignOp for delay *= 2 (gocritic)

Author: ysyneu

cmd/main.go

@@ -153,7 +153,7 @@ func runRunner() error {
 			}
 		}
 
-		client.Close()
+		_ = client.Close()
 	}()
 
 	// Run with reconnection

workspace/webfetch.go

@@ -44,7 +44,9 @@ func (w *Workspace) WebFetch(ctx context.Context, args *protocol.WebFetchArgs) (
 	if err != nil {
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer func() {
+		_ = resp.Body.Close()
+	}()
 
 	body, err := readResponseBody(resp)
 	if err != nil {

workspace/workspace.go

@@ -119,7 +119,9 @@ func (w *Workspace) readFileContent(path string, size, offset, limit int64) (*pr
 	if err != nil {
 		return nil, fmt.Errorf("failed to open file: %w", err)
 	}
-	defer file.Close()
+	defer func() {
+		_ = file.Close()
+	}()
 
 	if offset < 0 {
 		offset = 0
@@ -337,7 +339,7 @@ func (w *Workspace) grepWithGo(ctx context.Context, args *protocol.GrepArgs) (*p
 				}
 				lineNum++
 			}
-			file.Close()
+			_ = file.Close()
 		}
 	}
 	return &protocol.GrepResult{Matches: results}, nil
@@ -618,13 +620,17 @@ func (w *Workspace) extractZipFile(f *zip.File, targetPath string) error {
 	if err != nil {
 		return err
 	}
-	defer rc.Close()
+	defer func() {
+		_ = rc.Close()
+	}()
 
 	dst, err := os.OpenFile(targetPath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, f.Mode())
 	if err != nil {
 		return err
 	}
-	defer dst.Close()
+	defer func() {
+		_ = dst.Close()
+	}()
 
 	_, err = io.Copy(dst, rc)
 	return err

workspace/workspace_test.go

@@ -90,10 +90,10 @@ func TestWorkspace_List(t *testing.T) {
 	ctx := context.Background()
 
 	// Create test structure
-	os.MkdirAll(filepath.Join(ws.Root(), "dir1"), 0o755)
-	os.MkdirAll(filepath.Join(ws.Root(), "dir2"), 0o755)
-	os.WriteFile(filepath.Join(ws.Root(), "file1.txt"), []byte("content"), 0o644)
-	os.WriteFile(filepath.Join(ws.Root(), "dir1", "file2.txt"), []byte("content"), 0o644)
+	_ = os.MkdirAll(filepath.Join(ws.Root(), "dir1"), 0o755)
+	_ = os.MkdirAll(filepath.Join(ws.Root(), "dir2"), 0o755)
+	_ = os.WriteFile(filepath.Join(ws.Root(), "file1.txt"), []byte("content"), 0o644)
+	_ = os.WriteFile(filepath.Join(ws.Root(), "dir1", "file2.txt"), []byte("content"), 0o644)
 
 	// List non-recursive
 	result, err := ws.List(ctx, &protocol.ListArgs{Path: ".", Recursive: false})
@@ -111,9 +111,9 @@ func TestWorkspace_Glob(t *testing.T) {
 	ctx := context.Background()
 
 	// Create test files
-	os.WriteFile(filepath.Join(ws.Root(), "file1.txt"), []byte("content"), 0o644)
-	os.WriteFile(filepath.Join(ws.Root(), "file2.txt"), []byte("content"), 0o644)
-	os.WriteFile(filepath.Join(ws.Root(), "file3.log"), []byte("content"), 0o644)
+	_ = os.WriteFile(filepath.Join(ws.Root(), "file1.txt"), []byte("content"), 0o644)
+	_ = os.WriteFile(filepath.Join(ws.Root(), "file2.txt"), []byte("content"), 0o644)
+	_ = os.WriteFile(filepath.Join(ws.Root(), "file3.log"), []byte("content"), 0o644)
 
 	result, err := ws.Glob(ctx, &protocol.GlobArgs{Pattern: "*.txt"})
 	require.NoError(t, err)
@@ -127,8 +127,8 @@ func TestWorkspace_Grep(t *testing.T) {
 	ctx := context.Background()
 
 	// Create test files
-	os.WriteFile(filepath.Join(ws.Root(), "file1.txt"), []byte("hello world\nfoo bar\nhello again"), 0o644)
-	os.WriteFile(filepath.Join(ws.Root(), "file2.txt"), []byte("no match here"), 0o644)
+	_ = os.WriteFile(filepath.Join(ws.Root(), "file1.txt"), []byte("hello world\nfoo bar\nhello again"), 0o644)
+	_ = os.WriteFile(filepath.Join(ws.Root(), "file2.txt"), []byte("no match here"), 0o644)
 
 	result, err := ws.Grep(ctx, &protocol.GrepArgs{Pattern: "hello"})
 	require.NoError(t, err)

ws/client.go

@@ -93,6 +93,7 @@ func (c *Client) Connect(ctx context.Context) error {
 	conn, resp, err := websocket.DefaultDialer.DialContext(ctx, c.cfg.APIURL, header)
 	if err != nil {
 		if resp != nil {
+			_ = resp.Body.Close()
 			return fmt.Errorf("failed to connect: %w (status: %d)", err, resp.StatusCode)
 		}
 		return fmt.Errorf("failed to connect: %w", err)
@@ -101,6 +102,7 @@ func (c *Client) Connect(ctx context.Context) error {
 	// Get worknode ID from response header
 	if resp != nil {
 		c.worknodeID = resp.Header.Get("X-Worknode-ID")
+		_ = resp.Body.Close()
 	}
 
 	c.mu.Lock()
@@ -130,8 +132,10 @@ func (c *Client) readWelcomeMessage() error {
 	}
 
 	// Set a short deadline for the welcome message
-	conn.SetReadDeadline(time.Now().Add(5 * time.Second))
-	defer conn.SetReadDeadline(time.Time{})
+	_ = conn.SetReadDeadline(time.Now().Add(5 * time.Second))
+	defer func() {
+		_ = conn.SetReadDeadline(time.Time{})
+	}()
 
 	_, data, err := conn.ReadMessage()
 	if err != nil {
@@ -201,7 +205,7 @@ func (c *Client) RunWithReconnect(ctx context.Context) error {
 			}
 
 			// Exponential backoff
-			delay = delay * 2
+			delay *= 2
 			if delay > maxReconnectDelay {
 				delay = maxReconnectDelay
 			}
@@ -287,14 +291,14 @@ func (c *Client) readLoop(ctx context.Context) error {
 		return fmt.Errorf("not connected")
 	}
 
-	conn.SetReadDeadline(time.Now().Add(pongWait))
+	_ = conn.SetReadDeadline(time.Now().Add(pongWait))
 	conn.SetPongHandler(func(string) error {
-		conn.SetReadDeadline(time.Now().Add(pongWait))
+		_ = conn.SetReadDeadline(time.Now().Add(pongWait))
 		return nil
 	})
 	// Handle ping messages from server - must reply with pong and reset deadline
 	conn.SetPingHandler(func(appData string) error {
-		conn.SetReadDeadline(time.Now().Add(pongWait))
+		_ = conn.SetReadDeadline(time.Now().Add(pongWait))
 		// Must reply with pong - WriteControl is safe to call from handler
 		return conn.WriteControl(websocket.PongMessage, []byte(appData), time.Now().Add(writeWait))
 	})
@@ -314,7 +318,7 @@ func (c *Client) readLoop(ctx context.Context) error {
 		}
 
 		// Reset deadline on any message received
-		conn.SetReadDeadline(time.Now().Add(pongWait))
+		_ = conn.SetReadDeadline(time.Now().Add(pongWait))
 
 		var msg protocol.Message
 		if err := json.Unmarshal(data, &msg); err != nil {
@@ -354,7 +358,7 @@ func (c *Client) sendLoop(ctx context.Context) {
 				continue
 			}
 
-			conn.SetWriteDeadline(time.Now().Add(writeWait))
+			_ = conn.SetWriteDeadline(time.Now().Add(writeWait))
 			data, err := json.Marshal(msg)
 			if err != nil {
 				slog.Error("failed to marshal message",