Skip to content

Scan generated Fleet artifacts for secrets #36244

@iansltx

Description

@iansltx

Goal

User story
As a consumer of Fleet,
I want to ensure that Fleet binaries don't embed secrets or secret-looking artifacts
so that I can have better assurance of a cleaner software supply chain.

Original requests

Context: We're pulling crewjam/saml into fleetctl's binary because of transitive dependencies from fleetctl code. This caused a flag that's being fixed by crewjam/saml#646. A customer caught this via GitHub Enterprise secret scanning.

More context in Slack

Resources

Changes

Engineering

  • Test plan is finalized
  • Secret scanning has been added to binary artifact builds, with false positives excluded alongside documentation on the exclusions

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Risk level: Low

Test plan

Testing notes

Confirmation

  1. Engineer: Added comment to user story confirming successful completion of test plan.
  2. QA: Added comment to user story confirming successful completion of test plan.

Metadata

Metadata

Assignees

No one assigned

    Labels

    #g-orchestrationOrchestration product groupstoryA user story defining an entire feature~engineering-initiatedEngineering-initiated story, such as a bug, refactor, or contributor experience improvement.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions