Skip to content

Commit 320e66c

Browse files
committed
Add merge note for PR 133 conflict
1 parent c2fc3a5 commit 320e66c

1 file changed

Lines changed: 22 additions & 0 deletions

File tree

MERGE-NOTE-PR-133.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Merge Conflict Note – PR #133 (feature/docker-engine vs master)
2+
3+
There is a single conflict when bringing `origin/master` into `feature/docker-engine`:
4+
5+
- **File:** `src/FlowCtl/Commands/Run/RunCommandOptionsHandler.cs`
6+
- **Cause:** `feature/docker-engine` adds the Docker run path and settings persistence; `master` added XML docs/cleanup around `GetArgumentStr` (and nearby helpers). Git could not auto-merge those overlapping edits.
7+
8+
## How to resolve
9+
10+
1. Keep the Docker logic from `feature/docker-engine`:
11+
- The `RunDockerAsync` method with Docker pull/run/start and settings persistence.
12+
- The platform/tag resolution helpers and the Docker mode hinting.
13+
2. Keep the upstream doc/comment/formatting improvements from `master`:
14+
- The XML documentation and tightened argument construction around `GetArgumentStr` (and related small cleanups).
15+
3. Resulting file should have:
16+
- The full Docker pathway (pull/create/start, attach logs when not background).
17+
- The `GetArgumentStr` with upstream doc comment.
18+
- No conflict markers.
19+
20+
## Notes
21+
- Do the merge in a clean worktree to avoid touching unrelated local changes (e.g., ConsoleLogger removals, JsonSerializer tweaks).
22+
- After resolving, rerun `dotnet test` and push the updated branch before re-running the PR checks.

0 commit comments

Comments
 (0)