Check GUID validation for any kind of value in GUID format for all commands

ziagham · ziagham · commit 6b1fcd19a56d · 2025-05-14T20:35:56.000+02:00
#100
diff --git a/src/FlowCtl.Infrastructure/Extensions/ServiceCollectionExtensions.cs b/src/FlowCtl.Infrastructure/Extensions/ServiceCollectionExtensions.cs
@@ -22,6 +22,7 @@ public static IServiceCollection AddInfrastructure(this IServiceCollection servi
                 .AddScoped<IProcessProvider, DefaultProcessProvider>()
                 .AddScoped<IProcessHandler, ProcessHandler>()
                 .AddScoped<IArchiveExtractor, ArchiveExtractor>()
+                .AddScoped<IDataProtectorWrapper, DataProtectorWrapper>()
                 .AddScoped<IAuthenticationManager, AuthenticationManager>();
 
         return services;
diff --git a/src/FlowCtl/Commands/Config/Delete/DeleteConfigCommandOptionsHandler.cs b/src/FlowCtl/Commands/Config/Delete/DeleteConfigCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(DeleteConfigCommandOptions options, CancellationToken
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new DeletePluginConfigRequest { Id = Guid.Parse(options.ConfigId) };
+            if (!Guid.TryParse(options.ConfigId, out Guid configId))
+                throw new FormatException("Invalid config id format. Expected a valid GUID.");
+
+            var request = new DeletePluginConfigRequest { Id = configId };
             var result = await _flowSynxClient.PluginConfig.DeleteAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Config/Details/DetailsConfigCommandOptionsHandler.cs b/src/FlowCtl/Commands/Config/Details/DetailsConfigCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(DetailsConfigCommandOptions options, CancellationToke
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new PluginConfigDetailsRequest { Id = Guid.Parse(options.ConfigId) };
+            if (!Guid.TryParse(options.ConfigId, out Guid configId))
+                throw new FormatException("Invalid config id format. Expected a valid GUID.");
+            
+            var request = new PluginConfigDetailsRequest { Id = configId };
             var result = await _flowSynxClient.PluginConfig.DetailsAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Plugins/Details/PluginDetailsCommandOptionsHandler.cs b/src/FlowCtl/Commands/Plugins/Details/PluginDetailsCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(PluginDetailsCommandOptions options, CancellationToke
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new PluginDetailsRequest { Id = Guid.Parse(options.PluginId) };
+            if (!Guid.TryParse(options.PluginId, out Guid pluginId))
+                throw new FormatException("Invalid plugin id format. Expected a valid GUID.");
+
+            var request = new PluginDetailsRequest { Id = pluginId };
             var result = await _flowSynxClient.Plugins.DetailsAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Delete/DeleteWorkflowCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Delete/DeleteWorkflowCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(DeleteWorkflowCommandOptions options, CancellationTok
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new DeleteWorkflowRequest { Id = Guid.Parse(options.WorkflowId) };
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            var request = new DeleteWorkflowRequest { Id = workflowId };
             var result = await _flowSynxClient.Workflows.DeleteAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Details/WorkflowDetailsCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Details/WorkflowDetailsCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(WorkflowDetailsCommandOptions options, CancellationTo
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new WorkflowDetailsRequest { Id = Guid.Parse(options.WorkflowId) };
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            var request = new WorkflowDetailsRequest { Id = workflowId };
             var result = await _flowSynxClient.Workflows.DetailsAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Executions/Cancel/WorkflowExecutionCancelCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Executions/Cancel/WorkflowExecutionCancelCommandOptionsHandler.cs
@@ -41,10 +41,16 @@ private async Task Execute(WorkflowExecutionCancelCommandOptions options, Cancel
                 _flowSynxClient.SetConnection(connection);
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            if (!Guid.TryParse(options.ExecutionId, out Guid executionId))
+                throw new FormatException("Invalid executionId id format. Expected a valid GUID.");
+
             var request = new CancelWorkflowRequest
             {
-                WorkflowId = options.WorkflowId, 
-                WorkflowExecutionId = options.ExecutionId 
+                WorkflowId = workflowId, 
+                WorkflowExecutionId = executionId
             };
             var result = await _flowSynxClient.Workflows.CancelExecutionsAsync(request, cancellationToken);
 
diff --git a/src/FlowCtl/Commands/Workflows/Executions/Details/WorkflowExecutionsDetailsCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Executions/Details/WorkflowExecutionsDetailsCommandOptionsHandler.cs
@@ -41,10 +41,16 @@ private async Task Execute(WorkflowExecutionDetailsCommandOptions options, Cance
                 _flowSynxClient.SetConnection(connection);
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            if (!Guid.TryParse(options.ExecutionId, out Guid executionId))
+                throw new FormatException("Invalid execution id format. Expected a valid GUID.");
+
             var request = new WorkflowExecutionDetailsRequest 
             {
-                WorkflowId = options.WorkflowId, 
-                WorkflowExecutionId = options.ExecutionId 
+                WorkflowId = workflowId, 
+                WorkflowExecutionId = executionId
             };
             var result = await _flowSynxClient.Workflows.ExecutionsDetailsAsync(request, cancellationToken);
 
diff --git a/src/FlowCtl/Commands/Workflows/Executions/Execute/ExecuteWorkflowCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Executions/Execute/ExecuteWorkflowCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(ExecuteWorkflowCommandOptions options, CancellationTo
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new ExecuteWorkflowRequest { WorkflowId = Guid.Parse(options.WorkflowId) };
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            var request = new ExecuteWorkflowRequest { WorkflowId = workflowId };
             var result = await _flowSynxClient.Workflows.ExecuteAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Executions/Logs/WorkflowExecutionLogsCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Executions/Logs/WorkflowExecutionLogsCommandOptionsHandler.cs
@@ -41,10 +41,16 @@ private async Task Execute(WorkflowExecutionLogsCommandOptions options, Cancella
                 _flowSynxClient.SetConnection(connection);
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            if (!Guid.TryParse(options.ExecutionId, out Guid executionId))
+                throw new FormatException("Invalid execution id format. Expected a valid GUID.");
+
             var request = new WorkflowExecutionDetailsRequest 
             {
-                WorkflowId = options.WorkflowId, 
-                WorkflowExecutionId = options.ExecutionId 
+                WorkflowId = workflowId, 
+                WorkflowExecutionId = executionId
             };
             var result = await _flowSynxClient.Workflows.ExecutionsDetailsAsync(request, cancellationToken);
 
diff --git a/src/FlowCtl/Commands/Workflows/Executions/WorkflowExecutionsCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Executions/WorkflowExecutionsCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(WorkflowExecutionsCommandOptions options, Cancellatio
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new WorkflowExecutionListRequest { WorkflowId = options.WorkflowId };
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            var request = new WorkflowExecutionListRequest { WorkflowId = workflowId };
             var result = await _flowSynxClient.Workflows.ExecutionsAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Triggers/Add/AddWorkflowTriggerCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Triggers/Add/AddWorkflowTriggerCommandOptionsHandler.cs
@@ -58,8 +58,11 @@ private async Task Execute(AddWorkflowTriggerCommandOptions options, Cancellatio
                 jsonData = options.Data;
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
             var request = AddTriggerData(jsonData);
-            request.WorkflowId = options.WorkflowId;
+            request.WorkflowId =workflowId;
             var result = await _flowSynxClient.Workflows.AddTriggerAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Triggers/Delete/DeleteWorkflowTriggerCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Triggers/Delete/DeleteWorkflowTriggerCommandOptionsHandler.cs
@@ -41,10 +41,16 @@ private async Task Execute(DeleteWorkflowTriggerCommandOptions options, Cancella
                 _flowSynxClient.SetConnection(connection);
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            if (!Guid.TryParse(options.TriggerId, out Guid triggerId))
+                throw new FormatException("Invalid trigger id format. Expected a valid GUID.");
+
             var request = new DeleteWorkflowTriggerRequest 
             { 
-                WorkflowId = options.WorkflowId,
-                TriggerId = options.TriggerId,
+                WorkflowId = workflowId,
+                TriggerId = triggerId,
             };
             var result = await _flowSynxClient.Workflows.DeleteTriggerAsync(request, cancellationToken);
 
diff --git a/src/FlowCtl/Commands/Workflows/Triggers/Details/WorkflowTriggerDetailsCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Triggers/Details/WorkflowTriggerDetailsCommandOptionsHandler.cs
@@ -41,10 +41,16 @@ private async Task Execute(WorkflowTriggerDetailsCommandOptions options, Cancell
                 _flowSynxClient.SetConnection(connection);
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            if (!Guid.TryParse(options.TriggerId, out Guid triggerId))
+                throw new FormatException("Invalid trigger id format. Expected a valid GUID.");
+
             var request = new WorkflowTriggerDetailsRequest
             {
-                WorkflowId = options.WorkflowId, 
-                TriggerId = options.TriggerId 
+                WorkflowId = workflowId, 
+                TriggerId = triggerId
             };
             var result = await _flowSynxClient.Workflows.TriggerDetailsAsync(request, cancellationToken);
 
diff --git a/src/FlowCtl/Commands/Workflows/Triggers/Update/AddWorkflowTriggerCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Triggers/Update/AddWorkflowTriggerCommandOptionsHandler.cs
@@ -58,9 +58,15 @@ private async Task Execute(UpdateWorkflowTriggerCommandOptions options, Cancella
                 jsonData = options.Data;
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            if (!Guid.TryParse(options.TriggerId, out Guid triggerId))
+                throw new FormatException("Invalid trigger id format. Expected a valid GUID.");
+
             var request = GetUpdateTriggerData(jsonData);
-            request.WorkflowId = options.WorkflowId;
-            request.TriggerId = options.TriggerId;
+            request.WorkflowId = workflowId;
+            request.TriggerId = triggerId;
             var result = await _flowSynxClient.Workflows.UpdateTriggerAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Triggers/WorkflowTriggersCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Triggers/WorkflowTriggersCommandOptionsHandler.cs
@@ -41,7 +41,10 @@ private async Task Execute(WorkflowTriggersCommandOptions options, CancellationT
                 _flowSynxClient.SetConnection(connection);
             }
 
-            var request = new WorkflowTriggersListRequest { WorkflowId = options.WorkflowId };
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
+            var request = new WorkflowTriggersListRequest { WorkflowId = workflowId };
             var result = await _flowSynxClient.Workflows.TriggersAsync(request, cancellationToken);
 
             if (result.StatusCode != 200)
diff --git a/src/FlowCtl/Commands/Workflows/Update/UpdateWorkflowCommandOptionsHandler.cs b/src/FlowCtl/Commands/Workflows/Update/UpdateWorkflowCommandOptionsHandler.cs
@@ -54,9 +54,12 @@ private async Task Execute(UpdateWorkflowCommandOptions options, CancellationTok
                 definitionJsonData = options.Definition;
             }
 
+            if (!Guid.TryParse(options.WorkflowId, out Guid workflowId))
+                throw new FormatException("Invalid workflow id format. Expected a valid GUID.");
+
             var request = new UpdateWorkflowRequest 
             { 
-                Id = Guid.Parse(options.WorkflowId), 
+                Id = workflowId, 
                 Definition = definitionJsonData 
             };
             var result = await _flowSynxClient.Workflows.UpdateAsync(request, cancellationToken);
