Refactor and add unit tests for Csv plugin

Upgraded solution to Visual Studio 18 and reorganized projects under `src` and `tests` folders. Added a new unit test project (`FlowSynx.Plugins.Csv.UnitTests`) and configured `InternalsVisibleTo` for testing.

Refactored `CsvPlugin` and operations (`Filter`, `Map`, `Read`) into dedicated namespaces. Fixed a bug in `FilterOperation` where unfiltered records were used in CSV output.

Added comprehensive unit tests for plugin metadata, operations, helpers, and extensions. Introduced tests for filtering, mapping, and reading CSV data. Ensured better test coverage with fake implementations and structured data handling.

Improved maintainability and modularity by restructuring code and adding tests for core functionality.

#20

Author: ziagham

Plugins.Csv.sln

@@ -1,10 +1,16 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.12.35728.132 d17.12
+# Visual Studio Version 18
+VisualStudioVersion = 18.0.11222.15
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FlowSynx.Plugins.Csv", "src\FlowSynx.Plugins.Csv.csproj", "{ECD2DE21-BABA-4282-BD92-716CB6754967}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{090AF7A6-591F-434D-980A-C5CEF59FC206}"
+EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{AB101817-0D53-4EED-8CD4-9150EA5CF692}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FlowSynx.Pluigns.Csv.UnitTests", "tests\FlowSynx.Pluigns.Csv.UnitTests.csproj", "{535535BE-029E-4E1A-96F2-D14DE17A08E8}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -15,8 +21,19 @@ Global
 		{ECD2DE21-BABA-4282-BD92-716CB6754967}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{ECD2DE21-BABA-4282-BD92-716CB6754967}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{ECD2DE21-BABA-4282-BD92-716CB6754967}.Release|Any CPU.Build.0 = Release|Any CPU
+		{535535BE-029E-4E1A-96F2-D14DE17A08E8}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{535535BE-029E-4E1A-96F2-D14DE17A08E8}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{535535BE-029E-4E1A-96F2-D14DE17A08E8}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{535535BE-029E-4E1A-96F2-D14DE17A08E8}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
+	GlobalSection(NestedProjects) = preSolution
+		{ECD2DE21-BABA-4282-BD92-716CB6754967} = {090AF7A6-591F-434D-980A-C5CEF59FC206}
+		{535535BE-029E-4E1A-96F2-D14DE17A08E8} = {AB101817-0D53-4EED-8CD4-9150EA5CF692}
+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {E475AAEF-3830-486C-A5B3-E92B6EBBE1C6}
+	EndGlobalSection
 EndGlobal

src/CsvPlugin.cs

@@ -2,8 +2,9 @@
 using FlowSynx.PluginCore;
 using FlowSynx.PluginCore.Extensions;
 using FlowSynx.Plugins.Csv.Services;
-using FlowSynx.Plugins.Csv.Operations;
-using FlowSynx.Plugins.Csv.Parameters;
+using FlowSynx.Plugins.Csv.Operations.Read;
+using FlowSynx.Plugins.Csv.Operations.Map;
+using FlowSynx.Plugins.Csv.Operations.Filter;
 
 namespace FlowSynx.Plugins.Csv;
 

src/FlowSynx.Plugins.Csv.csproj

@@ -16,6 +16,10 @@
 		<PackageReference Include="FlowSynx.PluginCore" Version="1.4.0" />
 	</ItemGroup>
 
+	<ItemGroup>
+		<InternalsVisibleTo Include="FlowSynx.Pluigns.Csv.UnitTests" />
+	</ItemGroup>
+	
 	<ItemGroup>
 		<Compile Update="Resources.Designer.cs">
 			<DesignTime>True</DesignTime>
@@ -40,4 +44,9 @@
 		</None>
 	</ItemGroup>
 
+	<ItemGroup>
+	  <Folder Include="Parameters\" />
+	  <Folder Include="Properties\" />
+	</ItemGroup>
+
 </Project>

src/Operations/FilterOperation.cs src/Operations/Filter/FilterOperation.cssrc/Operations/FilterOperation.cs renamed to src/Operations/Filter/FilterOperation.cs

@@ -3,13 +3,12 @@
 using FlowSynx.PluginCore;
 using FlowSynx.Plugins.Csv.Helpers;
 using FlowSynx.Plugins.Csv.Models;
-using FlowSynx.Plugins.Csv.Parameters;
 using FlowSynx.Plugins.Csv.Services;
 using System.Dynamic;
 using System.Globalization;
 using System.Text.Json;
 
-namespace FlowSynx.Plugins.Csv.Operations;
+namespace FlowSynx.Plugins.Csv.Operations.Filter;
 
 internal class FilterOperation : IPluginOperation<FilterParameters, PluginContext>
 {
@@ -28,7 +27,9 @@ internal class FilterOperation : IPluginOperation<FilterParameters, PluginContex
         if (!isJson)
             throw new ArgumentException("Invalid filter structure.");
 
-        var rootGroup = JsonSerializer.Deserialize<FilterGroup>(parameters.Filters?.ToString()!);
+        // Use case-insensitive property name matching so JSON like {"logic":..., "filters":...} binds correctly
+        var jsonOptions = new JsonSerializerOptions { PropertyNameCaseInsensitive = true };
+        var rootGroup = JsonSerializer.Deserialize<FilterGroup>(parameters.Filters?.ToString()!, jsonOptions);
 
         if (rootGroup is null)
             throw new ArgumentException("Invalid filter structure.");
@@ -60,7 +61,7 @@ internal class FilterOperation : IPluginOperation<FilterParameters, PluginContex
         }).ToList();
 
         var result = records.Where(row => EvaluateFilterGroup(row, rootGroup)).ToList();
-        var csvString = await helper.ToCsvStringAsync(records, parameters.Delimiter, parameters.IgnoreBlankLines, parameters.HasHeader);
+        var csvString = await helper.ToCsvStringAsync(result, parameters.Delimiter, parameters.IgnoreBlankLines, parameters.HasHeader);
 
 
 

src/Parameters/FilterParameters.cs src/Operations/Filter/FilterParameters.cssrc/Parameters/FilterParameters.cs renamed to src/Operations/Filter/FilterParameters.cs

@@ -1,6 +1,6 @@
 using FlowSynx.PluginCore;
 
-namespace FlowSynx.Plugins.Csv.Parameters;
+namespace FlowSynx.Plugins.Csv.Operations.Filter;
 
 public class FilterParameters
 {

src/Operations/MapOperation.cs src/Operations/Map/MapOperation.cssrc/Operations/MapOperation.cs renamed to src/Operations/Map/MapOperation.cs

@@ -2,12 +2,11 @@
 using CsvHelper.Configuration;
 using FlowSynx.PluginCore;
 using FlowSynx.Plugins.Csv.Helpers;
-using FlowSynx.Plugins.Csv.Parameters;
 using FlowSynx.Plugins.Csv.Services;
 using System.Dynamic;
 using System.Globalization;
 
-namespace FlowSynx.Plugins.Csv.Operations;
+namespace FlowSynx.Plugins.Csv.Operations.Map;
 
 internal class MapOperation : IPluginOperation<MapParameters, PluginContext>
 {

src/Parameters/MapParameters.cs src/Operations/Map/MapParameters.cssrc/Parameters/MapParameters.cs renamed to src/Operations/Map/MapParameters.cs

@@ -1,6 +1,6 @@
 using FlowSynx.PluginCore;
 
-namespace FlowSynx.Plugins.Csv.Parameters;
+namespace FlowSynx.Plugins.Csv.Operations.Map;
 
 public class MapParameters
 {

src/Operations/ReadOperation.cs src/Operations/Read/ReadOperation.cssrc/Operations/ReadOperation.cs renamed to src/Operations/Read/ReadOperation.cs

@@ -2,12 +2,11 @@
 using CsvHelper.Configuration;
 using FlowSynx.PluginCore;
 using FlowSynx.Plugins.Csv.Helpers;
-using FlowSynx.Plugins.Csv.Parameters;
 using FlowSynx.Plugins.Csv.Services;
 using System.Dynamic;
 using System.Globalization;
 
-namespace FlowSynx.Plugins.Csv.Operations;
+namespace FlowSynx.Plugins.Csv.Operations.Read;
 
 internal class ReadOperation : IPluginOperation<ReadParameters, PluginContext>
 {

src/Parameters/ReadParameters.cs src/Operations/Read/ReadParameters.cssrc/Parameters/ReadParameters.cs renamed to src/Operations/Read/ReadParameters.cs

@@ -1,6 +1,6 @@
 using FlowSynx.PluginCore;
 
-namespace FlowSynx.Plugins.Csv.Parameters;
+namespace FlowSynx.Plugins.Csv.Operations.Read;
 
 public class ReadParameters
 {

tests/CsvPluginTests.cs

@@ -0,0 +1,63 @@
+using FlowSynx.PluginCore;
+using FlowSynx.Plugins.Csv;
+using FlowSynx.Plugins.Csv.Services;
+using Xunit;
+
+namespace FlowSynx.Pluign.Csv.UnitTests;
+
+public class CsvPluginTests
+{
+    private class FakeGuidProvider : IGuidProvider
+    {
+        public Guid NewGuid() => Guid.Parse("00000000-0000-0000-0000-000000000123");
+    }
+
+    private class FakeReflectionGuard : IReflectionGuard
+    {
+        public bool IsCalledViaReflection() => false;
+    }
+
+    private class DummyLogger : IPluginLogger
+    {
+        public void Log(PluginLoggerLevel level, string message) { }
+    }
+
+    [Fact]
+    public void Metadata_HasExpectedValues()
+    {
+        var plugin = new CsvPlugin();
+        var md = plugin.Metadata;
+        Assert.Equal("Csv", md.Name);
+        Assert.Equal("FlowSynx", md.CompanyName);
+        Assert.Equal("flowsynx.png", md.Icon);
+        Assert.Equal("README.md", md.ReadMe);
+        Assert.Equal(1, md.Version.Major);
+    }
+
+    [Fact]
+    public async Task InitializeAsync_SetsSpecifications()
+    {
+        var plugin = new CsvPlugin(new FakeGuidProvider(), new FakeReflectionGuard());
+        await plugin.InitializeAsync(new DummyLogger(), new Dictionary<string, object?>());
+        Assert.NotNull(plugin.Specifications);
+    }
+
+    [Fact]
+    public async Task ExecuteAsync_BeforeInit_Throws()
+    {
+        var plugin = new CsvPlugin(new FakeGuidProvider(), new FakeReflectionGuard());
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
+            plugin.ExecuteAsync("read", new PluginParameters(), CancellationToken.None));
+        Assert.Contains("not initialized", ex.Message);
+    }
+
+    [Fact]
+    public async Task ExecuteAsync_UnsupportedOperation_Throws()
+    {
+        var plugin = new CsvPlugin(new FakeGuidProvider(), new FakeReflectionGuard());
+        await plugin.InitializeAsync(new DummyLogger(), null);
+        var ex = await Assert.ThrowsAsync<NotSupportedException>(() =>
+            plugin.ExecuteAsync("unknown", new PluginParameters(), CancellationToken.None));
+        Assert.Contains("not supported", ex.Message);
+    }
+}